Re: [RFC 0/2] Add Pooled EU support

Mika Kuoppala
2015-07-13T10:16:37Z

Arun Siluvery <arun.siluvery@linux.intel.com> writes:

> These patches enabled Pooled EU support for BXT, they are implemented
> by Armin Reese. I am sending these patches in its current form for comments.
>
> These patches modify Golden batch to have a set of modification values
> where we can change the commands based on Gen. The commands to enable
> Pooled EU are inserted after MI_BATCH_BUFFER_END. If the given Gen
> supports this feature, modification values are used to replace
> MI_BATCH_BUFFER_END so we send commands to enable Pooled EU. These
> commands need to be part of this batch because they are to be
> initialized only once. Userspace will have option to query the
> availability of this feature, those changes are not included in
> this series.
>
> I would like to upstream this feature and really appreciate any
> comments in this regard.
>

Latest command stream programming guide has this to say
in context initialization:

"Render CS Only: Render state need not be initialized"

If it is so that we get a proper render state from hw,
with 'Restore Inhibit', then we can get rid of golden
context for skl+.

-Mika

> Armin Reese (2):
> drm/i915: Offsets for golden context BB modification
> drm/i915/bxt: Enable pooled EUs for BXT
>
> drivers/gpu/drm/i915/i915_gem_render_state.c | 125 +++++++++++++++++++++++++-
> drivers/gpu/drm/i915/i915_gem_render_state.h | 7 ++
> drivers/gpu/drm/i915/intel_renderstate.h | 6 +-
> drivers/gpu/drm/i915/intel_renderstate_gen6.c | 4 +
> drivers/gpu/drm/i915/intel_renderstate_gen7.c | 4 +
> drivers/gpu/drm/i915/intel_renderstate_gen8.c | 4 +
> drivers/gpu/drm/i915/intel_renderstate_gen9.c | 18 ++--
> 7 files changed, 157 insertions(+), 11 deletions(-)
>
> --
> 1.9.1
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx