From mboxrd@z Thu Jan 1 00:00:00 1970 From: Imre Deak Subject: Re: [PATCH 1/3] drm/i915: combine i9xx_get_hpd_pins and pch_get_hpd_pins Date: Tue, 21 Jul 2015 10:58:43 -0700 Message-ID: <1437501523.3787.7.camel@intel.com> References: <1437428619-30160-1-git-send-email-imre.deak@intel.com> <1437428619-30160-2-git-send-email-imre.deak@intel.com> <55AE00C1.2050402@intel.com> Reply-To: imre.deak@intel.com Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by gabe.freedesktop.org (Postfix) with ESMTP id 2D8776E3BF for ; Tue, 21 Jul 2015 10:58:46 -0700 (PDT) In-Reply-To: <55AE00C1.2050402@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Sivakumar Thulasimani Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gVHVlLCAyMDE1LTA3LTIxIGF0IDEzOjUwICswNTMwLCBTaXZha3VtYXIgVGh1bGFzaW1hbmkg d3JvdGU6Cj4gCj4gT24gNy8yMS8yMDE1IDM6MTMgQU0sIEltcmUgRGVhayB3cm90ZToKPiA+IFRo ZXNlIGZ1bmN0aW9ucyBhcmUgcXVpdGUgc2ltaWxhciwgc28gY29tYmluZSB0aGVtIHdpdGggdGhl IHVzZSBvZiBhIG5ldwo+ID4gYXJndW1lbnQgZm9yIGEgZnVuY3Rpb24gdGhhdCBkZXRlY3RzIGxv bmcgcHVsc2VzLiBUaGlzIHdpbGwgYmUgYWxzbwo+ID4gbmVlZGVkIGJ5IGFuIHVwY29taW5nIHBh dGNoIGFkZGluZyBzdXBwb3J0IGZvciBCWFQgbG9uZyBwdWxzZSBkZXRlY3Rpb24uCj4gPgo+ID4g Tm8gZnVuY3Rpb25hbCBjaGFuZ2UuCj4gPgo+ID4gU2lnbmVkLW9mZi1ieTogSW1yZSBEZWFrIDxp bXJlLmRlYWtAaW50ZWwuY29tPgo+ID4gLS0tCj4gPiAgIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2k5 MTVfaXJxLmMgfCA1NCArKysrKysrKysrKysrKy0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQo+ ID4gICAxIGZpbGUgY2hhbmdlZCwgMTggaW5zZXJ0aW9ucygrKSwgMzYgZGVsZXRpb25zKC0pCj4g Pgo+ID4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfaXJxLmMgYi9kcml2 ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2lycS5jCj4gPiBpbmRleCBhNmZiZTY0Li4zMDZkZTc4IDEw MDY0NAo+ID4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9pcnEuYwo+ID4gKysrIGIv ZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9pcnEuYwo+ID4gQEAgLTEyNTYsOSArMTI1NiwxMCBA QCBzdGF0aWMgYm9vbCBpOXh4X3BvcnRfaG90cGx1Z19sb25nX2RldGVjdChlbnVtIHBvcnQgcG9y dCwgdTMyIHZhbCkKPiA+ICAgfQo+ID4gICAKPiA+ICAgLyogR2V0IGEgYml0IG1hc2sgb2YgcGlu cyB0aGF0IGhhdmUgdHJpZ2dlcmVkLCBhbmQgd2hpY2ggb25lcyBtYXkgYmUgbG9uZy4gKi8KPiA+ IC1zdGF0aWMgdm9pZCBwY2hfZ2V0X2hwZF9waW5zKHUzMiAqcGluX21hc2ssIHUzMiAqbG9uZ19t YXNrLAo+ID4gK3N0YXRpYyB2b2lkIGludGVsX2dldF9ocGRfcGlucyh1MzIgKnBpbl9tYXNrLCB1 MzIgKmxvbmdfbWFzaywKPiA+ICAgCQkJICAgICB1MzIgaG90cGx1Z190cmlnZ2VyLCB1MzIgZGln X2hvdHBsdWdfcmVnLAo+ID4gLQkJCSAgICAgY29uc3QgdTMyIGhwZFtIUERfTlVNX1BJTlNdKQo+ ID4gKwkJCSAgICAgY29uc3QgdTMyIGhwZFtIUERfTlVNX1BJTlNdLAo+ID4gKwkJCSAgICAgYm9v bCBsb25nX3B1bHNlX2RldGVjdChlbnVtIHBvcnQgcG9ydCwgdTMyIHZhbCkpCj4gPiAgIHsKPiA+ ICAgCWVudW0gcG9ydCBwb3J0Owo+ID4gICAJaW50IGk7Cj4gPiBAQCAtMTI3Niw3ICsxMjc3LDcg QEAgc3RhdGljIHZvaWQgcGNoX2dldF9ocGRfcGlucyh1MzIgKnBpbl9tYXNrLCB1MzIgKmxvbmdf bWFzaywKPiA+ICAgCQkqcGluX21hc2sgfD0gQklUKGkpOwo+ID4gICAKPiA+ICAgCQlwb3J0ID0g aW50ZWxfaHBkX3Bpbl90b19wb3J0KGkpOwo+ID4gLQkJaWYgKHBjaF9wb3J0X2hvdHBsdWdfbG9u Z19kZXRlY3QocG9ydCwgZGlnX2hvdHBsdWdfcmVnKSkKPiA+ICsJCWlmIChsb25nX3B1bHNlX2Rl dGVjdChwb3J0LCBkaWdfaG90cGx1Z19yZWcpKQo+ID4gICAJCQkqbG9uZ19tYXNrIHw9IEJJVChp KTsKPiA+ICAgCX0KPiA+ICAgCj4gPiBAQCAtMTI4NSwzNCArMTI4Niw2IEBAIHN0YXRpYyB2b2lk IHBjaF9nZXRfaHBkX3BpbnModTMyICpwaW5fbWFzaywgdTMyICpsb25nX21hc2ssCj4gPiAgIAo+ ID4gICB9Cj4gPiAgIAo+ID4gLS8qIEdldCBhIGJpdCBtYXNrIG9mIHBpbnMgdGhhdCBoYXZlIHRy aWdnZXJlZCwgYW5kIHdoaWNoIG9uZXMgbWF5IGJlIGxvbmcuICovCj4gPiAtc3RhdGljIHZvaWQg aTl4eF9nZXRfaHBkX3BpbnModTMyICpwaW5fbWFzaywgdTMyICpsb25nX21hc2ssCj4gPiAtCQkJ ICAgICAgdTMyIGhvdHBsdWdfdHJpZ2dlciwgY29uc3QgdTMyIGhwZFtIUERfTlVNX1BJTlNdKQo+ ID4gLXsKPiA+IC0JZW51bSBwb3J0IHBvcnQ7Cj4gPiAtCWludCBpOwo+ID4gLQo+ID4gLQkqcGlu X21hc2sgPSAwOwo+ID4gLQkqbG9uZ19tYXNrID0gMDsKPiA+IC0KPiA+IC0JaWYgKCFob3RwbHVn X3RyaWdnZXIpCj4gPiAtCQlyZXR1cm47Cj4gPiAtCj4gPiAtCWZvcl9lYWNoX2hwZF9waW4oaSkg ewo+ID4gLQkJaWYgKChocGRbaV0gJiBob3RwbHVnX3RyaWdnZXIpID09IDApCj4gPiAtCQkJY29u dGludWU7Cj4gPiAtCj4gPiAtCQkqcGluX21hc2sgfD0gQklUKGkpOwo+ID4gLQo+ID4gLQkJcG9y dCA9IGludGVsX2hwZF9waW5fdG9fcG9ydChpKTsKPiA+IC0JCWlmIChpOXh4X3BvcnRfaG90cGx1 Z19sb25nX2RldGVjdChwb3J0LCBob3RwbHVnX3RyaWdnZXIpKQo+ID4gLQkJCSpsb25nX21hc2sg fD0gQklUKGkpOwo+ID4gLQl9Cj4gPiAtCj4gPiAtCURSTV9ERUJVR19EUklWRVIoImhvdHBsdWcg ZXZlbnQgcmVjZWl2ZWQsIHN0YXQgMHglMDh4LCBwaW5zIDB4JTA4eFxuIiwKPiA+IC0JCQkgaG90 cGx1Z190cmlnZ2VyLCAqcGluX21hc2spOwo+ID4gLX0KPiA+IC0KPiA+ICAgc3RhdGljIHZvaWQg Z21idXNfaXJxX2hhbmRsZXIoc3RydWN0IGRybV9kZXZpY2UgKmRldikKPiA+ICAgewo+ID4gICAJ c3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2ID0gZGV2LT5kZXZfcHJpdmF0ZTsKPiA+ IEBAIC0xNTUwLDcgKzE1MjMsOSBAQCBzdGF0aWMgdm9pZCBpOXh4X2hwZF9pcnFfaGFuZGxlcihz dHJ1Y3QgZHJtX2RldmljZSAqZGV2KQo+ID4gICAJaWYgKElTX0c0WChkZXYpIHx8IElTX1ZBTExF WVZJRVcoZGV2KSkgewo+ID4gICAJCXUzMiBob3RwbHVnX3RyaWdnZXIgPSBob3RwbHVnX3N0YXR1 cyAmIEhPVFBMVUdfSU5UX1NUQVRVU19HNFg7Cj4gPiAgIAo+ID4gLQkJaTl4eF9nZXRfaHBkX3Bp bnMoJnBpbl9tYXNrLCAmbG9uZ19tYXNrLCBob3RwbHVnX3RyaWdnZXIsIGhwZF9zdGF0dXNfZzR4 KTsKPiA+ICsJCWludGVsX2dldF9ocGRfcGlucygmcGluX21hc2ssICZsb25nX21hc2ssIGhvdHBs dWdfdHJpZ2dlciwKPiA+ICsJCQkJICAgaG90cGx1Z190cmlnZ2VyLCBocGRfc3RhdHVzX2c0eCwK PiA+ICsJCQkJICAgaTl4eF9wb3J0X2hvdHBsdWdfbG9uZ19kZXRlY3QpOwo+ID4gICAJCWludGVs X2hwZF9pcnFfaGFuZGxlcihkZXYsIHBpbl9tYXNrLCBsb25nX21hc2spOwo+ID4gICAKPiA+ICAg CQlpZiAoaG90cGx1Z19zdGF0dXMgJiBEUF9BVVhfQ0hBTk5FTF9NQVNLX0lOVF9TVEFUVVNfRzRY KQo+ID4gQEAgLTE1NTgsNyArMTUzMyw5IEBAIHN0YXRpYyB2b2lkIGk5eHhfaHBkX2lycV9oYW5k bGVyKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYpCj4gPiAgIAl9IGVsc2Ugewo+ID4gICAJCXUzMiBo b3RwbHVnX3RyaWdnZXIgPSBob3RwbHVnX3N0YXR1cyAmIEhPVFBMVUdfSU5UX1NUQVRVU19JOTE1 Owo+ID4gICAKPiA+IC0JCWk5eHhfZ2V0X2hwZF9waW5zKCZwaW5fbWFzaywgJmxvbmdfbWFzaywg aG90cGx1Z190cmlnZ2VyLCBocGRfc3RhdHVzX2k5MTUpOwo+ID4gKwkJaW50ZWxfZ2V0X2hwZF9w aW5zKCZwaW5fbWFzaywgJmxvbmdfbWFzaywgaG90cGx1Z190cmlnZ2VyLAo+ID4gKwkJCQkgICBo b3RwbHVnX3RyaWdnZXIsIGhwZF9zdGF0dXNfZzR4LAo+ID4gKwkJCQkgICBpOXh4X3BvcnRfaG90 cGx1Z19sb25nX2RldGVjdCk7Cj4gPiAgIAkJaW50ZWxfaHBkX2lycV9oYW5kbGVyKGRldiwgcGlu X21hc2ssIGxvbmdfbWFzayk7Cj4gPiAgIAl9Cj4gPiAgIH0KPiA+IEBAIC0xNjY0LDcgKzE2NDEs OSBAQCBzdGF0aWMgdm9pZCBpYnhfaXJxX2hhbmRsZXIoc3RydWN0IGRybV9kZXZpY2UgKmRldiwg dTMyIHBjaF9paXIpCj4gPiAgIAlkaWdfaG90cGx1Z19yZWcgPSBJOTE1X1JFQUQoUENIX1BPUlRf SE9UUExVRyk7Cj4gPiAgIAlJOTE1X1dSSVRFKFBDSF9QT1JUX0hPVFBMVUcsIGRpZ19ob3RwbHVn X3JlZyk7Cj4gPiAgIAo+ID4gLQlwY2hfZ2V0X2hwZF9waW5zKCZwaW5fbWFzaywgJmxvbmdfbWFz aywgaG90cGx1Z190cmlnZ2VyLCBkaWdfaG90cGx1Z19yZWcsIGhwZF9pYngpOwo+ID4gKwlpbnRl bF9nZXRfaHBkX3BpbnMoJnBpbl9tYXNrLCAmbG9uZ19tYXNrLCBob3RwbHVnX3RyaWdnZXIsCj4g PiArCQkJICAgZGlnX2hvdHBsdWdfcmVnLCBocGRfaWJ4LAo+ID4gKwkJCSAgIHBjaF9wb3J0X2hv dHBsdWdfbG9uZ19kZXRlY3QpOwo+ID4gICAJaW50ZWxfaHBkX2lycV9oYW5kbGVyKGRldiwgcGlu X21hc2ssIGxvbmdfbWFzayk7Cj4gPiAgIAo+ID4gICAJaWYgKHBjaF9paXIgJiBTREVfQVVESU9f UE9XRVJfTUFTSykgewo+ID4gQEAgLTE3NjMsNyArMTc0Miw5IEBAIHN0YXRpYyB2b2lkIGNwdF9p cnFfaGFuZGxlcihzdHJ1Y3QgZHJtX2RldmljZSAqZGV2LCB1MzIgcGNoX2lpcikKPiA+ICAgCWRp Z19ob3RwbHVnX3JlZyA9IEk5MTVfUkVBRChQQ0hfUE9SVF9IT1RQTFVHKTsKPiA+ICAgCUk5MTVf V1JJVEUoUENIX1BPUlRfSE9UUExVRywgZGlnX2hvdHBsdWdfcmVnKTsKPiA+ICAgCj4gPiAtCXBj aF9nZXRfaHBkX3BpbnMoJnBpbl9tYXNrLCAmbG9uZ19tYXNrLCBob3RwbHVnX3RyaWdnZXIsIGRp Z19ob3RwbHVnX3JlZywgaHBkX2NwdCk7Cj4gPiArCWludGVsX2dldF9ocGRfcGlucygmcGluX21h c2ssICZsb25nX21hc2ssIGhvdHBsdWdfdHJpZ2dlciwKPiA+ICsJCQkgICBkaWdfaG90cGx1Z19y ZWcsIGhwZF9jcHQsCj4gPiArCQkJICAgcGNoX3BvcnRfaG90cGx1Z19sb25nX2RldGVjdCk7Cj4g PiAgIAlpbnRlbF9ocGRfaXJxX2hhbmRsZXIoZGV2LCBwaW5fbWFzaywgbG9uZ19tYXNrKTsKPiA+ ICAgCj4gPiAgIAlpZiAocGNoX2lpciAmIFNERV9BVURJT19QT1dFUl9NQVNLX0NQVCkgewo+ID4g QEAgLTE5NzksNyArMTk2MCw4IEBAIHN0YXRpYyB2b2lkIGJ4dF9ocGRfaGFuZGxlcihzdHJ1Y3Qg ZHJtX2RldmljZSAqZGV2LCB1aW50MzJfdCBpaXJfc3RhdHVzKQo+ID4gICAJLyogQ2xlYXIgc3Rp Y2t5IGJpdHMgaW4gaHBkIHN0YXR1cyAqLwo+ID4gICAJSTkxNV9XUklURShCWFRfSE9UUExVR19D VEwsIGhwX2NvbnRyb2wpOwo+ID4gICAKPiA+IC0JcGNoX2dldF9ocGRfcGlucygmcGluX21hc2ss ICZsb25nX21hc2ssIGhwX3RyaWdnZXIsIGhwX2NvbnRyb2wsIGhwZF9ieHQpOwo+ID4gKwlpbnRl bF9nZXRfaHBkX3BpbnMoJnBpbl9tYXNrLCAmbG9uZ19tYXNrLCBocF90cmlnZ2VyLCBocF9jb250 cm9sLAo+ID4gKwkJCSAgIGhwZF9ieHQsIHBjaF9wb3J0X2hvdHBsdWdfbG9uZ19kZXRlY3QpOwo+ ID4gICAJaW50ZWxfaHBkX2lycV9oYW5kbGVyKGRldiwgcGluX21hc2ssIGxvbmdfbWFzayk7Cj4g PiAgIH0KPiA+ICAgCj4gYSB3aGF0IGlmIHF1ZXN0aW9uIDopLCBiZWZvcmUgdGhpcyBjaGFuZ2Ug b25seSBpbnRlbF9ocGRfaXJxX2hhbmRsZXIgd2FzIAo+IHBsYXRmb3JtIGluZGVwZW5kZW50IGFu ZAo+IGl0IHdhcyBpbiBpbnRlbF9ob3RwbHVnLmMgZmlsZS4gTm93IHdlIGhhdmUgb25lIG1vcmUg ZnVuY3Rpb24gd2hpY2ggaXMgCj4gKGkgYW0gYXNzdW1pbmcpIHBsYXRmb3JtIGluZGVwZW5kZW50 Cj4gYW5kIGlzIGFsd2F5cyBjYWxsZWQgYmVmb3JlIGludGVsX2hwZF9pcnFfaGFuZGxlci4KPiAK PiBjYW4gd2UgbW92ZSB0aGUgaW50ZWxfZ2V0X2hwZF9waW5zIHRvIGludGVsX2hvdHBsdWcuYyBi eSByZW5tYWluZyBpdCBhcyAKPiBpbnRlbF9ocGRfZ2V0X3BpbnMgJiBjYWxsIHRoZQo+IGludGVs X2hwZF9pcnFfaGFuZGxlciBmdW5jdGlvbiBhdCB0aGUgZW5kIG9mIHRoaXMgbmV3IGZ1bmN0aW9u ID8KClllcywgZmFjdG9yaW5nIG91dCBpbnRlbF9nZXRfaHBkX3BpbnMoKSBhbmQgaW50ZWxfaHBk X2lycV9oYW5kbGVyKCkgaW50bwphIG5ldyBmdW5jdGlvbiBpcyBhIGdvb2QgaWRlYS4gSSB0aGlu ayBpdCdzIGJlc3QgZG9uZSBhcyBmb2xsb3ctdXAKdGhvdWdoLCBzbyBtYXliZSB5b3UgY291bGQg ZG8gdGhpcyBhZnRlciB0aGlzIHBhdGNoc2V0IGlzIG1lcmdlZD8KCi0tSW1yZQoKX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcg bGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0cy5mcmVlZGVz a3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK