Re: [PATCH 0/3] drm/i915/bxt: HPD long/short pulse detect support on port A

Imre Deak
2015-07-21T17:42:12Z

On Tue, 2015-07-21 at 11:40 +0530, Jindal, Sonika wrote:
> For the patch 3, the commit message can be changed to only "long pulse
> detection" instead of "long/short" because you are not adding support
> for short pulse detection.

Well it is support for differentiating between long and short pulses. We
don't check for the short pulse HW flag, but we do imply it in
intel_hpd_irq_handler() if the long pulse flag is not set.

>
> Otherwise, this series looks good to me.
>
> Reviewed-by: Sonika Jindal <sonika.jindal@intel.com>
>
> On 7/21/2015 3:13 AM, Imre Deak wrote:
> > This patchset is a dependency for enabling generic HPD support on the
> > port A pin.
> >
> > Imre Deak (3):
> > drm/i915: combine i9xx_get_hpd_pins and pch_get_hpd_pins
> > drm/i915: don't use HPD_PORT_A as an alias for HPD_NONE
> > drm/i915/bxt: add support for HPD long/short pulse detection on
> > HPD_PORT_A pin
> >
> > drivers/gpu/drm/i915/i915_drv.h | 4 +-
> > drivers/gpu/drm/i915/i915_irq.c | 72 ++++++++++++++++++------------------
> > drivers/gpu/drm/i915/i915_reg.h | 5 +++
> > drivers/gpu/drm/i915/intel_hotplug.c | 20 ++++++----
> > 4 files changed, 55 insertions(+), 46 deletions(-)
> >