Re: [PATCH 2/6] drm/atomic: pass old crtc state to atomic_begin/flush.

Maarten Lankhorst
2015-08-06T12:35:46Z

Hey,

Op 05-08-15 om 08:18 schreef Tomi Valkeinen:
> Hi,
>
> On 21/07/15 14:28, Maarten Lankhorst wrote:
>> In intel it's useful to keep track of some state changes with old
>> crtc state vs new state, for example to disable initial planes or
>> when a modeset's prevented during fastboot.
>>
>> Cc: dri-devel@lists.freedesktop.org
>> Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
>> ---
>> drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c | 6 ++++--
>> drivers/gpu/drm/drm_atomic_helper.c | 8 ++++----
>> drivers/gpu/drm/drm_plane_helper.c | 4 ++--
>> drivers/gpu/drm/i915/intel_display.c | 10 ++++++----
>> drivers/gpu/drm/msm/mdp/mdp4/mdp4_crtc.c | 6 ++++--
>> drivers/gpu/drm/msm/mdp/mdp5/mdp5_crtc.c | 6 ++++--
>> drivers/gpu/drm/rcar-du/rcar_du_crtc.c | 6 ++++--
>> drivers/gpu/drm/sti/sti_drm_crtc.c | 6 ++++--
>> drivers/gpu/drm/tegra/dc.c | 6 ++++--
>> include/drm/drm_crtc_helper.h | 6 ++++--
>> 10 files changed, 40 insertions(+), 24 deletions(-)
> Looks like this broke omapdrm in linux-next:
>
> drivers/gpu/drm/omapdrm/omap_crtc.c:470:2: error: initialization from
> incompatible pointer type [-Werror]
> drivers/gpu/drm/omapdrm/omap_crtc.c:470:2: error: (near initialization
> for ‘omap_crtc_helper_funcs.atomic_begin’) [-Werror]
> drivers/gpu/drm/omapdrm/omap_crtc.c:471:2: error: initialization from
> incompatible pointer type [-Werror]
> drivers/gpu/drm/omapdrm/omap_crtc.c:471:2: error: (near initialization
> for ‘omap_crtc_helper_funcs.atomic_flush’) [-Werror]
>
> Tomi
>
This has been fixed up in topic/drm-misc? Compiles for me cleanly there.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org