From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ander Conselvan De Oliveira Subject: Re: [PATCH v2.1 03/12] drm/i915: Convert connector checking to atomic, v2. Date: Fri, 31 Jul 2015 12:37:00 +0300 Message-ID: <1438335420.2676.5.camel@gmail.com> References: <1438000541-3219-1-git-send-email-maarten.lankhorst@linux.intel.com> <1438000541-3219-4-git-send-email-maarten.lankhorst@linux.intel.com> <1438089223.2727.17.camel@gmail.com> <55BA1F57.4000406@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-pa0-f50.google.com (mail-pa0-f50.google.com [209.85.220.50]) by gabe.freedesktop.org (Postfix) with ESMTPS id F075C6ED3B for ; Fri, 31 Jul 2015 02:37:07 -0700 (PDT) Received: by pachj5 with SMTP id hj5so38244450pac.3 for ; Fri, 31 Jul 2015 02:37:07 -0700 (PDT) In-Reply-To: <55BA1F57.4000406@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Maarten Lankhorst , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gVGh1LCAyMDE1LTA3LTMwIGF0IDE0OjU3ICswMjAwLCBNYWFydGVuIExhbmtob3JzdCB3cm90 ZToKPiBSaWdodCBub3cgZHBtcyBjYWxsYmFja3MgY2FuIHN0aWxsIGZpZGRsZSB3aXRoIHRoZSBj b25uZWN0b3Igc3RhdGUsCj4gYnV0IGl0IGNhbiBvbmx5IHR1cm4gY29ubmVjdG9ycyBvZmYuCj4g Cj4gVGhpcyBpcyByZW1lZGlhdGVkIGJ5IG9ubHkgY2hlY2tpbmcgY3J0Yy0+c3RhdGUtPmFjdGl2 ZSB3aGVuIHRoZQo+IGNvbm5lY3RvciBpcyBhY3RpdmUsIGFuZCBpZ25vcmUgY3J0Yy0+c3RhdGUt PmFjdGl2ZSB3aGVuIHRoZQo+IGNvbm5lY3RvciBpcyBvZmYuCj4gCj4gY29ubmVjdG9yc19hY3Rp dmUgaXMgbm8gbG9uZ2VyIGNoZWNrZWQsIGFuZCB3aWxsIGJlIHJlbW92ZWQgbGF0ZXIKPiBpbiB0 aGlzIHNlcmllcyB0b2dldGhlciB3aXRoIGRwbXMuCj4gCj4gQW5vdGhlciBjaGVjayBmb3IgIWVu Y29kZXItPmNydGMgaXMgcGVyZm9ybWVkIGJ5IGNoZWNrX2VuY29kZXJfc3RhdGUKPiB0b28sIHNv IGl0IGNhbiBiZSByZW1vdmVkLgo+IAo+IENoYW5nZXMgc2luY2UgdjE6Cj4gLSBBZGQgY29tbWl0 IG1lc3NhZ2UuCj4gLSByZW5hbWUgc3RhdGUgdG8gb2xkX3N0YXRlLgo+IC0gTW92ZSBkZWxldGlv biBvZiBtc3RfcG9ydCBjaGVjayB0byBtc3QgcGF0Y2guCgpJIGRpZG4ndCBzZWUgdGhlIHJlc3Bp biBvZiB0aGF0IHBhdGNoLCBzbyB0aGlzIG9uZSBkaWRuJ3QgYXBwbHkgY2xlYW5seSBmb3IgbWUu IEkgaGFkIHRvIGVkaXQgdGhlCm1zdCBwYXRjaCBmaXJzdC4KClJldmlld2VkLWJ5OiBBbmRlciBD b25zZWx2YW4gZGUgT2xpdmVpcmEgPGNvbnNlbHZhbjJAZ21haWwuY29tPgoKPiAKPiBTaWduZWQt b2ZmLWJ5OiBNYWFydGVuIExhbmtob3JzdCA8bWFhcnRlbi5sYW5raG9yc3RAbGludXguaW50ZWwu Y29tPgo+IC0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMgfCA2NiAr KysrKysrKysrKysrKysrKy0tLS0tLS0tLS0tLS0tLS0tLS0KPiAgMSBmaWxlIGNoYW5nZWQsIDMy IGluc2VydGlvbnMoKyksIDM0IGRlbGV0aW9ucygtKQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJz L2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRl bF9kaXNwbGF5LmMKPiBpbmRleCA3N2I0ZGE3ZTY5OGMuLjg3NjA3MWFkNDY4MSAxMDA2NDQKPiAt LS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMKPiArKysgYi9kcml2ZXJz L2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMKPiBAQCAtNjM2MCwzOCArNjM2MCwzMyBAQCBz dGF0aWMgdm9pZCBpbnRlbF9lbmNvZGVyX2RwbXMoc3RydWN0IGludGVsX2VuY29kZXIgKmVuY29k ZXIsIGludCBtb2RlKQo+ICAgKiBpbnRlcm5hbCBjb25zaXN0ZW5jeSkuICovCj4gIHN0YXRpYyB2 b2lkIGludGVsX2Nvbm5lY3Rvcl9jaGVja19zdGF0ZShzdHJ1Y3QgaW50ZWxfY29ubmVjdG9yICpj b25uZWN0b3IpCj4gIHsKPiAtCWlmIChjb25uZWN0b3ItPmdldF9od19zdGF0ZShjb25uZWN0b3Ip KSB7Cj4gLQkJc3RydWN0IGludGVsX2VuY29kZXIgKmVuY29kZXIgPSBjb25uZWN0b3ItPmVuY29k ZXI7Cj4gLQkJc3RydWN0IGRybV9jcnRjICpjcnRjOwo+IC0JCWJvb2wgZW5jb2Rlcl9lbmFibGVk Owo+IC0JCWVudW0gcGlwZSBwaXBlOwo+ICsJc3RydWN0IGRybV9jcnRjICpjcnRjID0gY29ubmVj dG9yLT5iYXNlLnN0YXRlLT5jcnRjOwo+ICAKPiAtCQlEUk1fREVCVUdfS01TKCJbQ09OTkVDVE9S OiVkOiVzXVxuIiwKPiAtCQkJICAgICAgY29ubmVjdG9yLT5iYXNlLmJhc2UuaWQsCj4gLQkJCSAg ICAgIGNvbm5lY3Rvci0+YmFzZS5uYW1lKTsKPiArCURSTV9ERUJVR19LTVMoIltDT05ORUNUT1I6 JWQ6JXNdXG4iLAo+ICsJCSAgICAgIGNvbm5lY3Rvci0+YmFzZS5iYXNlLmlkLAo+ICsJCSAgICAg IGNvbm5lY3Rvci0+YmFzZS5uYW1lKTsKPiAgCj4gLQkJSTkxNV9TVEFURV9XQVJOKGNvbm5lY3Rv ci0+YmFzZS5kcG1zID09IERSTV9NT0RFX0RQTVNfT0ZGLAo+IC0JCSAgICAgIndyb25nIGNvbm5l Y3RvciBkcG1zIHN0YXRlXG4iKTsKPiAtCQlJOTE1X1NUQVRFX1dBUk4oY29ubmVjdG9yLT5iYXNl LmVuY29kZXIgIT0gJmVuY29kZXItPmJhc2UsCj4gLQkJICAgICAiYWN0aXZlIGNvbm5lY3RvciBu b3QgbGlua2VkIHRvIGVuY29kZXJcbiIpOwo+ICsJaWYgKGNvbm5lY3Rvci0+Z2V0X2h3X3N0YXRl KGNvbm5lY3RvcikpIHsKPiArCQlzdHJ1Y3QgZHJtX2VuY29kZXIgKmVuY29kZXIgPSAmY29ubmVj dG9yLT5lbmNvZGVyLT5iYXNlOwo+ICsJCXN0cnVjdCBkcm1fY29ubmVjdG9yX3N0YXRlICpjb25u X3N0YXRlID0gY29ubmVjdG9yLT5iYXNlLnN0YXRlOwo+ICAKPiAtCQlpZiAoZW5jb2Rlcikgewo+ IC0JCQlJOTE1X1NUQVRFX1dBUk4oIWVuY29kZXItPmNvbm5lY3RvcnNfYWN0aXZlLAo+IC0JCQkg ICAgICJlbmNvZGVyLT5jb25uZWN0b3JzX2FjdGl2ZSBub3Qgc2V0XG4iKTsKPiArCQlJOTE1X1NU QVRFX1dBUk4oIWNydGMsCj4gKwkJCSAiY29ubmVjdG9yIGVuYWJsZWQgd2l0aG91dCBhdHRhY2hl ZCBjcnRjXG4iKTsKPiAgCj4gLQkJCWVuY29kZXJfZW5hYmxlZCA9IGVuY29kZXItPmdldF9od19z dGF0ZShlbmNvZGVyLCAmcGlwZSk7Cj4gLQkJCUk5MTVfU1RBVEVfV0FSTighZW5jb2Rlcl9lbmFi bGVkLCAiZW5jb2RlciBub3QgZW5hYmxlZFxuIik7Cj4gLQkJCWlmIChJOTE1X1NUQVRFX1dBUk5f T04oIWVuY29kZXItPmJhc2UuY3J0YykpCj4gLQkJCQlyZXR1cm47Cj4gKwkJaWYgKCFjcnRjKQo+ ICsJCQlyZXR1cm47Cj4gIAo+IC0JCQljcnRjID0gZW5jb2Rlci0+YmFzZS5jcnRjOwo+ICsJCUk5 MTVfU1RBVEVfV0FSTighY3J0Yy0+c3RhdGUtPmFjdGl2ZSwKPiArCQkgICAgICAiY29ubmVjdG9y IGlzIGFjdGl2ZSwgYnV0IGF0dGFjaGVkIGNydGMgaXNuJ3RcbiIpOwo+ICAKPiAtCQkJSTkxNV9T VEFURV9XQVJOKCFjcnRjLT5zdGF0ZS0+ZW5hYmxlLAo+IC0JCQkJCSJjcnRjIG5vdCBlbmFibGVk XG4iKTsKPiAtCQkJSTkxNV9TVEFURV9XQVJOKCF0b19pbnRlbF9jcnRjKGNydGMpLT5hY3RpdmUs ICJjcnRjIG5vdCBhY3RpdmVcbiIpOwo+IC0JCQlJOTE1X1NUQVRFX1dBUk4ocGlwZSAhPSB0b19p bnRlbF9jcnRjKGNydGMpLT5waXBlLAo+IC0JCQkgICAgICJlbmNvZGVyIGFjdGl2ZSBvbiB0aGUg d3JvbmcgcGlwZVxuIik7Cj4gLQkJfQo+ICsJCUk5MTVfU1RBVEVfV0FSTihjb25uX3N0YXRlLT5i ZXN0X2VuY29kZXIgIT0gZW5jb2RlciwKPiArCQkJImF0b21pYyBlbmNvZGVyIGRvZXNuJ3QgbWF0 Y2ggYXR0YWNoZWQgZW5jb2RlclxuIik7Cj4gKwo+ICsJCUk5MTVfU1RBVEVfV0FSTihjb25uX3N0 YXRlLT5jcnRjICE9IGVuY29kZXItPmNydGMsCj4gKwkJCSJhdHRhY2hlZCBlbmNvZGVyIGNydGMg ZGlmZmVycyBmcm9tIGNvbm5lY3RvciBjcnRjXG4iKTsKPiArCX0gZWxzZSB7Cj4gKwkJSTkxNV9T VEFURV9XQVJOKCFjcnRjICYmIGNvbm5lY3Rvci0+YmFzZS5zdGF0ZS0+YmVzdF9lbmNvZGVyLAo+ ICsJCQkiYmVzdCBlbmNvZGVyIHNldCB3aXRob3V0IGNydGMhXG4iKTsKPiAgCX0KPiAgfQo+ICAK PiBAQCAtMTI2OTksMjAgKzEyNjk0LDIzIEBAIHN0YXRpYyB2b2lkIGNoZWNrX3dtX3N0YXRlKHN0 cnVjdCBkcm1fZGV2aWNlICpkZXYpCj4gIH0KPiAgCj4gIHN0YXRpYyB2b2lkCj4gLWNoZWNrX2Nv bm5lY3Rvcl9zdGF0ZShzdHJ1Y3QgZHJtX2RldmljZSAqZGV2KQo+ICtjaGVja19jb25uZWN0b3Jf c3RhdGUoc3RydWN0IGRybV9kZXZpY2UgKmRldiwKPiArCQkgICAgICBzdHJ1Y3QgZHJtX2F0b21p Y19zdGF0ZSAqb2xkX3N0YXRlKQo+ICB7Cj4gLQlzdHJ1Y3QgaW50ZWxfY29ubmVjdG9yICpjb25u ZWN0b3I7Cj4gKwlzdHJ1Y3QgZHJtX2Nvbm5lY3Rvcl9zdGF0ZSAqb2xkX2Nvbm5fc3RhdGU7Cj4g KwlzdHJ1Y3QgZHJtX2Nvbm5lY3RvciAqY29ubmVjdG9yOwo+ICsJaW50IGk7Cj4gIAo+IC0JZm9y X2VhY2hfaW50ZWxfY29ubmVjdG9yKGRldiwgY29ubmVjdG9yKSB7Cj4gLQkJc3RydWN0IGRybV9l bmNvZGVyICplbmNvZGVyID0gY29ubmVjdG9yLT5iYXNlLmVuY29kZXI7Cj4gLQkJc3RydWN0IGRy bV9jb25uZWN0b3Jfc3RhdGUgKnN0YXRlID0gY29ubmVjdG9yLT5iYXNlLnN0YXRlOwo+ICsJZm9y X2VhY2hfY29ubmVjdG9yX2luX3N0YXRlKG9sZF9zdGF0ZSwgY29ubmVjdG9yLCBvbGRfY29ubl9z dGF0ZSwgaSkgewo+ICsJCXN0cnVjdCBkcm1fZW5jb2RlciAqZW5jb2RlciA9IGNvbm5lY3Rvci0+ ZW5jb2RlcjsKPiArCQlzdHJ1Y3QgZHJtX2Nvbm5lY3Rvcl9zdGF0ZSAqc3RhdGUgPSBjb25uZWN0 b3ItPnN0YXRlOwo+ICAKPiAgCQkvKiBUaGlzIGFsc28gY2hlY2tzIHRoZSBlbmNvZGVyL2Nvbm5l Y3RvciBodyBzdGF0ZSB3aXRoIHRoZQo+ICAJCSAqIC0+Z2V0X2h3X3N0YXRlIGNhbGxiYWNrcy4g Ki8KPiAtCQlpbnRlbF9jb25uZWN0b3JfY2hlY2tfc3RhdGUoY29ubmVjdG9yKTsKPiArCQlpbnRl bF9jb25uZWN0b3JfY2hlY2tfc3RhdGUodG9faW50ZWxfY29ubmVjdG9yKGNvbm5lY3RvcikpOwo+ ICAKPiAgCQlJOTE1X1NUQVRFX1dBUk4oc3RhdGUtPmJlc3RfZW5jb2RlciAhPSBlbmNvZGVyLAo+ IC0JCSAgICAgImNvbm5lY3RvcidzIHN0YWdlZCBlbmNvZGVyIGRvZXNuJ3QgbWF0Y2ggY3VycmVu dCBlbmNvZGVyXG4iKTsKPiArCQkgICAgICJjb25uZWN0b3IncyBhdG9taWMgZW5jb2RlciBkb2Vz bid0IG1hdGNoIGxlZ2FjeSBlbmNvZGVyXG4iKTsKPiAgCX0KPiAgfQo+ICAKPiBAQCAtMTI5MDMs NyArMTI5MDEsNyBAQCBpbnRlbF9tb2Rlc2V0X2NoZWNrX3N0YXRlKHN0cnVjdCBkcm1fZGV2aWNl ICpkZXYsCj4gIAkJCSAgc3RydWN0IGRybV9hdG9taWNfc3RhdGUgKm9sZF9zdGF0ZSkKPiAgewo+ ICAJY2hlY2tfd21fc3RhdGUoZGV2KTsKPiAtCWNoZWNrX2Nvbm5lY3Rvcl9zdGF0ZShkZXYpOwo+ ICsJY2hlY2tfY29ubmVjdG9yX3N0YXRlKGRldiwgb2xkX3N0YXRlKTsKPiAgCWNoZWNrX2VuY29k ZXJfc3RhdGUoZGV2KTsKPiAgCWNoZWNrX2NydGNfc3RhdGUoZGV2KTsKPiAgCWNoZWNrX3NoYXJl ZF9kcGxsX3N0YXRlKGRldik7Cl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNr dG9wLm9yZwpodHRwOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50 ZWwtZ2Z4Cg==