From: "Vivi, Rodrigo" <rodrigo.vivi@intel.com>
To: "Manna, Animesh" <animesh.manna@intel.com>
Cc: "intel-gfx@lists.freedesktop.org" <intel-gfx@lists.freedesktop.org>
Subject: Re: [BXT DMC PATCHES 1/3] drm/i915/bxt: Path added of dmc firmware ver1 for BXT.
Date: Tue, 4 Aug 2015 17:44:08 +0000 [thread overview]
Message-ID: <1438710299.2444.236.camel@intel.com> (raw)
In-Reply-To: <1438705963-7514-2-git-send-email-animesh.manna@intel.com>
Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
On Tue, 2015-08-04 at 22:02 +0530, Animesh Manna wrote:
> Broxton also has dmc to manage low-power display engine state.
> Path of the firmware added in intel_csr.c.
>
> Naming convention followed as <platform>_dmc_<api-version>.bin
>
> v1: Initial version.
>
> v2: Commit description added based on review comment from Sunil.
>
> Cc: Damien Lespiau <damien.lespiau@intel.com>
> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> Cc: Sunil Kamath <sunil.kamath@intel.com>
> Signed-off-by: Animesh Manna <animesh.manna@intel.com>
> ---
> drivers/gpu/drm/i915/intel_csr.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/intel_csr.c b/drivers/gpu/drm/i915/intel_csr.c
> index 18a0670..c89b9ce 100644
> --- a/drivers/gpu/drm/i915/intel_csr.c
> +++ b/drivers/gpu/drm/i915/intel_csr.c
> @@ -42,8 +42,10 @@
> */
>
> #define I915_CSR_SKL "i915/skl_dmc_ver1.bin"
> +#define I915_CSR_BXT "i915/bxt_dmc_ver1.bin"
>
> MODULE_FIRMWARE(I915_CSR_SKL);
> +MODULE_FIRMWARE(I915_CSR_BXT);
>
> struct intel_css_header {
> /* 0x09 for DMC */
> @@ -372,6 +374,8 @@ void intel_csr_ucode_init(struct drm_i915_private *dev_priv)
>
> if (IS_SKYLAKE(dev_priv))
> csr->fw_path = I915_CSR_SKL;
> + else if (IS_BROXTON(dev_priv))
> + csr->fw_path = I915_CSR_BXT;
> else {
> DRM_ERROR("Unexpected: no known CSR firmware for platform\n");
> return;
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2015-08-04 17:44 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-04 16:32 [BXT DMC PATCHES 0/3] Extended dmc support for broxton Animesh Manna
2015-08-04 16:32 ` [BXT DMC PATCHES 1/3] drm/i915/bxt: Path added of dmc firmware ver1 for BXT Animesh Manna
2015-08-04 17:44 ` Vivi, Rodrigo [this message]
2015-08-04 16:32 ` [BXT DMC PATCHES 2/3] drm/i915/bxt: Modified HAS_CSR, added support " Animesh Manna
2015-09-23 7:42 ` Daniel Vetter
2015-08-04 16:32 ` [BXT DMC PATCHES 3/3] drm/i915/bxt: Stepping info added for bxt Animesh Manna
2015-09-22 15:32 ` [BXT DMC PATCHES 0/3] Extended dmc support for broxton Imre Deak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1438710299.2444.236.camel@intel.com \
--to=rodrigo.vivi@intel.com \
--cc=animesh.manna@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox