From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Vivi, Rodrigo" Subject: Re: [PATCH] drm/i915: Split sink_crc function in start, stop and read. Date: Wed, 5 Aug 2015 20:30:01 +0000 Message-ID: <1438806656.9831.24.camel@intel.com> References: <20150729082452.GR16722@phenom.ffwll.local> <1438298799-4024-1-git-send-email-rodrigo.vivi@intel.com> <20150805080713.GB17734@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by gabe.freedesktop.org (Postfix) with ESMTP id E9A6988697 for ; Wed, 5 Aug 2015 13:30:03 -0700 (PDT) In-Reply-To: <20150805080713.GB17734@phenom.ffwll.local> Content-Language: en-US Content-ID: <76B22D14D7DE104FAFA209A6392B808A@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: "daniel@ffwll.ch" Cc: "daniel.vetter@ffwll.ch" , "intel-gfx@lists.freedesktop.org" List-Id: intel-gfx@lists.freedesktop.org T24gV2VkLCAyMDE1LTA4LTA1IGF0IDEwOjA3ICswMjAwLCBEYW5pZWwgVmV0dGVyIHdyb3RlOg0K PiBPbiBUaHUsIEp1bCAzMCwgMjAxNSBhdCAwNDoyNjozOVBNIC0wNzAwLCBSb2RyaWdvIFZpdmkg d3JvdGU6DQo+ID4gVGhpcyBpcyBqdXN0IGEgcHJlcGFyYXRpb24gcGF0Y2ggdG8gbWFrZSBjbGVh ciB3aGF0IG9wZXJhdGlvbiB3ZQ0KPiA+IGFyZSBwZXJmb3JtaW5nLiBUaGVyZSBpcyBubyBmdW5j dGlvbmFsIGNoYW5nZSBvbiB0aGUgc2luayBjcmMNCj4gPiBsb2dpYy4NCj4gPiANCj4gPiBoc3df ZGlzYWJsZV9pcHMgaGFzIGJlZW4gbW92ZWQgYSBiaXQgZnVydGhlciBpbiB0aGUgc3RhcnQgZnVu Y3Rpb24NCj4gPiB0byBhdm9pZCBkaXNhYmxpbmcgaXBzIHdoZW4gc2luayBjcmMgaXMgbm90IGdv aW5nIHRvIGJlIHN0YXJ0ZWQuDQo+ID4gYW5kIHRvIGF2b2lkIGdvdG8gb24gdGhpcyBmdW5jdGlv bi4NCj4gPiANCj4gPiB2MjogZXhwbGFpbiB3aHkgaHN3X2Rpc2FibGVfaXBzKCkgY2FsbCBwbGFj ZSBoYXMgY2hhbmdlZC4NCj4gPiANCj4gPiBDYzogRGFuaWVsIFZldHRlciA8ZGFuaWVsLnZldHRl ckBmZndsbC5jaD4NCj4gPiBSZXZpZXdlZC1ieTogUmFmYWVsIEFudG9nbm9sbGkgPHJhZmFlbC5h bnRvZ25vbGxpQGludGVsLmNvbT4NCj4gPiBTaWduZWQtb2ZmLWJ5OiBSb2RyaWdvIFZpdmkgPHJv ZHJpZ28udml2aUBpbnRlbC5jb20+DQo+IA0KPiBUaGFua3MgZm9yIHRoZSB1cGRhdGVkIGNvbW1p dCBtZXNzYWdlLiBRdWV1ZWQgZm9yIC1uZXh0LCB0aGFua3MgZm9yIHRoZQ0KPiBwYXRjaC4NCg0K VGhhbmtzIQ0KDQpEbyB5b3UgaW50ZW5kIHRvIG1lcmdlIHRoZSBvdGhlciAzIHJlbWFpbmluZyBw YXRjaGVzPw0KT3IgYW0gSSBtaXNzaW5nIHNvbWV0aGluZyB0aGVyZT8NCg0KVGhhbmtzLA0KUm9k cmlnby4NCg0KPiAtRGFuaWVsDQo+ID4gLS0tDQo+ID4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2lu dGVsX2RwLmMgfCA4OSArKysrKysrKysrKysrKysrKysrKysrKy0tLS0tLS0tLS0tLS0tLS0tLQ0K PiA+ICAxIGZpbGUgY2hhbmdlZCwgNTAgaW5zZXJ0aW9ucygrKSwgMzkgZGVsZXRpb25zKC0pDQo+ ID4gDQo+ID4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RwLmMgYi9k cml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcC5jDQo+ID4gaW5kZXggNDRmOGEzMi4uMTBjYmM5 OCAxMDA2NDQNCj4gPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcC5jDQo+ID4g KysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHAuYw0KPiA+IEBAIC0zOTU4LDQwICsz OTU4LDY0IEBAIGludGVsX2RwX3Byb2JlX21zdChzdHJ1Y3QgaW50ZWxfZHAgKmludGVsX2RwKQ0K PiA+ICAJcmV0dXJuIGludGVsX2RwLT5pc19tc3Q7DQo+ID4gIH0NCj4gPiAgDQo+ID4gLWludCBp bnRlbF9kcF9zaW5rX2NyYyhzdHJ1Y3QgaW50ZWxfZHAgKmludGVsX2RwLCB1OCAqY3JjKQ0KPiA+ ICtzdGF0aWMgdm9pZCBpbnRlbF9kcF9zaW5rX2NyY19zdG9wKHN0cnVjdCBpbnRlbF9kcCAqaW50 ZWxfZHApDQo+ID4gIHsNCj4gPiAtCXN0cnVjdCBpbnRlbF9kaWdpdGFsX3BvcnQgKmludGVsX2Rp Z19wb3J0ID0gZHBfdG9fZGlnX3BvcnQoaW50ZWxfZHApOw0KPiA+IC0Jc3RydWN0IGRybV9kZXZp Y2UgKmRldiA9IGludGVsX2RpZ19wb3J0LT5iYXNlLmJhc2UuZGV2Ow0KPiA+IC0Jc3RydWN0IGlu dGVsX2NydGMgKmludGVsX2NydGMgPQ0KPiA+IC0JCXRvX2ludGVsX2NydGMoaW50ZWxfZGlnX3Bv cnQtPmJhc2UuYmFzZS5jcnRjKTsNCj4gPiArCXN0cnVjdCBpbnRlbF9kaWdpdGFsX3BvcnQgKmRp Z19wb3J0ID0gZHBfdG9fZGlnX3BvcnQoaW50ZWxfZHApOw0KPiA+ICsJc3RydWN0IGludGVsX2Ny dGMgKmludGVsX2NydGMgPSB0b19pbnRlbF9jcnRjKGRpZ19wb3J0LT5iYXNlLmJhc2UuY3J0Yyk7 DQo+ID4gIAl1OCBidWY7DQo+ID4gLQlpbnQgdGVzdF9jcmNfY291bnQ7DQo+ID4gLQlpbnQgYXR0 ZW1wdHMgPSA2Ow0KPiA+IC0JaW50IHJldCA9IDA7DQo+ID4gLQ0KPiA+IC0JaHN3X2Rpc2FibGVf aXBzKGludGVsX2NydGMpOw0KPiA+ICANCj4gPiAtCWlmIChkcm1fZHBfZHBjZF9yZWFkYigmaW50 ZWxfZHAtPmF1eCwgRFBfVEVTVF9TSU5LX01JU0MsICZidWYpIDwgMCkgew0KPiA+IC0JCXJldCA9 IC1FSU87DQo+ID4gLQkJZ290byBvdXQ7DQo+ID4gKwlpZiAoZHJtX2RwX2RwY2RfcmVhZGIoJmlu dGVsX2RwLT5hdXgsIERQX1RFU1RfU0lOSywgJmJ1ZikgPCAwKSB7DQo+ID4gKwkJRFJNX0RFQlVH X0tNUygiU2luayBDUkMgY291bGRuJ3QgYmUgc3RvcHBlZCBwcm9wZXJseVxuIik7DQo+ID4gKwkJ cmV0dXJuOw0KPiA+ICAJfQ0KPiA+ICANCj4gPiAtCWlmICghKGJ1ZiAmIERQX1RFU1RfQ1JDX1NV UFBPUlRFRCkpIHsNCj4gPiAtCQlyZXQgPSAtRU5PVFRZOw0KPiA+IC0JCWdvdG8gb3V0Ow0KPiA+ IC0JfQ0KPiA+ICsJaWYgKGRybV9kcF9kcGNkX3dyaXRlYigmaW50ZWxfZHAtPmF1eCwgRFBfVEVT VF9TSU5LLA0KPiA+ICsJCQkgICAgICAgYnVmICYgfkRQX1RFU1RfU0lOS19TVEFSVCkgPCAwKQ0K PiA+ICsJCURSTV9ERUJVR19LTVMoIlNpbmsgQ1JDIGNvdWxkbid0IGJlIHN0b3BwZWQgcHJvcGVy bHlcbiIpOw0KPiA+ICANCj4gPiAtCWlmIChkcm1fZHBfZHBjZF9yZWFkYigmaW50ZWxfZHAtPmF1 eCwgRFBfVEVTVF9TSU5LLCAmYnVmKSA8IDApIHsNCj4gPiAtCQlyZXQgPSAtRUlPOw0KPiA+IC0J CWdvdG8gb3V0Ow0KPiA+IC0JfQ0KPiA+ICsJaHN3X2VuYWJsZV9pcHMoaW50ZWxfY3J0Yyk7DQo+ ID4gK30NCj4gPiArDQo+ID4gK3N0YXRpYyBpbnQgaW50ZWxfZHBfc2lua19jcmNfc3RhcnQoc3Ry dWN0IGludGVsX2RwICppbnRlbF9kcCkNCj4gPiArew0KPiA+ICsJc3RydWN0IGludGVsX2RpZ2l0 YWxfcG9ydCAqZGlnX3BvcnQgPSBkcF90b19kaWdfcG9ydChpbnRlbF9kcCk7DQo+ID4gKwlzdHJ1 Y3QgaW50ZWxfY3J0YyAqaW50ZWxfY3J0YyA9IHRvX2ludGVsX2NydGMoZGlnX3BvcnQtPmJhc2Uu YmFzZS5jcnRjKTsNCj4gPiArCXU4IGJ1ZjsNCj4gPiArDQo+ID4gKwlpZiAoZHJtX2RwX2RwY2Rf cmVhZGIoJmludGVsX2RwLT5hdXgsIERQX1RFU1RfU0lOS19NSVNDLCAmYnVmKSA8IDApDQo+ID4g KwkJcmV0dXJuIC1FSU87DQo+ID4gKw0KPiA+ICsJaWYgKCEoYnVmICYgRFBfVEVTVF9DUkNfU1VQ UE9SVEVEKSkNCj4gPiArCQlyZXR1cm4gLUVOT1RUWTsNCj4gPiArDQo+ID4gKwlpZiAoZHJtX2Rw X2RwY2RfcmVhZGIoJmludGVsX2RwLT5hdXgsIERQX1RFU1RfU0lOSywgJmJ1ZikgPCAwKQ0KPiA+ ICsJCXJldHVybiAtRUlPOw0KPiA+ICsNCj4gPiArCWhzd19kaXNhYmxlX2lwcyhpbnRlbF9jcnRj KTsNCj4gPiAgDQo+ID4gIAlpZiAoZHJtX2RwX2RwY2Rfd3JpdGViKCZpbnRlbF9kcC0+YXV4LCBE UF9URVNUX1NJTkssDQo+ID4gLQkJCQlidWYgfCBEUF9URVNUX1NJTktfU1RBUlQpIDwgMCkgew0K PiA+IC0JCXJldCA9IC1FSU87DQo+ID4gLQkJZ290byBvdXQ7DQo+ID4gKwkJCSAgICAgICBidWYg fCBEUF9URVNUX1NJTktfU1RBUlQpIDwgMCkgew0KPiA+ICsJCWhzd19lbmFibGVfaXBzKGludGVs X2NydGMpOw0KPiA+ICsJCXJldHVybiAtRUlPOw0KPiA+ICAJfQ0KPiA+ICANCj4gPiArCXJldHVy biAwOw0KPiA+ICt9DQo+ID4gKw0KPiA+ICtpbnQgaW50ZWxfZHBfc2lua19jcmMoc3RydWN0IGlu dGVsX2RwICppbnRlbF9kcCwgdTggKmNyYykNCj4gPiArew0KPiA+ICsJc3RydWN0IGludGVsX2Rp Z2l0YWxfcG9ydCAqZGlnX3BvcnQgPSBkcF90b19kaWdfcG9ydChpbnRlbF9kcCk7DQo+ID4gKwlz dHJ1Y3QgZHJtX2RldmljZSAqZGV2ID0gZGlnX3BvcnQtPmJhc2UuYmFzZS5kZXY7DQo+ID4gKwlz dHJ1Y3QgaW50ZWxfY3J0YyAqaW50ZWxfY3J0YyA9IHRvX2ludGVsX2NydGMoZGlnX3BvcnQtPmJh c2UuYmFzZS5jcnRjKTsNCj4gPiArCXU4IGJ1ZjsNCj4gPiArCWludCB0ZXN0X2NyY19jb3VudDsN Cj4gPiArCWludCBhdHRlbXB0cyA9IDY7DQo+ID4gKwlpbnQgcmV0Ow0KPiA+ICsNCj4gPiArCXJl dCA9IGludGVsX2RwX3NpbmtfY3JjX3N0YXJ0KGludGVsX2RwKTsNCj4gPiArCWlmIChyZXQpDQo+ ID4gKwkJcmV0dXJuIHJldDsNCj4gPiArDQo+ID4gIAlpZiAoZHJtX2RwX2RwY2RfcmVhZGIoJmlu dGVsX2RwLT5hdXgsIERQX1RFU1RfU0lOS19NSVNDLCAmYnVmKSA8IDApIHsNCj4gPiAgCQlyZXQg PSAtRUlPOw0KPiA+ICAJCWdvdG8gc3RvcDsNCj4gPiBAQCAtNDAxNCwyMyArNDAzOCwxMCBAQCBp bnQgaW50ZWxfZHBfc2lua19jcmMoc3RydWN0IGludGVsX2RwICppbnRlbF9kcCwgdTggKmNyYykN Cj4gPiAgCQlnb3RvIHN0b3A7DQo+ID4gIAl9DQo+ID4gIA0KPiA+IC0JaWYgKGRybV9kcF9kcGNk X3JlYWQoJmludGVsX2RwLT5hdXgsIERQX1RFU1RfQ1JDX1JfQ1IsIGNyYywgNikgPCAwKSB7DQo+ ID4gKwlpZiAoZHJtX2RwX2RwY2RfcmVhZCgmaW50ZWxfZHAtPmF1eCwgRFBfVEVTVF9DUkNfUl9D UiwgY3JjLCA2KSA8IDApDQo+ID4gIAkJcmV0ID0gLUVJTzsNCj4gPiAtCQlnb3RvIHN0b3A7DQo+ ID4gLQl9DQo+ID4gLQ0KPiA+ICBzdG9wOg0KPiA+IC0JaWYgKGRybV9kcF9kcGNkX3JlYWRiKCZp bnRlbF9kcC0+YXV4LCBEUF9URVNUX1NJTkssICZidWYpIDwgMCkgew0KPiA+IC0JCURSTV9ERUJV R19LTVMoIlNpbmsgQ1JDIGNvdWxkbid0IGJlIHN0b3BwZWQgcHJvcGVybHlcbiIpOw0KPiA+IC0J CWdvdG8gb3V0Ow0KPiA+IC0JfQ0KPiA+IC0JaWYgKGRybV9kcF9kcGNkX3dyaXRlYigmaW50ZWxf ZHAtPmF1eCwgRFBfVEVTVF9TSU5LLA0KPiA+IC0JCQkgICAgICAgYnVmICYgfkRQX1RFU1RfU0lO S19TVEFSVCkgPCAwKSB7DQo+ID4gLQkJRFJNX0RFQlVHX0tNUygiU2luayBDUkMgY291bGRuJ3Qg YmUgc3RvcHBlZCBwcm9wZXJseVxuIik7DQo+ID4gLQkJZ290byBvdXQ7DQo+ID4gLQl9DQo+ID4g LW91dDoNCj4gPiAtCWhzd19lbmFibGVfaXBzKGludGVsX2NydGMpOw0KPiA+ICsJaW50ZWxfZHBf c2lua19jcmNfc3RvcChpbnRlbF9kcCk7DQo+ID4gIAlyZXR1cm4gcmV0Ow0KPiA+ICB9DQo+ID4g IA0KPiA+IC0tIA0KPiA+IDIuMS4wDQo+ID4gDQo+IA0KDQpfX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdm eEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cDovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWls bWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=