Re: [PATCH 6/6 v3] drm/i915: Enable HDMI on DDI-E

Zhang, Xiong Y
2015-08-14T10:38:41Z

> On Thu, Aug 13, 2015 at 02:57:38AM +0000, Zhang, Xiong Y wrote:
> > > On Wed, Aug 12, 2015 at 06:39:34PM +0800, Xiong Zhang wrote:
> > > > DDI-E doesn't have the correspondent GMBUS pin.
> > > >
> > > > We rely on VBT to tell us which one it being used instead.
> > > >
> > > > The DVI/HDMI on shared port couldn't exist.
> > > >
> > > > This patch isn't tested without hardware wchich has HDMI on DDI-E.
> > > >
> > > > v2: fix trailing whitespace
> > > > v3: WARN() take place of BUG()
> > >
> > > I asked for MISSING_CASE, not WARN.
> > > -Daniel
> > [Zhang, Xiong Y] Because DDI-E on SKL doesn't have correspondent GMBUS
> pin, it should share such pin with DDI-B/C/D. We don't know the default
> GMBUS pin for DDI-E if VBT doesn't tell us.
> > If VBT don't tell us or give us an invalid GMBUS pin, driver will fail in getting
> HDMI info. In such case, we really need a warn which tell us why driver
> couldn't read EDID info for HDMI on DDI-E.
>
> Have you bothered to look at the MISSING_CASE macro?! It does boil down to
> a WARN, but I prefer it much over a WARN_ON since it's nicely standardized.
>
[Zhang, Xiong Y] Please forgive my innocence! I misunderstand MISSING_CASE at the beginning.