From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
To: Intel-gfx@lists.freedesktop.org
Subject: [PATCH i-g-t] gem_ppgtt: Test VMA leak on context destruction
Date: Fri, 11 Sep 2015 15:31:11 +0100 [thread overview]
Message-ID: <1441981871-28054-1-git-send-email-tvrtko.ursulin@linux.intel.com> (raw)
From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Test that VMAs associated with a context are cleaned up when
contexts are destroyed.
In practice this emulates the leak seen between fbcon and X server.
Every time the X server exits we gain one VMA on the fbcon frame
buffer object as externally visible via for example
/sys/kernel/debug/dri/0/i915_gem_gtt.
Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
---
tests/gem_ppgtt.c | 80 +++++++++++++++++++++++++++++++++++++++++++++++++++++++
1 file changed, 80 insertions(+)
diff --git a/tests/gem_ppgtt.c b/tests/gem_ppgtt.c
index 4f6df063214a..363f9d701585 100644
--- a/tests/gem_ppgtt.c
+++ b/tests/gem_ppgtt.c
@@ -265,6 +265,83 @@ static void flink_and_close(void)
close(fd2);
}
+static int grep_name(char *match, int to_match)
+{
+ int fdd, ret, matched;
+
+ fdd = open("/sys/kernel/debug/dri/0/i915_gem_gtt", O_RDONLY);
+ igt_assert(fdd >= 0);
+
+ matched = 0;
+ do {
+ char ch;
+
+ ret = read(fdd, &ch, 1);
+ if (ret == 0)
+ break;
+ igt_assert(ret == 1);
+
+ if (ch == match[matched])
+ matched++;
+ else
+ matched = 0;
+ } while (matched < to_match);
+
+ close(fdd);
+
+ return matched;
+}
+
+static void flink_and_exit(void)
+{
+ uint32_t fd, fd2;
+ uint32_t bo, flinked_bo, name;
+ char match[100];
+ int matched, to_match;
+ int retry = 0;
+ const int retries = 50;
+
+ fd = drm_open_any();
+ igt_require(uses_full_ppgtt(fd));
+
+ bo = gem_create(fd, 4096);
+ name = gem_flink(fd, bo);
+
+ to_match = snprintf(match, sizeof(match), "(name: %u)", name);
+ igt_assert(to_match < sizeof(match));
+
+ fd2 = drm_open_any();
+
+ flinked_bo = gem_open(fd2, name);
+ exec_and_get_offset(fd2, flinked_bo);
+ gem_sync(fd2, flinked_bo);
+
+ /* Verify looking for string works OK. */
+ matched = grep_name(match, to_match);
+ igt_assert_eq(matched, to_match);
+
+ gem_close(fd2, flinked_bo);
+
+ /* Close the context. */
+ close(fd2);
+
+retry:
+ /* Give cleanup some time to run. */
+ usleep(100000);
+
+ /* The flinked bo VMA should have been cleared now, so list of VMAs
+ * in debugfs should not contain the one for the imported object.
+ */
+ matched = grep_name(match, to_match);
+ if (matched >= to_match && retry++ < retries)
+ goto retry;
+
+ igt_assert_lt(matched, to_match);
+
+ gem_close(fd, bo);
+ close(fd);
+}
+
#define N_CHILD 8
int main(int argc, char **argv)
{
@@ -297,5 +374,8 @@ int main(int argc, char **argv)
igt_subtest("flink-and-close-vma-leak")
flink_and_close();
+ igt_subtest("flink-and-exit-vma-leak")
+ flink_and_exit();
+
igt_exit();
}
--
2.5.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next reply other threads:[~2015-09-11 14:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-11 14:31 Tvrtko Ursulin [this message]
2015-09-18 11:17 ` [PATCH i-g-t] gem_ppgtt: Test VMA leak on context destruction Thomas Wood
2015-09-23 12:36 ` Tvrtko Ursulin
2015-09-23 16:16 ` Thomas Wood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1441981871-28054-1-git-send-email-tvrtko.ursulin@linux.intel.com \
--to=tvrtko.ursulin@linux.intel.com \
--cc=Intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox