intel-gfx.lists.freedesktop.org archive mirror
 help / color / mirror / Atom feed
From: yu.dai@intel.com
To: intel-gfx@lists.freedesktop.org
Subject: [PATCH 05/15] drm/i915/guc: Media domain bit needed when notify GuC rc6 state
Date: Tue, 15 Sep 2015 16:31:07 -0700	[thread overview]
Message-ID: <1442359867-31500-1-git-send-email-yu.dai@intel.com> (raw)
In-Reply-To: <1441929372-26140-6-git-send-email-yu.dai@intel.com>

From: Alex Dai <yu.dai@intel.com>

GuC expects two bits for Render and Media domain separately when
driver sends data via host2guc SAMPLE_FORCEWAKE. Bit 0 is for
Render and bit 1 is for Media domain.

v1: Add parameters definition to avoid magic value

Signed-off-by: Alex Dai <yu.dai@intel.com>
---
 drivers/gpu/drm/i915/i915_guc_submission.c | 6 ++++--
 drivers/gpu/drm/i915/intel_guc_fwif.h      | 3 +++
 2 files changed, 7 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/i915/i915_guc_submission.c b/drivers/gpu/drm/i915/i915_guc_submission.c
index 38b6ef4..2bea858 100644
--- a/drivers/gpu/drm/i915/i915_guc_submission.c
+++ b/drivers/gpu/drm/i915/i915_guc_submission.c
@@ -158,9 +158,11 @@ static int host2guc_sample_forcewake(struct intel_guc *guc,
 	u32 data[2];
 
 	data[0] = HOST2GUC_ACTION_SAMPLE_FORCEWAKE;
-	data[1] = (intel_enable_rc6(dev_priv->dev)) ? 1 : 0;
+	/* bit 0 and 1 are for Render and Media domain separately */
+	data[1] = (intel_enable_rc6(dev_priv->dev)) ?
+			GUC_FORCEWAKE_RENDER | GUC_FORCEWAKE_MEDIA : 0;
 
-	return host2guc_action(guc, data, 2);
+	return host2guc_action(guc, data, ARRAY_SIZE(data));
 }
 
 /*
diff --git a/drivers/gpu/drm/i915/intel_guc_fwif.h b/drivers/gpu/drm/i915/intel_guc_fwif.h
index f6d0aa4..ecea053 100644
--- a/drivers/gpu/drm/i915/intel_guc_fwif.h
+++ b/drivers/gpu/drm/i915/intel_guc_fwif.h
@@ -260,6 +260,9 @@ struct guc_context_desc {
 #define GUC_POWER_D2		3
 #define GUC_POWER_D3		4
 
+#define GUC_FORCEWAKE_RENDER	(1 << 0)
+#define GUC_FORCEWAKE_MEDIA	(1 << 1)
+
 /* This Action will be programmed in C180 - SOFT_SCRATCH_O_REG */
 enum host2guc_action {
 	HOST2GUC_ACTION_DEFAULT = 0x0,
-- 
1.9.1

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

  parent reply	other threads:[~2015-09-15 23:32 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-10 23:56 [PATCH 0/6] Several GuC related patches yu.dai
2015-09-10 23:56 ` [PATCH 1/6] drm/i915/guc: Fix a bug in GuC status check yu.dai
2015-09-10 23:56 ` [PATCH 2/6] drm/i915/guc: Add GuC css header parser yu.dai
2015-09-14  9:28   ` Daniel Vetter
2015-09-10 23:56 ` [PATCH 3/6] drm/i915/guc: Add host2guc notification for suspend and resume yu.dai
2015-09-15 23:30   ` [PATCH 03/15] " yu.dai
2015-09-10 23:56 ` [PATCH 4/6] drm/i915/guc: Don't send flips to GuC yu.dai
2015-09-11 12:44   ` [PATCH v2 1/1] drm/i915: Direct all DE interrupts to host Sagar Arun Kamble
2015-09-21 19:02     ` O'Rourke, Tom
2015-09-10 23:56 ` [PATCH 5/6] drm/i915/guc: Media domain bit needed when notify GuC rc6 state yu.dai
2015-09-14  9:32   ` Daniel Vetter
2015-09-15 23:31   ` yu.dai [this message]
2015-09-10 23:56 ` [PATCH 6/6] drm/i915/guc: Enable GuC submission, where supported yu.dai
2015-09-22 20:48 ` [PATCH v2 0/6] Several GuC related patches yu.dai
2015-09-22 20:48   ` [PATCH v2 1/6] drm/i915/guc: Fix a bug in GuC status check yu.dai
2015-09-24  4:59     ` Kamble, Sagar A
2015-09-28  8:10       ` Daniel Vetter
2015-09-22 20:48   ` [PATCH v2 2/6] drm/i915/guc: Add GuC css header parser yu.dai
2015-09-24 14:23     ` Dave Gordon
2015-09-24 18:34       ` Yu Dai
2015-09-24 19:04         ` Dave Gordon
2015-09-24 20:23           ` Yu Dai
2015-09-25 14:45             ` Jani Nikula
2015-09-25 16:31               ` Yu Dai
2015-09-28  8:13                 ` Daniel Vetter
2015-09-22 20:48   ` [PATCH v2 3/6] drm/i915/guc: Add host2guc notification for suspend and resume yu.dai
2015-09-24  8:27     ` Kamble, Sagar A
2015-09-22 20:48   ` [PATCH v2 4/6] drm/i915/guc: Don't send flips to GuC yu.dai
2015-09-22 23:11     ` [PATCH] " yu.dai
2015-09-23  0:56       ` O'Rourke, Tom
2015-09-22 20:48   ` [PATCH v2 5/6] drm/i915/guc: Media domain bit needed when notify GuC rc6 state yu.dai
2015-09-23  0:59     ` O'Rourke, Tom
2015-09-23  8:37       ` Daniel Vetter
2015-09-22 20:48   ` [PATCH v2 6/6] drm/i915/guc: Enable GuC submission, where supported yu.dai
2015-09-22 23:13     ` [PATCH] " yu.dai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1442359867-31500-1-git-send-email-yu.dai@intel.com \
    --to=yu.dai@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).