From: "Winiarski, Michal" <michal.winiarski@intel.com>
To: "intel-gfx@lists.freedesktop.org" <intel-gfx@lists.freedesktop.org>
Cc: "Kuoppala, Mika" <mika.kuoppala@intel.com>
Subject: Re: [PATCH v3 2/2] drm/i915/gtt: Avoid using addresses in non-canonical form.
Date: Thu, 17 Sep 2015 17:17:24 +0000 [thread overview]
Message-ID: <1442510240.25780.11.camel@intel.com> (raw)
In-Reply-To: <1442397050-16268-1-git-send-email-michal.winiarski@intel.com>
On śro, 2015-09-16 at 11:50 +0200, Michał Winiarski wrote:
> According to bspec, some parts of HW expect the addresses to be in
> a canonical form where bits [63:48] == [47].
> If we're using 32b addressing, we never need to handle such high
> addresses, but since we've recently added 48b address space support,
> lets satisfy the HW by converting the address prior to
> alloc/insert/clear.
>
> v2: Commit msg update,
> move WARN to gen8_alloc_va_range,
> also convert to canonical in insert_entries.
> v3: Also convert for !48b (causes no harm, improves code stucture),
> update wrap comment.
>
> Cc: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Michel Thierry <michel.thierry@intel.com>
> Cc: Mika Kuoppala <mika.kuoppala@intel.com>
> Signed-off-by: Michał Winiarski <michal.winiarski@intel.com>
Actually... Please ignore this patch.
It's harmless, unfortunately it's also useless, and I need to address
this in a different way.
Sorry for the noise.
-Michał
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2015-09-17 17:17 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-15 13:30 [PATCH 1/2] drm/i915/gtt: Do not initialize drm_mm twice Michał Winiarski
2015-09-15 13:30 ` [PATCH 2/2] drm/i915/gtt: Avoid using addresses in non-canonical form Michał Winiarski
2015-09-15 13:52 ` Chris Wilson
2015-09-15 14:01 ` Michel Thierry
2015-09-15 18:04 ` [PATCH v2 " Michał Winiarski
2015-09-15 20:03 ` Chris Wilson
2015-09-16 9:50 ` [PATCH v3 " Michał Winiarski
2015-09-16 9:57 ` Chris Wilson
2015-09-17 17:17 ` Winiarski, Michal [this message]
2015-09-23 12:31 ` Daniel Vetter
2015-09-15 13:39 ` [PATCH 1/2] drm/i915/gtt: Do not initialize drm_mm twice Chris Wilson
2015-09-15 14:01 ` Michel Thierry
2015-09-15 18:01 ` [PATCH v2 " Michał Winiarski
2015-09-15 20:07 ` Chris Wilson
2015-09-15 20:07 ` Chris Wilson
2015-09-16 9:49 ` [PATCH v3 " Michał Winiarski
2015-09-17 10:59 ` Chris Wilson
2015-09-23 9:51 ` Daniel Vetter
2015-09-23 16:48 ` Imre Deak
2015-09-23 18:55 ` Paulo Zanoni
2015-09-23 20:47 ` Jesse Barnes
2015-09-24 11:20 ` Winiarski, Michal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1442510240.25780.11.camel@intel.com \
--to=michal.winiarski@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=mika.kuoppala@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox