From: yu.dai@intel.com
To: intel-gfx@lists.freedesktop.org
Subject: [PATCH v2 4/6] drm/i915/guc: Don't send flips to GuC
Date: Tue, 22 Sep 2015 13:48:43 -0700 [thread overview]
Message-ID: <1442954925-4022-5-git-send-email-yu.dai@intel.com> (raw)
In-Reply-To: <1442954925-4022-1-git-send-email-yu.dai@intel.com>
From: Sagar Arun Kamble <sagar.a.kamble@intel.com>
Due to flip interrupts GuC stays awake always and GT does not enter
RC6. Do not route those interrupts to GuC for now. Driver won't touch
DE_GUCRMR register and leave it as what default value.
Signed-off-by: Sagar Arun Kamble <sagar.a.kamble@intel.com>
---
drivers/gpu/drm/i915/intel_guc_loader.c | 10 ----------
1 file changed, 10 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_guc_loader.c b/drivers/gpu/drm/i915/intel_guc_loader.c
index 740bfb3..d513673 100644
--- a/drivers/gpu/drm/i915/intel_guc_loader.c
+++ b/drivers/gpu/drm/i915/intel_guc_loader.c
@@ -90,9 +90,6 @@ static void direct_interrupts_to_host(struct drm_i915_private *dev_priv)
for_each_ring(ring, dev_priv, i)
I915_WRITE(RING_MODE_GEN7(ring), irqs);
- /* tell DE to send nothing to GuC */
- I915_WRITE(DE_GUCRMR, ~0);
-
/* route all GT interrupts to the host */
I915_WRITE(GUC_BCS_RCS_IER, 0);
I915_WRITE(GUC_VCS2_VCS1_IER, 0);
@@ -110,13 +107,6 @@ static void direct_interrupts_to_guc(struct drm_i915_private *dev_priv)
for_each_ring(ring, dev_priv, i)
I915_WRITE(RING_MODE_GEN7(ring), irqs);
- /* tell DE to send (all) flip_done to GuC */
- irqs = DERRMR_PIPEA_PRI_FLIP_DONE | DERRMR_PIPEA_SPR_FLIP_DONE |
- DERRMR_PIPEB_PRI_FLIP_DONE | DERRMR_PIPEB_SPR_FLIP_DONE |
- DERRMR_PIPEC_PRI_FLIP_DONE | DERRMR_PIPEC_SPR_FLIP_DONE;
- /* Unmasked bits will cause GuC response message to be sent */
- I915_WRITE(DE_GUCRMR, ~irqs);
-
/* route USER_INTERRUPT to Host, all others are sent to GuC. */
irqs = GT_RENDER_USER_INTERRUPT << GEN8_RCS_IRQ_SHIFT |
GT_RENDER_USER_INTERRUPT << GEN8_BCS_IRQ_SHIFT;
--
1.9.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2015-09-22 20:50 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-10 23:56 [PATCH 0/6] Several GuC related patches yu.dai
2015-09-10 23:56 ` [PATCH 1/6] drm/i915/guc: Fix a bug in GuC status check yu.dai
2015-09-10 23:56 ` [PATCH 2/6] drm/i915/guc: Add GuC css header parser yu.dai
2015-09-14 9:28 ` Daniel Vetter
2015-09-10 23:56 ` [PATCH 3/6] drm/i915/guc: Add host2guc notification for suspend and resume yu.dai
2015-09-15 23:30 ` [PATCH 03/15] " yu.dai
2015-09-10 23:56 ` [PATCH 4/6] drm/i915/guc: Don't send flips to GuC yu.dai
2015-09-11 12:44 ` [PATCH v2 1/1] drm/i915: Direct all DE interrupts to host Sagar Arun Kamble
2015-09-21 19:02 ` O'Rourke, Tom
2015-09-10 23:56 ` [PATCH 5/6] drm/i915/guc: Media domain bit needed when notify GuC rc6 state yu.dai
2015-09-14 9:32 ` Daniel Vetter
2015-09-15 23:31 ` [PATCH 05/15] " yu.dai
2015-09-10 23:56 ` [PATCH 6/6] drm/i915/guc: Enable GuC submission, where supported yu.dai
2015-09-22 20:48 ` [PATCH v2 0/6] Several GuC related patches yu.dai
2015-09-22 20:48 ` [PATCH v2 1/6] drm/i915/guc: Fix a bug in GuC status check yu.dai
2015-09-24 4:59 ` Kamble, Sagar A
2015-09-28 8:10 ` Daniel Vetter
2015-09-22 20:48 ` [PATCH v2 2/6] drm/i915/guc: Add GuC css header parser yu.dai
2015-09-24 14:23 ` Dave Gordon
2015-09-24 18:34 ` Yu Dai
2015-09-24 19:04 ` Dave Gordon
2015-09-24 20:23 ` Yu Dai
2015-09-25 14:45 ` Jani Nikula
2015-09-25 16:31 ` Yu Dai
2015-09-28 8:13 ` Daniel Vetter
2015-09-22 20:48 ` [PATCH v2 3/6] drm/i915/guc: Add host2guc notification for suspend and resume yu.dai
2015-09-24 8:27 ` Kamble, Sagar A
2015-09-22 20:48 ` yu.dai [this message]
2015-09-22 23:11 ` [PATCH] drm/i915/guc: Don't send flips to GuC yu.dai
2015-09-23 0:56 ` O'Rourke, Tom
2015-09-22 20:48 ` [PATCH v2 5/6] drm/i915/guc: Media domain bit needed when notify GuC rc6 state yu.dai
2015-09-23 0:59 ` O'Rourke, Tom
2015-09-23 8:37 ` Daniel Vetter
2015-09-22 20:48 ` [PATCH v2 6/6] drm/i915/guc: Enable GuC submission, where supported yu.dai
2015-09-22 23:13 ` [PATCH] " yu.dai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1442954925-4022-5-git-send-email-yu.dai@intel.com \
--to=yu.dai@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).