From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Zanoni, Paulo R" Subject: Re: [PATCH 2/3] drm/i915: fix CFB size calculation Date: Thu, 1 Oct 2015 17:47:11 +0000 Message-ID: <1443721629.2442.14.camel@intel.com> References: <1443023547-19896-1-git-send-email-paulo.r.zanoni@intel.com> <1443643545-3603-1-git-send-email-paulo.r.zanoni@intel.com> <1443643545-3603-2-git-send-email-paulo.r.zanoni@intel.com> <20151001121413.GE26517@intel.com> <20151001122308.GG26517@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by gabe.freedesktop.org (Postfix) with ESMTP id 1913D6E425 for ; Thu, 1 Oct 2015 10:48:28 -0700 (PDT) In-Reply-To: <20151001122308.GG26517@intel.com> Content-Language: en-US Content-ID: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: "ville.syrjala@linux.intel.com" Cc: "intel-gfx@lists.freedesktop.org" List-Id: intel-gfx@lists.freedesktop.org RW0gUXVpLCAyMDE1LTEwLTAxIMOgcyAxNToyMyArMDMwMCwgVmlsbGUgU3lyasOkbMOkIGVzY3Jl dmV1Og0KPiBPbiBUaHUsIE9jdCAwMSwgMjAxNSBhdCAwMzoxNDoxM1BNICswMzAwLCBWaWxsZSBT eXJqw6Rsw6Qgd3JvdGU6DQo+ID4gT24gV2VkLCBTZXAgMzAsIDIwMTUgYXQgMDU6MDU6NDRQTSAt MDMwMCwgUGF1bG8gWmFub25pIHdyb3RlOg0KPiA+ID4gV2Ugd2VyZSBjb25zaWRlcmluZyB0aGUg d2hvbGUgZnJhbWVidWZmZXIgaGVpZ2h0LCBidXQgdGhlIHNwZWMNCj4gPiA+IHNheXMgd2UNCj4g PiA+IHNob3VsZCBvbmx5IGNvbnNpZGVyIHRoZSBhY3RpdmUgZGlzcGxheSBoZWlnaHQgc2l6ZS4g VGhlcmUgd2VyZQ0KPiA+ID4gc3RpbGwNCj4gPiA+IHNvbWUgdW5jbGVhciBxdWVzdGlvbnMgYmFz ZWQgb24gdGhlIHNwZWMsIGJ1dCB0aGUgaGFyZHdhcmUgZ3V5cw0KPiA+ID4gY2xhcmlmaWVkIHRo ZW0gZm9yIHVzLiBBY2NvcmRpbmcgdG8gdGhlbToNCj4gPiA+IA0KPiA+ID4gLSBDRkIgc2l6ZSA9 IENGQiBzdHJpZGUgKiBOdW1iZXIgb2YgbGluZXMgRkJDIHdyaXRlcyB0byBDRkINCj4gPiA+IC0g Q0ZCIHN0cmlkZSA9IHBsYW5lIHN0cmlkZSAvIGNvbXByZXNzaW9uIGxpbWl0DQo+ID4gPiAtIE51 bWJlciBvZiBsaW5lcyBGQkMgd3JpdGVzIHRvIENGQiA9IE1JTihwbGFuZSBzb3VyY2UgaGVpZ2h0 LA0KPiA+ID4gbWF4aW11bQ0KPiA+ID4gICBudW1iZXIgb2YgbGluZXMgRkJDIHdyaXRlcyB0byBD RkIpDQo+ID4gPiAtIFBsYW5lIHNvdXJjZSBoZWlnaHQgPQ0KPiA+ID4gICAtIHBpcGUgc291cmNl IGhlaWdodCAoUElQRV9TUkNTWiByZWdpc3RlcikgKGJlZm9yZSBTS0wpDQo+ID4gPiAgIC0gcGxh bmUgc2l6ZSByZWdpc3RlciBoZWlnaHQgKFBMQU5FX1NJWkUgcmVnaXN0ZXIpIChTS0wrKQ0KPiA+ ID4gLSBNYXhpbXVtIG51bWJlciBvZiBsaW5lcyBGQkMgd3JpdGVzIHRvIENGQiA9DQo+ID4gPiAg IC0gcGxhbmUgc291cmNlIGhlaWdodCAoYmVmb3JlIEhTVykNCj4gPiA+ICAgLSAyMDQ4IChIU1cr KQ0KPiA+ID4gDQo+ID4gPiBGb3IgdGhlIHBsYW5lIHNvdXJjZSBoZWlnaHQsIEkgY291bGQganVz dCBoYXZlIG1hZGUgb3VyIGNvZGUgZG8NCj4gPiA+IEk5MTVfUkVBRCgpIGluIG9yZGVyIHRvIGJl IG1vcmUgZnV0dXJlIHByb29mLCBidXQgc2luY2UgaXQncyBub3QNCj4gPiA+IGNvb2wNCj4gPiA+ IHRvIGRvIHJlZ2lzdGVyIHJlYWRzIEkgZGVjaWRlZCB0byBqdXN0IHJlY2FsY3VsYXRlIHRoZSB2 YWx1ZXMgd2UNCj4gPiA+IHVzZQ0KPiA+ID4gd2hlbiB3ZSBhY3R1YWxseSB3cml0ZSB0byB0aG9z ZSByZWdpc3RlcnMuDQo+ID4gPiANCj4gPiA+IFdpdGggdGhpcyBwYXRjaCwgZGVwZW5kaW5nIG9u IHlvdXIgbWFjaGluZSBjb25maWd1cmF0aW9uLCBhIGxvdA0KPiA+ID4gb2YgdGhlDQo+ID4gPiBr bXNfZnJvbnRidWZmZXJfdHJhY2tpbmcgc3VidGVzdHMgdGhhdCB1c2VkIHRvIHJlc3VsdCBpbiBh IFNLSVANCj4gPiA+IGR1ZSB0bw0KPiA+ID4gbm90IGVub3VnaCBzdG9sZW4gbWVtb3J5IHN0aWxs IHN0YXJ0IHJlc3VsdGluZyBpbiBhIFBBU1MuDQo+ID4gPiANCj4gPiA+IHYyOiBVc2UgdGhlIGNs aXBwZWQgc3JjIHNpemUgaW5zdGVhZCBvZiBwaXBlX3NyY19oIChWaWxsZSkuDQo+ID4gPiB2Mzog VXNlIHRoZSBhcHByb3ByaWF0ZSBpbmZvcm1hdGlvbiBwcm92aWRlZCBieSB0aGUgaGFyZHdhcmUN Cj4gPiA+IGd1eXMuDQo+ID4gPiANCj4gPiA+IENjOiBWaWxsZSBTeXJqw6Rsw6QgPHZpbGxlLnN5 cmphbGFAbGludXguaW50ZWwuY29tPg0KPiA+ID4gU2lnbmVkLW9mZi1ieTogUGF1bG8gWmFub25p IDxwYXVsby5yLnphbm9uaUBpbnRlbC5jb20+DQo+ID4gPiAtLS0NCj4gPiA+ICBkcml2ZXJzL2dw dS9kcm0vaTkxNS9pbnRlbF9mYmMuYyB8IDU4DQo+ID4gPiArKysrKysrKysrKysrKysrKysrKysr KysrKysrKysrKysrKysrLS0tDQo+ID4gPiAgMSBmaWxlIGNoYW5nZWQsIDU0IGluc2VydGlvbnMo KyksIDQgZGVsZXRpb25zKC0pDQo+ID4gPiANCj4gPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dw dS9kcm0vaTkxNS9pbnRlbF9mYmMuYw0KPiA+ID4gYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRl bF9mYmMuYw0KPiA+ID4gaW5kZXggMWIyZWJiMi4uZDUzZjczZiAxMDA2NDQNCj4gPiA+IC0tLSBh L2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2ZiYy5jDQo+ID4gPiArKysgYi9kcml2ZXJzL2dw dS9kcm0vaTkxNS9pbnRlbF9mYmMuYw0KPiA+ID4gQEAgLTY5OCw5ICs2OTgsNjAgQEAgdm9pZCBp bnRlbF9mYmNfY2xlYW51cF9jZmIoc3RydWN0DQo+ID4gPiBkcm1faTkxNV9wcml2YXRlICpkZXZf cHJpdikNCj4gPiA+ICAJbXV0ZXhfdW5sb2NrKCZkZXZfcHJpdi0+ZmJjLmxvY2spOw0KPiA+ID4g IH0NCj4gPiA+ICANCj4gPiA+IC1zdGF0aWMgaW50IGludGVsX2ZiY19zZXR1cF9jZmIoc3RydWN0 IGRybV9pOTE1X3ByaXZhdGUNCj4gPiA+ICpkZXZfcHJpdiwgaW50IHNpemUsDQo+ID4gPiAtCQkJ ICAgICAgIGludCBmYl9jcHApDQo+ID4gPiArLyoNCj4gPiA+ICsgKiBGb3IgU0tMKywgdGhlIHBs YW5lIHNvdXJjZSBzaXplIHVzZWQgYnkgdGhlIGhhcmR3YXJlIGlzIGJhc2VkDQo+ID4gPiBvbiB0 aGUgdmFsdWUgd2UNCj4gPiA+ICsgKiB3cml0ZSB0byB0aGUgUElQRV9TSVpFIHJlZ2lzdGVyLiBG b3IgQkRXLSwgdGhlIGhhcmR3YXJlIGxvb2tzDQo+ID4gPiBhdCB0aGUgdmFsdWUgd2UNCj4gPiA+ ICsgKiB3cm90ZSB0byBQSVBFU1JDLg0KPiA+ID4gKyAqLw0KPiA+ID4gK3N0YXRpYyB2b2lkIGlu dGVsX2ZiY19nZXRfcGxhbmVfc291cmNlX3NpemVzKHN0cnVjdCBpbnRlbF9jcnRjDQo+ID4gPiAq Y3J0YywNCj4gPiA+ICsJCQkJCSAgICAgaW50ICp3aWR0aCwgaW50DQo+ID4gPiAqaGVpZ2h0KQ0K PiA+IA0KPiA+IHNpemUgaW4gbXkgbWluZCBhbHJlYWR5IGluY2x1ZGVzIHdpZHRoIGFuZCBoZWln aHQsIHNvIHBsdXJhbCBfc2l6ZXMNCj4gPiBkb2Vzbid0IG1ha2UgbXVjaCBzZW5zZSB0byBtZS4N Cj4gPiANCj4gPiA+ICB7DQo+ID4gPiArCXN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJp diA9IGNydGMtPmJhc2UuZGV2DQo+ID4gPiAtPmRldl9wcml2YXRlOw0KPiA+ID4gKwlzdHJ1Y3Qg aW50ZWxfcGxhbmVfc3RhdGUgKnBsYW5lX3N0YXRlID0NCj4gPiA+ICsJCQl0b19pbnRlbF9wbGFu ZV9zdGF0ZShjcnRjLT5iYXNlLnByaW1hcnkNCj4gPiA+IC0+c3RhdGUpOw0KPiA+ID4gKwlpbnQg dywgaDsNCj4gPiA+ICsNCj4gPiA+ICsJaWYgKElOVEVMX0lORk8oZGV2X3ByaXYpLT5nZW4gPj0g OSkgew0KPiA+ID4gKwkJaWYgKGludGVsX3JvdGF0aW9uXzkwX29yXzI3MChwbGFuZV9zdGF0ZQ0K PiA+ID4gLT5iYXNlLnJvdGF0aW9uKSkgew0KPiA+ID4gKwkJCXcgPSBkcm1fcmVjdF9oZWlnaHQo JnBsYW5lX3N0YXRlLT5zcmMpDQo+ID4gPiA+PiAxNjsNCj4gPiA+ICsJCQloID0gZHJtX3JlY3Rf d2lkdGgoJnBsYW5lX3N0YXRlLT5zcmMpID4+DQo+ID4gPiAxNjsNCj4gPiA+ICsJCX0gZWxzZSB7 DQo+ID4gPiArCQkJdyA9IGRybV9yZWN0X3dpZHRoKCZwbGFuZV9zdGF0ZS0+c3JjKSA+Pg0KPiA+ ID4gMTY7DQo+ID4gPiArCQkJaCA9IGRybV9yZWN0X2hlaWdodCgmcGxhbmVfc3RhdGUtPnNyYykN Cj4gPiA+ID4+IDE2Ow0KPiA+ID4gKwkJfQ0KPiA+IA0KPiA+IFlvdSBjYW4ganVzdCB1c2UgdGhp cyBzYW1lIGNvZGUgZm9yIGFsbCBwbGF0Zm9ybXMuDQoNClRoaXMgY29kZSBpcyB0cnlpbmcgdG8g cmVjYWxjdWxhdGUgdGhlIHZhbHVlcyB3ZSB1c2UgdG8gd3JpdGUgdG8NClBJUEVTUkMgYW5kIFBJ UEVfU0laRSBiZWNhdXNlIHRoYXQncyB3aGF0IHRoZSBIVyBpcyB1c2luZy4gU2luY2Ugb24gdGhl DQpvbGRlciBwbGF0Zm9ybXMgd2UgdXNlIGNydGMtPnBpcGVfc3JjX3ggZm9yIFBJUEVTUkMsIEkg dGhpbmsgdGhlDQpjb3JyZWN0IHRoaW5nIHRvIGRvIGlzIHRvIGNoZWNrIHRob3NlIHZhbHVlcy4N Cg0KDQo+ID4gDQo+ID4gQWN0dWFsbHkgSSdtIG5vdCBzdXJlIHdoYXQgd2Ugc2hvdWxkIGRvIHdy dC4gcm90YXRpb24uIERvIHdlDQo+ID4gc3VwcG9ydA0KPiA+IEZCQyB3aXRoIDkwLzI3MCBkZWdy ZWUgcm90YXRpb24/IFRoZSBzY2Fub3V0IGhhcHBlbnMgaW4gYSByb3RhdGVkDQo+ID4gZmFzaGlv biwgc28gc3dhcHBpbmcgdGhlIGRpbWVuc2lvbnMgbGlrZSB5b3UgZG8gd291bGQgc2VlbSBsaWtl IHRoZQ0KPiA+IHJpZ2h0IHRoaW5nLiBCdXQgbm90IHN1cmUuDQo+IA0KPiBXaGlsZSB3cml0aW5n IG15IHJlcGx5IHRvdGhlIEdUVCB0cmFja2luZyBvZmZzZXQgcGF0Y2gsIEkgcmVhbGl6ZWQNCj4g dGhhdA0KPiA5MC8yNzAgZGVncmVlIHJvdGF0aW9uIHJlcXVpcmVzIFktdGlsaW5nLCBzbyBzaW5j ZSB3ZSdyZSBjdXJyZW50bHkNCj4gbGltaXRpbmcgRkJDIHRvIFgtdGlsaW5nIHdlIGNhbiBuZXZl ciBnZXQgaGVyZSB3aXRoIDkwLzI3MCBkZWdyZWUNCj4gcm90YXRpb24uDQoNCkJ1dCBTS0wgRkJD IGRvZXMgc3VwcG9ydCBZIHRpbGluZyAoZXZlbiB0aG91Z2ggb3VyIGNvZGUgZG9lc24ndCksIHNv DQprZWVwaW5nIHRoZSBjaGVja3MgYXMgdGhleSBhcmUgd291bGQgaGVscCBwcmV2ZW50aW5nIGZ1 dHVyZSBwcm9ibGVtcy4NCg0KPiANCj4gPiANCj4gPiA+ICsJfSBlbHNlIHsNCj4gPiA+ICsJCXcg PSBjcnRjLT5jb25maWctPnBpcGVfc3JjX3c7DQo+ID4gPiArCQloID0gY3J0Yy0+Y29uZmlnLT5w aXBlX3NyY19oOw0KPiA+ID4gKwl9DQo+ID4gPiArDQo+ID4gPiArCWlmICh3aWR0aCkNCj4gPiA+ ICsJCSp3aWR0aCA9IHc7DQo+ID4gPiArCWlmIChoZWlnaHQpDQo+ID4gPiArCQkqaGVpZ2h0ID0g aDsNCj4gPiA+ICt9DQo+ID4gPiArDQo+ID4gPiArc3RhdGljIGludCBpbnRlbF9mYmNfY2FsY3Vs YXRlX2NmYl9zaXplKHN0cnVjdCBpbnRlbF9jcnRjICpjcnRjKQ0KPiA+ID4gK3sNCj4gPiA+ICsJ c3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2ID0gY3J0Yy0+YmFzZS5kZXYNCj4gPiA+ IC0+ZGV2X3ByaXZhdGU7DQo+ID4gPiArCXN0cnVjdCBkcm1fZnJhbWVidWZmZXIgKmZiID0gY3J0 Yy0+YmFzZS5wcmltYXJ5LT5mYjsNCj4gPiA+ICsJaW50IGxpbmVzOw0KPiA+ID4gKw0KPiA+ID4g KwlpbnRlbF9mYmNfZ2V0X3BsYW5lX3NvdXJjZV9zaXplcyhjcnRjLCBOVUxMLCAmbGluZXMpOw0K PiA+ID4gKwlpZiAoSU5URUxfSU5GTyhkZXZfcHJpdiktPmdlbiA+PSA3KQ0KPiA+ID4gKwkJbGlu ZXMgPSBtaW4obGluZXMsIDIwNDgpOw0KPiA+ID4gKw0KPiA+ID4gKwlyZXR1cm4gbGluZXMgKiBm Yi0+cGl0Y2hlc1swXTsNCj4gPiA+ICt9DQo+ID4gPiArDQo+ID4gPiArc3RhdGljIGludCBpbnRl bF9mYmNfc2V0dXBfY2ZiKHN0cnVjdCBpbnRlbF9jcnRjICpjcnRjKQ0KPiA+ID4gK3sNCj4gPiA+ ICsJc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2ID0gY3J0Yy0+YmFzZS5kZXYNCj4g PiA+IC0+ZGV2X3ByaXZhdGU7DQo+ID4gPiArCXN0cnVjdCBkcm1fZnJhbWVidWZmZXIgKmZiID0g Y3J0Yy0+YmFzZS5wcmltYXJ5LT5mYjsNCj4gPiA+ICsJaW50IHNpemUsIGZiX2NwcDsNCj4gPiA+ ICsNCj4gPiA+ICsJc2l6ZSA9IGludGVsX2ZiY19jYWxjdWxhdGVfY2ZiX3NpemUoY3J0Yyk7DQo+ ID4gPiArCWZiX2NwcCA9IGRybV9mb3JtYXRfcGxhbmVfY3BwKGZiLT5waXhlbF9mb3JtYXQsIDAp Ow0KPiA+IA0KPiA+IENhbiB3ZSBqdXN0IGFsbCBpdCAnY3BwJyBwbGVhc2UuIFdlIGFscmVhZHkg aGF2ZSB0b28gbWFueSBuYW1lcyBmb3INCj4gPiB0aGUNCg0KSSB3YXMganVzdCBtb3ZpbmcgdGhp bmdzIGFyb3VuZC4uLiANCg0KPiA+IHNhbWUgdGhpbmcuIFNvbWVvbmUgY291bGQgYWxzbyBkbyBh IHNtYWxsIHNlYXJjaCZyZXBsYWNlIHRvIHVuaWZ5DQo+ID4gdGhlDQo+ID4gd2hhdGV2ZXIgd2Ug aGF2ZSBjdXJyZW50bHkuDQoNCg0KU29tZW9uZSBjb3VsZCBwYXRjaCB0aGUgZHJtX2Zvcm1hdF9w bGFuZV9jcHAoKSBmdW5jdGlvbiBzbyB0aGF0IGl0IGF0DQpsZWFzdCBleHBsYWlucyB3aGF0IENQ UCBpcyBzdXBwb3NlZCB0byBtZWFuIGluIHRoaXMgY29udGV4dCAoQ29sb3JzIFBlcg0KUGl4ZWw/ IENvdW50b2ZieXRlcyBQZXIgUGl4ZWw/KS4gT3IgcmVuYW1lIHRoZSBmdW5jdGlvbiB0bw0KZHJt X2Zvcm1hdF9wYW5lX2JwcCgpIHRvIG1ha2UgdGhlIG5hbWUgbWF0Y2ggdGhlIGRlc2NyaXB0aW9u Lg0KDQo+ID4gDQo+ID4gPiArDQo+ID4gPiAgCWlmIChzaXplIDw9IGRldl9wcml2LT5mYmMudW5j b21wcmVzc2VkX3NpemUpDQo+ID4gPiAgCQlyZXR1cm4gMDsNCj4gPiA+ICANCj4gPiA+IEBAIC04 OTcsOCArOTQ4LDcgQEAgc3RhdGljIHZvaWQgX19pbnRlbF9mYmNfdXBkYXRlKHN0cnVjdA0KPiA+ ID4gZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYpDQo+ID4gPiAgCQlnb3RvIG91dF9kaXNhYmxl Ow0KPiA+ID4gIAl9DQo+ID4gPiAgDQo+ID4gPiAtCWlmIChpbnRlbF9mYmNfc2V0dXBfY2ZiKGRl dl9wcml2LCBvYmotPmJhc2Uuc2l6ZSwNCj4gPiA+IC0JCQkJZHJtX2Zvcm1hdF9wbGFuZV9jcHAo ZmINCj4gPiA+IC0+cGl4ZWxfZm9ybWF0LCAwKSkpIHsNCj4gPiA+ICsJaWYgKGludGVsX2ZiY19z ZXR1cF9jZmIoaW50ZWxfY3J0YykpIHsNCj4gPiA+ICAJCXNldF9ub19mYmNfcmVhc29uKGRldl9w cml2LA0KPiA+ID4gRkJDX1NUT0xFTl9UT09fU01BTEwpOw0KPiA+ID4gIAkJZ290byBvdXRfZGlz YWJsZTsNCj4gPiA+ICAJfQ0KPiA+ID4gLS0gDQo+ID4gPiAyLjUuMw0KPiA+IA0KPiA+IC0tIA0K PiA+IFZpbGxlIFN5cmrDpGzDpA0KPiA+IEludGVsIE9UQw0KPiA+IF9fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fDQo+ID4gSW50ZWwtZ2Z4IG1haWxpbmcgbGlz dA0KPiA+IEludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcNCj4gPiBodHRwOi8vbGlzdHMu ZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4DQo+IApfX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBs aXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cDovL2xpc3RzLmZyZWVkZXNr dG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=