From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Zanoni, Paulo R" Subject: Re: [PATCH 3/3] drm/i915: fix FBC buffer size checks Date: Thu, 1 Oct 2015 18:04:00 +0000 Message-ID: <1443722639.2442.22.camel@intel.com> References: <1443023547-19896-1-git-send-email-paulo.r.zanoni@intel.com> <1443643545-3603-1-git-send-email-paulo.r.zanoni@intel.com> <1443643545-3603-3-git-send-email-paulo.r.zanoni@intel.com> <20151001122210.GF26517@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTP id 3E86B6E481 for ; Thu, 1 Oct 2015 11:07:28 -0700 (PDT) In-Reply-To: <20151001122210.GF26517@intel.com> Content-Language: en-US Content-ID: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: "ville.syrjala@linux.intel.com" Cc: "intel-gfx@lists.freedesktop.org" List-Id: intel-gfx@lists.freedesktop.org RW0gUXVpLCAyMDE1LTEwLTAxIMOgcyAxNToyMiArMDMwMCwgVmlsbGUgU3lyasOkbMOkIGVzY3Jl dmV1Og0KPiBPbiBXZWQsIFNlcCAzMCwgMjAxNSBhdCAwNTowNTo0NVBNIC0wMzAwLCBQYXVsbyBa YW5vbmkgd3JvdGU6DQo+ID4gQWNjb3JkaW5nIHRvIG15IGV4cGVyaW1lbnRzIChhbmQgbGF0ZXIg Y29uZmlybWF0aW9uIGZyb20gdGhlDQo+ID4gaGFyZHdhcmUNCj4gPiBkZXZlbG9wZXJzKSwgdGhl IG1heGltdW0gc2l6ZXMgbWVudGlvbmVkIGluIHRoZSBzcGVjaWZpY2F0aW9uDQo+ID4gZGVsaW1p dA0KPiA+IGhvdyBmYXIgaW4gdGhlIGJ1ZmZlciB0aGUgaGFyZHdhcmUgdHJhY2tpbmcgY2FuIGdv LiBBbmQgdGhlDQo+ID4gaGFyZHdhcmUNCj4gPiBjYWxjdWxhdGVzIHRoZSBzaXplIGJhc2VkIG9u IHRoZSBwbGFuZSBhZGRyZXNzIHdlIHByb3ZpZGUgLSBhbmQgdGhlDQo+ID4gcHJvdmlkZWQgcGxh bmUgYWRkcmVzcyBtaWdodCBub3QgYmUgdGhlIHJlYWwgeDowLHk6MCBwb2ludCBkdWUgdG8NCj4g PiB0aGUNCj4gPiBjb21wdXRlX3BhZ2Vfb2Zmc2V0KCkgZnVuY3Rpb24uDQo+ID4gDQo+ID4gT24g cGxhdGZvcm1zIHRoYXQgZG8gdGhlIHgveSBvZmZzZXQgYWRqdXN0bWVudCB0cmljayBpdCB3aWxs IGJlDQo+ID4gcmVhbGx5DQo+ID4gaGFyZCB0byByZXByb2R1Y2UgYSBidWcsIGJ1dCBvbiB0aGUg Y3VycmVudCBTS0wgd2UgY2FuIHJlcHJvZHVjZQ0KPiA+IHRoZQ0KPiA+IGJ1ZyB3aXRoIGlndC9r bXNfZnJvbnRidWZmZXJfdHJhY2tpbmcvZmJjLWZhcmZyb21mZW5jZS4gV2l0aCB0aGlzDQo+ID4g cGF0Y2gsIHdlJ2xsIGdvIGZyb20gIkNSQyBhc3NlcnRpb24gZmFpbHVyZSIgdG8gIkZCQyB1bmV4 cGVjdGVkbHkNCj4gPiBkaXNhYmxlZCIsIHdoaWNoIGlzIHN0aWxsIGEgZmFpbHVyZSBvbiB0aGUg dGVzdCBzdWl0ZSBidXQgaXMgbm90IGENCj4gPiBwZXJjZWl2ZWQgdXNlciBidWcgLSB5b3Ugd2ls bCBqdXN0IG5vdCBzYXZlIGFzIG11Y2ggcG93ZXIgYXMgeW91DQo+ID4gY291bGQNCj4gPiBpZiBG QkMgaXMgZGlzYWJsZWQuDQo+ID4gDQo+ID4gdjIsIHJld3JpdGUgcGF0Y2ggYWZ0ZXIgY2xhcmlm aWNhdGlvbiBmcm9tIHRoZSBIYWR3YXJlIGd1eXM6DQo+ID4gICAtIFJlbmFtZSBmdW5jdGlvbiBz byBpdCdzIGNsZWFyIHdoYXQgdGhlIGNoZWNrIGlzIGZvci4NCj4gPiAgIC0gVXNlIHRoZSBuZXcg aW50ZWxfZmJjX2dldF9wbGFuZV9zb3VyY2Vfc2l6ZXMoKSBmdW5jdGlvbiBpbg0KPiA+IG9yZGVy DQo+ID4gICAgIHRvIGdldCB0aGUgcHJvcGVyIHNpemVzIGFzIHNlZW4gYnkgRkJDLg0KPiA+IA0K PiA+IFRlc3RjYXNlOiBpZ3Qva21zX2Zyb250YnVmZmVyX3RyYWNraW5nL2ZiYy1mYXJmcm9tZmVu Y2UgKFNLTCkNCj4gPiBTaWduZWQtb2ZmLWJ5OiBQYXVsbyBaYW5vbmkgPHBhdWxvLnIuemFub25p QGludGVsLmNvbT4NCj4gPiAtLS0NCj4gPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZmJj LmMgfCAxOSArKysrKysrKysrKysrKy0tLS0tDQo+ID4gIDEgZmlsZSBjaGFuZ2VkLCAxNCBpbnNl cnRpb25zKCspLCA1IGRlbGV0aW9ucygtKQ0KPiA+IA0KPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJz L2dwdS9kcm0vaTkxNS9pbnRlbF9mYmMuYw0KPiA+IGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50 ZWxfZmJjLmMNCj4gPiBpbmRleCBkNTNmNzNmLi4zMTNlZjkxIDEwMDY0NA0KPiA+IC0tLSBhL2Ry aXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2ZiYy5jDQo+ID4gKysrIGIvZHJpdmVycy9ncHUvZHJt L2k5MTUvaW50ZWxfZmJjLmMNCj4gPiBAQCAtODA1LDEwICs4MDUsMTYgQEAgc3RhdGljIGJvb2wg cGl4ZWxfZm9ybWF0X2lzX3ZhbGlkKHN0cnVjdA0KPiA+IGRybV9mcmFtZWJ1ZmZlciAqZmIpDQo+ ID4gIAl9DQo+ID4gIH0NCj4gPiAgDQo+ID4gLXN0YXRpYyBib29sIHBpcGVfc2l6ZV9pc192YWxp ZChzdHJ1Y3QgaW50ZWxfY3J0YyAqY3J0YykNCj4gPiArLyoNCj4gPiArICogRm9yIHNvbWUgcmVh c29uLCB0aGUgaGFyZHdhcmUgdHJhY2tpbmcgc3RhcnRzIGxvb2tpbmcgYXQNCj4gPiB3aGF0ZXZl ciB3ZQ0KPiA+ICsgKiBwcm9ncmFtbWVkIGFzIHRoZSBkaXNwbGF5IHBsYW5lIGJhc2UgYWRkcmVz cyByZWdpc3Rlci4gSXQgZG9lcw0KPiA+IG5vdCBsb29rIGF0DQo+ID4gKyAqIHRoZSBYIGFuZCBZ IG9mZnNldCByZWdpc3RlcnMuIFRoYXQncyB3aHkgd2UgbG9vayBhdCB0aGUgY3J0Yw0KPiA+IC0+ YWRqdXN0ZWR7eCx5fQ0KPiA+ICsgKiB2YXJpYWJsZXMgaW5zdGVhZCBvZiBqdXN0IGxvb2tpbmcg YXQgdGhlIHBpcGUgc2l6ZS4NCj4gDQo+ICJwbGFuZSBzaXplIiBvciBzb21ldGhpbmcNCg0KSSBn dWVzcyB3ZSBjYW4gc2F5ICJwaXBlL3BsYW5lIHNpemUiIGJlY2F1c2Ugd2UncmUgbm90IGxvb2tp bmcgYXQgYW55DQpvZiB0aGVzZS4NCg0KPiANCj4gPiArICovDQo+ID4gK3N0YXRpYyBib29sIGlu dGVsX2ZiY19od190cmFja2luZ19jb3ZlcnNfc2NyZWVuKHN0cnVjdCBpbnRlbF9jcnRjDQo+ID4g KmNydGMpDQo+ID4gIHsNCj4gPiAgCXN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiA9 IGNydGMtPmJhc2UuZGV2DQo+ID4gLT5kZXZfcHJpdmF0ZTsNCj4gPiAtCXVuc2lnbmVkIGludCBt YXhfdywgbWF4X2g7DQo+ID4gKwl1bnNpZ25lZCBpbnQgdXNlZF93LCB1c2VkX2gsIG1heF93LCBt YXhfaDsNCj4gPiAgDQo+ID4gIAlpZiAoSU5URUxfSU5GTyhkZXZfcHJpdiktPmdlbiA+PSA4IHx8 DQo+ID4gSVNfSEFTV0VMTChkZXZfcHJpdikpIHsNCj4gPiAgCQltYXhfdyA9IDQwOTY7DQo+ID4g QEAgLTgyMSw4ICs4MjcsMTEgQEAgc3RhdGljIGJvb2wgcGlwZV9zaXplX2lzX3ZhbGlkKHN0cnVj dA0KPiA+IGludGVsX2NydGMgKmNydGMpDQo+ID4gIAkJbWF4X2ggPSAxNTM2Ow0KPiA+ICAJfQ0K PiA+ICANCj4gPiAtCXJldHVybiBjcnRjLT5jb25maWctPnBpcGVfc3JjX3cgPD0gbWF4X3cgJiYN Cj4gPiAtCSAgICAgICBjcnRjLT5jb25maWctPnBpcGVfc3JjX2ggPD0gbWF4X2g7DQo+ID4gKwlp bnRlbF9mYmNfZ2V0X3BsYW5lX3NvdXJjZV9zaXplcyhjcnRjLCAmdXNlZF93LCAmdXNlZF9oKTsN Cj4gPiArCXVzZWRfdyArPSBjcnRjLT5hZGp1c3RlZF94Ow0KPiA+ICsJdXNlZF9oICs9IGNydGMt PmFkanVzdGVkX3k7DQo+ID4gKw0KPiA+ICsJcmV0dXJuIHVzZWRfdyA8PSBtYXhfdyAmJiB1c2Vk X2ggPD0gbWF4X2g7DQo+IA0KPiBNYWtlcyBzZW5zZS4gTm90IHN1cmUgdXNlZF8gaXMgdGhlIGJl c3QgcHJlZml4LiBNYXliZSBlZmZlY3RpdmVfID8NCj4gQnV0IEkNCj4gZG9uJ3QgbWluZCBpZiB5 b3UgdGhpbmsgdXNlZF8gaXMgYmV0dGVyLg0KDQpJIGFncmVlIHVzZWRfIGlzIG5vdCB2ZXJ5IGdv b2QuIEkgY2hhbmdlZCBteSBtaW5kIGEgZmV3IHRpbWVzIG9uIHRoZXNlDQpuYW1lcyBhbHJlYWR5 Lg0KDQo+IA0KPiBTbyB3aXRoIHRoZSBjb21tZW50IGZpeGVkIGEgYml0IHRoaXMgaXMNCj4gUmV2 aWV3ZWQtYnk6IFZpbGxlIFN5cmrDpGzDpCA8dmlsbGUuc3lyamFsYUBsaW51eC5pbnRlbC5jb20+ DQo+IA0KPiBZb3Uga25vdywgd2UgY291bGQgYXZvaWQgdGhlc2UgaXNzdWVzIGlmIHdlIHN0b3Bw ZWQgdXNpbmcgaHcgZ3R0DQo+IHRyYWNraW5nIHRvby4gQW5kIHRoZW4gd2UgY291bGQgdXNlIEZC QyB3aXRob3V0IGEgZmVuY2UsIGFuZCBoZW5jZQ0KPiB3b3VsZG4ndCBuZWVkIFgtdGlsaW5nLiBJ SVJDIHRoYXQncyBub3cgYWxsb3dlZCBvbiBTS0wrLg0KDQpUaGUgcHJvYmxlbSB3aXRoIHN0b3Bw aW5nIHRoZSBHVFQgdHJhY2tpbmcgaXMgdGhhdCB0aGVuIHdlJ2QgaGF2ZSB0bw0KY29tcGxldGVs eSBkaXNhYmxlIEZCQyB3aGVuIEdUVCBtbWFwcyBhcmUgYmVpbmcgdXNlZCwganVzdCBsaWtlIHdl IGRvDQpmb3IgUFNSLiBJIGRpZG4ndCBzdG9wIHRvIGNoZWNrIGhvdyBjb21tb24gdGhpcyBpcyBv ciBob3cgbXVjaCBwb3dlcg0Kd2UnZCBzdG9wIHNhdmluZyBpZiB3ZSBhY3R1YWxseSBkaWQgdGhp cy4gTWF5YmUgSSBzaG91bGQgYXQgc29tZSBwb2ludC4NCg0KVGhlIG90aGVyIHBsYW4gaXMgdG8g bWFrZSBvdXIgY29kZSBzdXBwb3J0IEZCQyBib3RoIHdpdGggYW5kIHdpdGhvdXQNCkdUVCB0cmFj a2luZyAoc28gd2UgY2FuIGRpc2FibGUganVzdCB0aGUgdHJhY2tpbmcgd2hlbiB3ZSBjb25jbHVk ZSBpdA0Kd29uJ3Qgd29yaykuIE1heWJlIHdlIGNhbiBpbXBsZW1lbnQgdGhpcyBmb3IgS2VybmVs IDUuMjMgOikNCg0KVGhhbmtzIGZvciB0aGUgcmV2aWV3cy4gSSdsbCBzZW5kIHRoZSB1cGRhdGVk IHZlcnNpb25zIHNvb24uDQoNCj4gDQo+ID4gIH0NCj4gPiAgDQo+ID4gIC8qKg0KPiA+IEBAIC04 OTksNyArOTA4LDcgQEAgc3RhdGljIHZvaWQgX19pbnRlbF9mYmNfdXBkYXRlKHN0cnVjdA0KPiA+ IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2KQ0KPiA+ICAJCWdvdG8gb3V0X2Rpc2FibGU7DQo+ ID4gIAl9DQo+ID4gIA0KPiA+IC0JaWYgKCFwaXBlX3NpemVfaXNfdmFsaWQoaW50ZWxfY3J0Yykp IHsNCj4gPiArCWlmICghaW50ZWxfZmJjX2h3X3RyYWNraW5nX2NvdmVyc19zY3JlZW4oaW50ZWxf Y3J0YykpIHsNCj4gPiAgCQlzZXRfbm9fZmJjX3JlYXNvbihkZXZfcHJpdiwgRkJDX01PREVfVE9P X0xBUkdFKTsNCj4gPiAgCQlnb3RvIG91dF9kaXNhYmxlOw0KPiA+ICAJfQ0KPiA+IC0tIA0KPiA+ IDIuNS4zDQo+ID4gDQo+ID4gX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX18NCj4gPiBJbnRlbC1nZnggbWFpbGluZyBsaXN0DQo+ID4gSW50ZWwtZ2Z4QGxpc3Rz LmZyZWVkZXNrdG9wLm9yZw0KPiA+IGh0dHA6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1h bi9saXN0aW5mby9pbnRlbC1nZngNCj4gCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZy ZWVkZXNrdG9wLm9yZwpodHRwOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGlu Zm8vaW50ZWwtZ2Z4Cg==