From: "Zanoni, Paulo R" <paulo.r.zanoni@intel.com>
To: "chris@chris-wilson.co.uk" <chris@chris-wilson.co.uk>
Cc: "intel-gfx@lists.freedesktop.org" <intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH 13/18] drm/i915: remove too-frequent FBC debug message
Date: Wed, 21 Oct 2015 18:19:23 +0000 [thread overview]
Message-ID: <1445451561.2522.72.camel@intel.com> (raw)
In-Reply-To: <20151021130155.GP2551@nuc-i3427.alporthouse.com>
Em Qua, 2015-10-21 às 14:01 +0100, Chris Wilson escreveu:
> On Tue, Oct 20, 2015 at 11:49:59AM -0200, Paulo Zanoni wrote:
> > If we run igt/kms_frontbuffer_tracking, this message will appear
> > thousands of times, eating a significant part of our dmesg buffer.
> > It's part of the expected FBC behavior, so let's just silence it.
> >
> > Signed-off-by: Paulo Zanoni <paulo.r.zanoni@intel.com>
>
> Looks fine. Out of curiosity what metrics do we have for FBC
> activity? I
> presume we have tracepoints for activate/deactivate. and perhaps a sw
> timer, and a hw debug register?
The most important metric is PC state residency, but that requires the
machine to be properly configured: if SATA is preventing our machine
from going deeper than PC3, FBC won't change PC state residencies.
Also, our public processor datasheet docs mention the maximum expected
PC states for the most common screen resolutions.
We can work on adding more things later, such as the tracepoints or
software timer you mentioned. I've been 100% focused on getting the
bugs out first. Is there anything specific you think you could use?
> -Chris
>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2015-10-21 18:19 UTC|newest]
Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-20 13:49 [PATCH 00/18] Yet another FBC series Paulo Zanoni
2015-10-20 13:49 ` [PATCH 01/18] drm/i915: change no_fbc_reason from enum to string Paulo Zanoni
2015-10-21 6:52 ` Daniel Vetter
2015-10-20 13:49 ` [PATCH 02/18] drm/i915: don't stop+start FBC at every flip Paulo Zanoni
2015-10-21 7:04 ` Daniel Vetter
2015-10-21 7:12 ` Ville Syrjälä
2015-10-21 7:40 ` Ville Syrjälä
2015-10-20 13:49 ` [PATCH 03/18] drm/i915: only nuke FBC when a drawing operation triggers a flush Paulo Zanoni
2015-10-20 15:59 ` Chris Wilson
2015-10-21 17:08 ` Zanoni, Paulo R
2015-10-21 17:31 ` chris
2015-10-21 17:51 ` Zanoni, Paulo R
2015-10-20 13:49 ` [PATCH 04/18] drm/i915: extract crtc_is_valid() on the FBC code Paulo Zanoni
2015-10-20 15:52 ` Chris Wilson
2015-10-21 17:16 ` Zanoni, Paulo R
2015-10-21 17:28 ` chris
2015-10-22 7:52 ` Maarten Lankhorst
2015-10-22 19:26 ` Zanoni, Paulo R
2015-10-22 19:42 ` Ville Syrjälä
2015-10-20 13:49 ` [PATCH 05/18] drm/i915: set dev_priv->fbc.crtc before scheduling the enable work Paulo Zanoni
2015-10-20 16:03 ` Chris Wilson
2015-10-21 17:27 ` Zanoni, Paulo R
2015-10-21 18:15 ` chris
2015-10-20 13:49 ` [PATCH 06/18] drm/i915: use struct intel_crtc *crtc at __intel_fbc_update() Paulo Zanoni
2015-10-20 13:49 ` [PATCH 07/18] drm/i915: fix the __intel_fbc_update() comments Paulo Zanoni
2015-10-21 12:37 ` Chris Wilson
2015-10-21 17:32 ` Zanoni, Paulo R
2015-10-21 17:38 ` chris
2015-10-22 20:15 ` Zanoni, Paulo R
2015-10-20 13:49 ` [PATCH 08/18] drm/i915: pass the crtc as an argument to intel_fbc_update() Paulo Zanoni
2015-10-20 13:49 ` [PATCH 09/18] drm/i915: don't disable_fbc() if FBC is already disabled Paulo Zanoni
2015-10-20 13:49 ` [PATCH 10/18] drm/i915: introduce is_active/activate/deactivate to the FBC terminology Paulo Zanoni
2015-10-21 12:34 ` Chris Wilson
2015-10-21 17:45 ` Zanoni, Paulo R
2015-10-21 17:55 ` chris
2015-10-20 13:49 ` [PATCH 11/18] drm/i915: refactor FBC deactivation at init Paulo Zanoni
2015-10-21 12:59 ` Chris Wilson
2015-10-20 13:49 ` [PATCH 12/18] drm/i915: introduce intel_fbc_{enable, disable} Paulo Zanoni
2015-10-20 15:55 ` Chris Wilson
2015-10-20 13:49 ` [PATCH 13/18] drm/i915: remove too-frequent FBC debug message Paulo Zanoni
2015-10-21 13:01 ` Chris Wilson
2015-10-21 18:19 ` Zanoni, Paulo R [this message]
2015-10-22 19:52 ` chris
2015-10-20 13:50 ` [PATCH 14/18] drm/i915: fix the CFB size check Paulo Zanoni
2015-10-20 13:50 ` [PATCH 15/18] drm/i915: alloc/free the FBC CFB during enable/disable Paulo Zanoni
2015-10-21 7:11 ` Daniel Vetter
2015-10-21 7:20 ` Ville Syrjälä
2015-10-21 7:24 ` Daniel Vetter
2015-10-21 18:30 ` Zanoni, Paulo R
2015-10-22 7:59 ` Daniel Vetter
2015-10-20 13:50 ` [PATCH 16/18] drm/i915: move adjusted_mode checks from fbc_update to fbc_enable Paulo Zanoni
2015-10-20 13:50 ` [PATCH 17/18] drm/i915: move clock frequency " Paulo Zanoni
2015-10-20 13:50 ` [PATCH 18/18] drm/i915: check for FBC planes in the same place as the pipes Paulo Zanoni
2015-10-20 21:22 ` [PATCH igt 1/4] kms_frontbuffer_tracking: unset crtcs after getting the base blue CRC Paulo Zanoni
2015-10-20 21:22 ` [PATCH igt 2/4] kms_frontbuffer_tracking: add flag to not assert feature status Paulo Zanoni
2015-10-20 21:22 ` [PATCH igt 3/4] kms_frontbuffer_tracking: add stridechange subtest Paulo Zanoni
2015-10-20 21:22 ` [PATCH igt 4/4] kms_frontbuffer_tracking: remove opt.only_feature Paulo Zanoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1445451561.2522.72.camel@intel.com \
--to=paulo.r.zanoni@intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox