RE: [PATCH v7 11/25] drm/i915: Register color correction capabilities

Sharma, Shashank
2015-10-26T03:59:56Z

Thanks Daniel, Rob, for providing the clarification.
Jim, Does this sound good to you, now ?

Regards
Shashank
-----Original Message-----
From: Bradford, Robert
Sent: Thursday, October 22, 2015 5:36 PM
To: Bish, Jim; Sharma, Shashank
Cc: Palleti, Avinash Reddy; kausalmalladi@gmail.com; intel-gfx@lists.freedesktop.org; emil.l.velikov@gmail.com; Smith, Gary K; Roper, Matthew D; Vetter, Daniel; dri-devel@lists.freedesktop.org; Mukherjee, Indranil; Matheson, Annie J; Kumar, Kiran S
Subject: Re: [PATCH v7 11/25] drm/i915: Register color correction capabilities

> > diff --git a/drivers/gpu/drm/i915/i915_drv.h
> > b/drivers/gpu/drm/i915/i915_drv.h index 8afda45..613bee2 100644
> > --- a/drivers/gpu/drm/i915/i915_drv.h
> > +++ b/drivers/gpu/drm/i915/i915_drv.h
> > @@ -789,6 +789,8 @@ struct intel_device_info {
> > u8 num_sprites[I915_MAX_PIPES];
> > u8 gen;
> > u8 ring_mask; /* Rings supported by the HW */
> > + u16 num_samples_after_ctm;
> > + u16 num_samples_before_ctm;
> thought we agreed last week that num_samples was going to be removed.
> May be ok to handle in a later patch unless someone has strong
> objection.

This is for the reporting out of platform capability and is still needed as userspace needs to know the recommended table size so that it can resample as necessary.

Rob
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org