Re: [PATCH] drm/dp: add eDP DPCD backlight control bit definitions

From: Ander Conselvan De Oliveira <conselvan2@gmail.com>
To: Jani Nikula <jani.nikula@intel.com>, dri-devel@lists.freedesktop.org
Cc: Adebisi YetundeX <yetundex.adebisi@intel.com>,
	intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/dp: add eDP DPCD backlight control bit definitions
Date: Thu, 29 Oct 2015 14:27:32 +0200	[thread overview]
Message-ID: <1446121652.4272.2.camel@gmail.com> (raw)
In-Reply-To: <1446109388-4301-1-git-send-email-jani.nikula@intel.com>

On Thu, 2015-10-29 at 11:03 +0200, Jani Nikula wrote:
> Cc: Yetunde Adebisi <yetundex.adebisi@intel.com>
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
> ---
>  include/drm/drm_dp_helper.h | 36 ++++++++++++++++++++++++++++++++++++
>  1 file changed, 36 insertions(+)
> 
> diff --git a/include/drm/drm_dp_helper.h b/include/drm/drm_dp_helper.h
> index bb9d0deca07c..1252108da0ef 100644
> --- a/include/drm/drm_dp_helper.h
> +++ b/include/drm/drm_dp_helper.h
> @@ -455,16 +455,52 @@
>  # define DP_EDP_14			    0x03
>  
>  #define DP_EDP_GENERAL_CAP_1		    0x701
> +# define DP_EDP_TCON_BACKLIGHT_ADJUSTMENT_CAP		(1 << 0)
> +# define DP_EDP_BACKLIGHT_PIN_ENABLE_CAP		(1 << 1)
> +# define DP_EDP_BACKLIGHT_AUX_ENABLE_CAP		(1 << 2)
> +# define DP_EDP_PANEL_SELF_TEST_PIN_ENABLE_CAP		(1 << 3)
> +# define DP_EDP_PANEL_SELF_TEST_AUX_ENABLE_CAP		(1 << 4)
> +# define DP_EDP_FRC_ENABLE_CAP				(1 << 5)
> +# define DP_EDP_COLOR_ENGINE_CAP			(1 << 6)
> +# define DP_EDP_SET_POWER_CAP				(1 << 7)
>  
>  #define DP_EDP_BACKLIGHT_ADJUSTMENT_CAP     0x702
> +# define DP_EDP_BACKLIGHT_BRIGHTNESS_PWM_PIN_CAP	(1 << 0)
> +# define DP_EDP_BACKLIGHT_BRIGHTNESS_AUX_SET_CAP	(1 << 1)
> +# define DP_EDP_BACKLIGHT_BRIGHTNESS_BYTE_COUNT		(1 << 2)
> +# define DP_EDP_BACKLIGHT_AUX_PWM_PRODUCT_CAP		(1 << 3)
> +# define DP_EDP_BACKLIGHT_FREQ_PWM_PIN_PASSTHRU_CAP	(1 << 4)
> +# define DP_EDP_BACKLIGHT_FREQ_AUX_SET_CAP		(1 << 5)
> +# define DP_EDP_DYNAMIC_BACKLIGHT_CAP			(1 << 6)
> +# define DP_EDP_VBLANK_BACKLIGHT_UPDATE_CAP		(1 << 7)
>  
>  #define DP_EDP_GENERAL_CAP_2		    0x703
> +# define DP_EDP_OVERDRIVE_ENGINE_ENABLED		(1 << 0)
>  
>  #define DP_EDP_GENERAL_CAP_3		    0x704    /* eDP 1.4 */
> +# define DP_EDP_X_REGION_CAP_MASK			(0xf << 0)
> +# define DP_EDP_X_REGION_CAP_SHIFT			0
> +# define DP_EDP_Y_REGION_CAP_MASK			(0xf << 4)
> +# define DP_EDP_Y_REGION_CAP_SHIFT			4
>  
>  #define DP_EDP_DISPLAY_CONTROL_REGISTER     0x720
> +# define DP_EDP_BACKLIGHT_ENABLE			(1 << 0)
> +# define DP_EDP_BLACK_VIDEO_ENABLE			(1 << 1)
> +# define DP_EDP_FRC_ENABLE				(1 << 2)
> +# define DP_EDP_COLOR_ENGINE_ENABLE			(1 << 3)
> +# define DP_EDP_VBLANK_BACKLIGHT_UPDATE_ENABLE		(1 << 7)
>  
>  #define DP_EDP_BACKLIGHT_MODE_SET_REGISTER  0x721
> +# define DP_EDP_BACKLIGHT_CONTROL_MODE_MASK		(3 << 0)
> +# define DP_EDP_BACKLIGHT_CONTROL_MODE_PWM		(0 << 0)
> +# define DP_EDP_BACKLIGHT_CONTROL_MODE_PRESET		(1 << 0)
> +# define DP_EDP_BACKLIGHT_CONTROL_MODE_DPCD		(2 << 0)
> +# define DP_EDP_BACKLIGHT_CONTROL_MODE_PRODUCT		(3 << 0)
> +# define DP_EDP_BACKLIGHT_FREQ_PWM_PIN_PASSTHRU_ENABLE	(1 << 2)
> +# define DP_EDP_BACKLIGHT_FREQ_AUX_SET_ENABLE		(1 << 3)
> +# define DP_EDP_DYNAMIC_BACKLIGHT_ENABLE		(1 << 4)
> +# define DP_EDP_REGIONAL_BACKLIGHT_ENABLE		(1 << 5)

Doesn't DP_EDP_REGIONAL_BACKLIGHT_ENABLE need a /* eDP 1.4 */ comment too?

Anyway, it all matches the spec so,

Reviewed-by: Ander Conselvan de Oliveira <conselvan2@gmail.com>

> +# define DP_EDP_UPDATE_REGION_BRIGHTNESS		(1 << 6) /* eDP 1.4
> */
>  
>  #define DP_EDP_BACKLIGHT_BRIGHTNESS_MSB     0x722
>  #define DP_EDP_BACKLIGHT_BRIGHTNESS_LSB     0x723
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx