From: Shobhit Kumar <shobhit.kumar@intel.com>
To: intel-gfx@lists.freedesktop.org
Cc: Shobhit Kumar <shobhit.kumar@intel.com>
Subject: [PATCH] CDCLOCK Sanitization continued for SKL
Date: Mon, 2 Nov 2015 17:25:07 +0530 [thread overview]
Message-ID: <1446465308-3639-1-git-send-email-shobhit.kumar@intel.com> (raw)
The cdclock sanitization patch reviewed and merged at -
http://patchwork.freedesktop.org/patch/msgid/1445344992-14658-1-git-send-email-shobhit.kumar@intel.com
made the assumptions that DPLL should not be enabled when pre-os does not enable display and if it does then verify that the cdclock is corectly programmed as well. The BIOS was actually enabling DPLL as well while not following BSPEC sequence and writing cdclk register directly. I was working with BIOS team to correct this and found that due to a WA needed where audio codec will not be enumerated in OS if BIOS did not program the audio verbs which needed PG2 and DPLL enabling. More discussion revealed the following logic -
1. BIOS puts max cdclk for the platform in CDCLK_CTL. VBIOS/GOP reads that value and then programs cdclk to desired value.
2. It also then sets SWF18 to indicate to the OS that it has enabled display. Used for fastmodeset actually in windows.
3. It also sets SWF06 with this max cdclock(from what bios programmed in CDCLK_CTL) for OS to know.
This patch uses point 2 above while sanitizing the cdclk. We can also update our logic for deciding max cdclock based on SWF06 if pre-os enables else directly from CDCLK_CTL (no pre-os display). That is not part of this patch.
Shobhit Kumar (1):
drm/i915/skl: While sanitizing cdclock check the SWF18 as well
drivers/gpu/drm/i915/i915_reg.h | 3 +++
drivers/gpu/drm/i915/intel_display.c | 8 ++++++++
2 files changed, 11 insertions(+)
--
2.4.3
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next reply other threads:[~2015-11-02 11:55 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-02 11:55 Shobhit Kumar [this message]
2015-11-02 11:55 ` [PATCH] drm/i915/skl: While sanitizing cdclock check the SWF18 as well Shobhit Kumar
2015-11-02 13:10 ` Jani Nikula
2015-11-02 13:19 ` Kumar, Shobhit
2015-11-02 16:37 ` Thulasimani, Sivakumar
2015-11-02 17:47 ` Kumar, Shobhit
2015-11-02 18:18 ` Thulasimani, Sivakumar
2015-11-03 2:59 ` Kumar, Shobhit
2015-11-05 7:43 ` [v2] " Shobhit Kumar
2015-11-05 9:35 ` [v3] " Shobhit Kumar
2015-11-05 9:38 ` Thulasimani, Sivakumar
2015-11-05 11:23 ` Ville Syrjälä
2015-11-05 12:35 ` [v4] " Shobhit Kumar
2015-11-05 13:04 ` Jani Nikula
2015-11-04 3:47 ` [PATCH] " Kumar, Shobhit
2015-11-03 3:12 ` [PATCH] CDCLOCK Sanitization continued for SKL Kumar, Shobhit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1446465308-3639-1-git-send-email-shobhit.kumar@intel.com \
--to=shobhit.kumar@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox