From: Matt Roper <matthew.d.roper@intel.com>
To: intel-gfx@lists.freedesktop.org
Cc: jani.nikula@intel.com
Subject: [PATCH 0/4] Wrap up ILK-style atomic watermarks, try two
Date: Mon, 2 Nov 2015 18:14:48 -0800 [thread overview]
Message-ID: <1446516892-25937-1-git-send-email-matthew.d.roper@intel.com> (raw)
Patches #3 and #4 here are the final two patches from the atomic watermark
series that was posted here:
http://lists.freedesktop.org/archives/intel-gfx/2015-September/076634.html
We had to pull those out when Jani reported a BDW boot regression (divide by
zero during watermark calculation). Although we never found a smoking gun for
that divide by zero, I haven't been able to reproduce the issue on a similar
system. There's been a lot of code churn since that time, so I'm hoping that
we've either already fixed the issue without realizing it, or that the extra
paranoia added in patch #2 here will avoid the crash and highlight the culprit.
The first patch here solves a legitimate bug that could cause a divide-by-zero
(just not the one Jani was seeing). The second patch adds extra guards on
divide operations to verify our invariants and ensure that bugs elsewhere in
the driver can't lead to a fatal divide-by-zero (at least on the ILK
codepaths).
Please don't merge #3 or #4 here until we at least get a positive test result
from Jani.
Matt Roper (4):
drm/i915: Convert hsw_compute_linetime_wm to use in-flight state
drm/i915: Add extra paranoia to ILK watermark calculations
drm/i915: Sanitize watermarks after hardware state readout
drm/i915: Add two-stage ILK-style watermark programming (v6)
drivers/gpu/drm/i915/i915_drv.h | 5 +
drivers/gpu/drm/i915/intel_atomic.c | 1 +
drivers/gpu/drm/i915/intel_display.c | 137 +++++++++++++++++++++++++-
drivers/gpu/drm/i915/intel_drv.h | 31 +++++-
drivers/gpu/drm/i915/intel_pm.c | 186 +++++++++++++++++++++++++----------
5 files changed, 305 insertions(+), 55 deletions(-)
--
2.1.4
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next reply other threads:[~2015-11-03 2:16 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-03 2:14 Matt Roper [this message]
2015-11-03 2:14 ` [PATCH 1/4] drm/i915: Convert hsw_compute_linetime_wm to use in-flight state Matt Roper
2015-11-03 2:14 ` [PATCH 2/4] drm/i915: Add extra paranoia to ILK watermark calculations Matt Roper
2015-11-03 2:14 ` [PATCH 3/4] drm/i915: Sanitize watermarks after hardware state readout Matt Roper
2015-11-03 2:14 ` [PATCH 4/4] drm/i915: Add two-stage ILK-style watermark programming (v6) Matt Roper
2015-11-03 16:55 ` [PATCH 4/4] drm/i915: Add two-stage ILK-style watermark programming (v7) Matt Roper
2015-11-03 10:02 ` [PATCH 0/4] Wrap up ILK-style atomic watermarks, try two Jani Nikula
2015-11-03 16:54 ` [PATCH 3/4] drm/i915: Sanitize watermarks after hardware state readout (v2) Matt Roper
2015-11-04 14:12 ` Jani Nikula
2015-11-05 0:46 ` Matt Roper
2015-11-05 12:55 ` Jani Nikula
2015-11-13 0:41 ` Matt Roper
2015-11-20 4:01 ` Matt Roper
2015-11-20 8:37 ` Daniel Vetter
2015-11-20 13:14 ` Ville Syrjälä
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1446516892-25937-1-git-send-email-matthew.d.roper@intel.com \
--to=matthew.d.roper@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox