public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Imre Deak <imre.deak@intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: get runtime PM reference around GEM set_caching IOCTL
Date: Thu, 05 Nov 2015 13:28:32 +0200	[thread overview]
Message-ID: <1446722912.26194.14.camel@intel.com> (raw)
In-Reply-To: <20151104205741.GA3478@nuc-i3427.alporthouse.com>

On ke, 2015-11-04 at 20:57 +0000, Chris Wilson wrote:
> On Wed, Nov 04, 2015 at 09:25:32PM +0200, Imre Deak wrote:
> > After Damien's D3 fix I started to get runtime suspend residency for the
> > first time and that revealed a breakage on the set_caching IOCTL path
> > that accesses the HW but doesn't take an RPM ref. Fix this up.
> 
> Why here (and in so many random places) and not around the PTE write
> itself?

Imo we should take the RPM ref outside of any of our locks. Otherwise we
need hacks like we have currently in the runtime suspend handler to work
around lock inversions. It works now, but we couldn't do the same trick
if we needed to take struct_mutex for example in the resume handler too
for some reason.

> -Chris
> 


_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2015-11-05 11:28 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-04 19:25 [PATCH] drm/i915: get runtime PM reference around GEM set_caching IOCTL Imre Deak
2015-11-04 19:47 ` Paulo Zanoni
2015-11-16 13:33   ` Jani Nikula
2015-11-17 19:00   ` Daniel Vetter
2015-11-17 19:22     ` Imre Deak
2015-11-04 20:57 ` Chris Wilson
2015-11-05 11:28   ` Imre Deak [this message]
2015-11-05 11:56     ` Chris Wilson
2015-11-05 22:57       ` Imre Deak
2015-11-05 23:24         ` Imre Deak
2015-11-06  8:54         ` Chris Wilson
2015-11-09 13:09           ` Imre Deak
2015-11-09 13:25             ` Chris Wilson
2015-11-09 13:36               ` Imre Deak
2015-11-09 13:43                 ` Chris Wilson
2015-11-17 22:16       ` Daniel Vetter
2015-11-17 22:38         ` Chris Wilson
2015-11-17 22:49           ` Imre Deak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1446722912.26194.14.camel@intel.com \
    --to=imre.deak@intel.com \
    --cc=chris@chris-wilson.co.uk \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox