public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
From: yu.dai@intel.com
To: intel-gfx@lists.freedesktop.org
Subject: [PATCH v1] drm/i915/guc: Fix a fw content lost issue after it is evicted
Date: Tue, 10 Nov 2015 15:27:36 -0800	[thread overview]
Message-ID: <1447198056-24065-1-git-send-email-yu.dai@intel.com> (raw)
In-Reply-To: <20151109101509.GD22414@nuc-i3427.alporthouse.com>

From: Alex Dai <yu.dai@intel.com>

We keep a copy of GuC fw in a GEM obj. However its content is lost
if the GEM obj is swapped (igt/gem_evict_*). Therefore, the later
fw loading during GPU reset will fail. Mark the obj dirty after
copying data into the pages. So its content will be kept during
swapped out.

Signed-off-by: Alex Dai <yu.dai@intel.com>
---
 drivers/gpu/drm/i915/i915_gem.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c
index f1e3fde..3b15167 100644
--- a/drivers/gpu/drm/i915/i915_gem.c
+++ b/drivers/gpu/drm/i915/i915_gem.c
@@ -5199,6 +5199,7 @@ i915_gem_object_create_from_data(struct drm_device *dev,
 	i915_gem_object_pin_pages(obj);
 	sg = obj->pages;
 	bytes = sg_copy_from_buffer(sg->sgl, sg->nents, (void *)data, size);
+	obj->dirty = 1;
 	i915_gem_object_unpin_pages(obj);
 
 	if (WARN_ON(bytes != size)) {
-- 
2.5.0

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2015-11-10 23:30 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-06 21:55 [PATCH] drm/i915/guc: Fix a fw content lost issue after it is evicted yu.dai
2015-11-06 22:07 ` Chris Wilson
2015-11-06 23:18   ` Yu Dai
2015-11-09 10:15     ` Chris Wilson
2015-11-10 23:27       ` yu.dai [this message]
2015-11-11  9:07         ` [PATCH v1] " Chris Wilson
2015-11-11 19:01           ` Yu Dai
2015-11-23  9:18           ` akash goel
2015-11-23  9:37             ` Chris Wilson
2015-11-24 15:47         ` Dave Gordon
2015-11-24 16:04           ` Daniel Vetter
2015-11-24 17:47             ` Dave Gordon
2015-11-24 18:06               ` Daniel Vetter
2015-11-24 23:01                 ` Chris Wilson
2015-11-25  8:40                   ` Daniel Vetter
2015-11-25  9:02                     ` Chris Wilson
2015-11-25  9:59                       ` Daniel Vetter
2015-11-10 23:29       ` [PATCH] " Yu Dai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1447198056-24065-1-git-send-email-yu.dai@intel.com \
    --to=yu.dai@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox