From: Ander Conselvan De Oliveira <conselvan2@gmail.com>
To: Jim Bride <jim.bride@linux.intel.com>, intel-gfx@lists.freedesktop.org
Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
Subject: Re: [PATCH] drm/i915/skl: Update DDI translation tables for SKL
Date: Fri, 13 Nov 2015 14:39:50 +0200 [thread overview]
Message-ID: <1447418390.2593.9.camel@gmail.com> (raw)
In-Reply-To: <1447246970.3406.24.camel@gmail.com>
On Wed, 2015-11-11 at 15:02 +0200, Ander Conselvan De Oliveira wrote:
> On Fri, 2015-11-06 at 15:30 -0800, Jim Bride wrote:
> > While comparing the B-Spec with the code I noticed that several
> > values in these tables have been updated in the spec, so I
> > changed the code to match..
> >
> > Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> > Signed-off-by: Jim Bride <jim.bride@linux.intel.com>
>
> Reviewed-by: Ander Conselvan de Oliveira <conselvan2@gmail.com>
Pushed to dinq. Thanks for the patch.
Ander
>
> > ---
> > drivers/gpu/drm/i915/intel_ddi.c | 22 +++++++++++-----------
> > 1 file changed, 11 insertions(+), 11 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/i915/intel_ddi.c
> > b/drivers/gpu/drm/i915/intel_ddi.c
> > index 036ff9b..d0062ad 100644
> > --- a/drivers/gpu/drm/i915/intel_ddi.c
> > +++ b/drivers/gpu/drm/i915/intel_ddi.c
> > @@ -133,12 +133,12 @@ static const struct ddi_buf_trans
> > skl_ddi_translations_dp[] = {
> > { 0x00002016, 0x000000A0, 0x0 },
> > { 0x00005012, 0x0000009B, 0x0 },
> > { 0x00007011, 0x00000088, 0x0 },
> > - { 0x00009010, 0x000000C7, 0x0 },
> > + { 0x80009010, 0x000000C0, 0x1 }, /* Uses I_boost level 0x1
> > */
> > { 0x00002016, 0x0000009B, 0x0 },
> > { 0x00005012, 0x00000088, 0x0 },
> > - { 0x00007011, 0x000000C7, 0x0 },
> > + { 0x80007011, 0x000000C0, 0x1 }, /* Uses I_boost level 0x1
> > */
> > { 0x00002016, 0x000000DF, 0x0 },
> > - { 0x00005012, 0x000000C7, 0x0 },
> > + { 0x80005012, 0x000000C0, 0x1 }, /* Uses I_boost level 0x1
> > */
> > };
> >
> > /* Skylake U */
> > @@ -146,12 +146,12 @@ static const struct ddi_buf_trans
> > skl_u_ddi_translations_dp[] = {
> > { 0x0000201B, 0x000000A2, 0x0 },
> > { 0x00005012, 0x00000088, 0x0 },
> > { 0x00007011, 0x00000087, 0x0 },
> > - { 0x80009010, 0x000000C7, 0x1 }, /* Uses I_boost level 0x1
> > */
> > + { 0x80009010, 0x000000C0, 0x1 }, /* Uses I_boost level 0x1
> > */
> > { 0x0000201B, 0x0000009D, 0x0 },
> > - { 0x00005012, 0x000000C7, 0x0 },
> > - { 0x00007011, 0x000000C7, 0x0 },
> > + { 0x80005012, 0x000000C0, 0x1 }, /* Uses I_boost level 0x1
> > */
> > + { 0x80007011, 0x000000C0, 0x1 }, /* Uses I_boost level 0x1
> > */
> > { 0x00002016, 0x00000088, 0x0 },
> > - { 0x00005012, 0x000000C7, 0x0 },
> > + { 0x80005012, 0x000000C0, 0x1 }, /* Uses I_boost level 0x1
> > */
> > };
> >
> > /* Skylake Y */
> > @@ -159,12 +159,12 @@ static const struct ddi_buf_trans
> > skl_y_ddi_translations_dp[] = {
> > { 0x00000018, 0x000000A2, 0x0 },
> > { 0x00005012, 0x00000088, 0x0 },
> > { 0x00007011, 0x00000087, 0x0 },
> > - { 0x80009010, 0x000000C7, 0x3 }, /* Uses I_boost level 0x3
> > */
> > + { 0x80009010, 0x000000C0, 0x3 }, /* Uses I_boost level 0x3
> > */
> > { 0x00000018, 0x0000009D, 0x0 },
> > - { 0x00005012, 0x000000C7, 0x0 },
> > - { 0x00007011, 0x000000C7, 0x0 },
> > + { 0x80005012, 0x000000C0, 0x3 }, /* Uses I_boost level 0x3
> > */
> > + { 0x80007011, 0x000000C0, 0x3 }, /* Uses I_boost level 0x3
> > */
> > { 0x00000018, 0x00000088, 0x0 },
> > - { 0x00005012, 0x000000C7, 0x0 },
> > + { 0x80005012, 0x000000C0, 0x3 }, /* Uses I_boost level 0x3
> > */
> > };
> >
> > /*
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
prev parent reply other threads:[~2015-11-13 12:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-06 23:30 [PATCH] drm/i915/skl: Update DDI translation tables for SKL Jim Bride
2015-11-11 13:02 ` Ander Conselvan De Oliveira
2015-11-13 12:39 ` Ander Conselvan De Oliveira [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1447418390.2593.9.camel@gmail.com \
--to=conselvan2@gmail.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jim.bride@linux.intel.com \
--cc=rodrigo.vivi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox