Re: [PATCH v3 0/7] drm/i915: improve the RPM device suspended assert

[Imre Deak <imre.deak@intel.com>]

On pe, 2015-11-13 at 10:52 +0200, Jani Nikula wrote:
> On Thu, 12 Nov 2015, Imre Deak <imre.deak@intel.com> wrote:
> > This is v3 of [1]. I addressed the review comments from Ville and
> > Chris
> > and added an RPM atomic section check as well requested by Chris. I
> > was
> > also considering using lockdep for more coverage, but decided to
> > leave
> > that out for now, we can also add that later if needed.
> > 
> > The patchset depends on Patrik's DC rework patchset [2].
> 
> Uh-oh, so now we have a reviewed series, except it depends on a
> series
> that isn't ready, which has its own dependencies, and I've lost track
> of
> all the series in flight by now... Imre, I trust you to move the
> review
> of the dependencies forward, pinging people as necessary.

Yes, there are the two DC/DMC patchsets you mentioned that would need
to get merged before this one, they are being reviewed atm. There is no
functional dependency, I only want to avoid merge conflicts. For
reference and if someone wants to experiment with it there is the
following branch with all 3 patchsets:

https://github.com/ideak/linux/commits/rpm-assert-improvements

--Imre

> 
> BR,
> Jani.
> 
> 
> 
> > 
> > [1] http://lists.freedesktop.org/archives/intel-gfx/2015-November/0
> > 79777.html
> > [2]
> > http://lists.freedesktop.org/archives/intel-gfx/2015-November/07975
> > 8.html
> > 
> > Imre Deak (7):
> >   drm/i915: remove HAS_RUNTIME_PM check from RPM get/put/assert
> > helpers
> >   drm/i915: add assert_rpm_wakelock_held helper
> >   drm/i915: use assert_rpm_wakelock_held instead of opencoding it
> >   drm/i915: add support for checking if we hold an RPM reference
> >   drm/i915: sanitize the asserts in the RPM get/put helpers
> >   drm/i915: add support for checking RPM atomic sections
> >   drm/i915: check that we are in an RPM atomic section in GGTT PTE
> >     updaters
> > 
> >  drivers/gpu/drm/i915/i915_dma.c         |  7 ++++
> >  drivers/gpu/drm/i915/i915_drv.c         | 39 +++++++++++++++++--
> >  drivers/gpu/drm/i915/i915_drv.h         |  2 +
> >  drivers/gpu/drm/i915/i915_gem_gtt.c     | 33 ++++++++++++++++
> >  drivers/gpu/drm/i915/i915_irq.c         | 12 +++++-
> >  drivers/gpu/drm/i915/intel_drv.h        | 67
> > +++++++++++++++++++++++++++++++++
> >  drivers/gpu/drm/i915/intel_pm.c         |  2 +
> >  drivers/gpu/drm/i915/intel_runtime_pm.c | 24 +++++-------
> >  drivers/gpu/drm/i915/intel_uncore.c     | 19 +++-------
> >  9 files changed, 172 insertions(+), 33 deletions(-)
> > 
> > -- 
> > 2.5.0
> > 
> > _______________________________________________
> > Intel-gfx mailing list
> > Intel-gfx@lists.freedesktop.org
> > http://lists.freedesktop.org/mailman/listinfo/intel-gfx
> 
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx