From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ander Conselvan De Oliveira Subject: Re: [PATCH 2/6] drm/i915: Cleaning up intel_dp_hpd_pulse Date: Mon, 16 Nov 2015 16:46:16 +0200 Message-ID: <1447685176.2624.36.camel@gmail.com> References: <1446812886-32156-1-git-send-email-shubhangi.shrivastava@intel.com> <1446812886-32156-3-git-send-email-shubhangi.shrivastava@intel.com> <1447684396.2624.34.camel@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-pa0-f49.google.com (mail-pa0-f49.google.com [209.85.220.49]) by gabe.freedesktop.org (Postfix) with ESMTPS id 03DC76E105 for ; Mon, 16 Nov 2015 06:46:19 -0800 (PST) Received: by pabfh17 with SMTP id fh17so179878336pab.0 for ; Mon, 16 Nov 2015 06:46:18 -0800 (PST) In-Reply-To: <1447684396.2624.34.camel@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Shubhangi Shrivastava , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gTW9uLCAyMDE1LTExLTE2IGF0IDE2OjMzICswMjAwLCBBbmRlciBDb25zZWx2YW4gRGUgT2xp dmVpcmEgd3JvdGU6Cj4gT24gRnJpLCAyMDE1LTExLTA2IGF0IDE3OjU4ICswNTMwLCBTaHViaGFu Z2kgU2hyaXZhc3RhdmEgd3JvdGU6Cj4gPiBDdXJyZW50IERQIGRldGVjdGlvbiBoYXMgRFBDRCBv cGVyYXRpb25zIHNwbGl0IGFjcm9zcwo+ID4gaW50ZWxfZHBfaHBkX3B1bHNlIGFuZCBpbnRlbF9k cF9kZXRlY3Qgd2hpY2ggY29udGFpbnMKPiA+IGR1cGxpY2F0ZXMgYXMgd2VsbC4gQWxzbyBpbnRl bF9kcF9kZXRlY3QgaXMgY2FsbGVkCj4gPiBkdXJpbmcgbW9kZXMgZW51bWVyYXRpb24gYXMgd2Vs bCB3aGljaCB3aWxsIHJlc3VsdAo+ID4gaW4gbXVsdGlwbGUgZHBjZCBvcGVyYXRpb25zLiBTbyB0 aGlzIHBhdGNoIHRyaWVzCj4gPiB0byBzb2x2ZSBib3RoIHRoZXNlIGJ5IGJyaW5naW5nIGFsbCBE UENEIG9wZXJhdGlvbnMKPiA+IGluIG9uZSBzaW5nbGUgZnVuY3Rpb24gYW5kIG1ha2UgaW50ZWxf ZHBfZGV0ZWN0Cj4gPiB1c2UgZXhpc3RpbmcgdmFsdWVzIGluc3RlYWQgb2YgcmVwZWF0aW5nIHNh bWUgc3RlcHMuCj4gPiAKPiA+IFNpZ25lZC1vZmYtYnk6IFNpdmFrdW1hciBUaHVsYXNpbWFuaSA8 c2l2YWt1bWFyLnRodWxhc2ltYW5pQGludGVsLmNvbT4KPiA+IFNpZ25lZC1vZmYtYnk6IFNodWJo YW5naSBTaHJpdmFzdGF2YSA8c2h1YmhhbmdpLnNocml2YXN0YXZhQGludGVsLmNvbT4KPiA+IC0t LQo+ID4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RwLmMgfCAxOSArKysrLS0tLS0tLS0t LS0tLS0tCj4gPiAgMSBmaWxlIGNoYW5nZWQsIDQgaW5zZXJ0aW9ucygrKSwgMTUgZGVsZXRpb25z KC0pCj4gPiAKPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcC5j Cj4gPiBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RwLmMKPiA+IGluZGV4IGEwZmU4Mjcu LjRlNzRjZDYgMTAwNjQ0Cj4gPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcC5j Cj4gPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcC5jCj4gPiBAQCAtNDg4MSw3 ICs0ODgxLDggQEAgaW50ZWxfZHBfZGV0ZWN0KHN0cnVjdCBkcm1fY29ubmVjdG9yICpjb25uZWN0 b3IsIGJvb2wKPiA+IGZvcmNlKQo+ID4gIAkJcmV0dXJuIGNvbm5lY3Rvcl9zdGF0dXNfZGlzY29u bmVjdGVkOwo+ID4gIAl9Cj4gPiAgCj4gPiAtCWludGVsX2RwX2xvbmdfcHVsc2UoaW50ZWxfZHAt PmF0dGFjaGVkX2Nvbm5lY3Rvcik7Cj4gPiArCWlmIChmb3JjZSkKPiA+ICsJCWludGVsX2RwX2xv bmdfcHVsc2UoaW50ZWxfZHAtPmF0dGFjaGVkX2Nvbm5lY3Rvcik7Cj4gPiAgCj4gPiAgCWlmIChp bnRlbF9jb25uZWN0b3ItPmRldGVjdF9lZGlkKQo+ID4gIAkJcmV0dXJuIGNvbm5lY3Rvcl9zdGF0 dXNfY29ubmVjdGVkOwo+ID4gQEAgLTUyMTEsMjEgKzUyMTIsOSBAQCBpbnRlbF9kcF9ocGRfcHVs c2Uoc3RydWN0IGludGVsX2RpZ2l0YWxfcG9ydAo+ID4gKmludGVsX2RpZ19wb3J0LCBib29sIGxv bmdfaHBkKQo+ID4gIAkJLyogaW5kaWNhdGUgdGhhdCB3ZSBuZWVkIHRvIHJlc3RhcnQgbGluayB0 cmFpbmluZyAqLwo+ID4gIAkJaW50ZWxfZHAtPnRyYWluX3NldF92YWxpZCA9IGZhbHNlOwo+ID4g IAo+ID4gLQkJaWYgKCFpbnRlbF9kaWdpdGFsX3BvcnRfY29ubmVjdGVkKGRldl9wcml2LCBpbnRl bF9kaWdfcG9ydCkpCj4gPiAtCQkJZ290byBtc3RfZmFpbDsKPiA+ICsJCWludGVsX2RwX2xvbmdf cHVsc2UoaW50ZWxfZHAtPmF0dGFjaGVkX2Nvbm5lY3Rvcik7Cj4gPiArCQlnb3RvIHB1dF9wb3dl cjsKClRoaXMgc2tpcHMgdGhlIGxpbmUgdGhhdCBzZXRzIHJldCB0byBJUlFfSEFORExFRCwgd2hp Y2ggd2lsbCBjYXVzZSB0aGUgaG90cGx1Zwpjb2RlIHRvICJmYWxsIGJhY2sgdG8gb2xkIHNjaG9v bCBocGQiLgoKQW5kZXIKCj4gPiAgCj4gPiAtCQlpZiAoIWludGVsX2RwX2dldF9kcGNkKGludGVs X2RwKSkgewo+ID4gLQkJCWdvdG8gbXN0X2ZhaWw7Cj4gPiAtCQl9Cj4gCj4gU28gd2UgZG9uJ3Qg Y2FsbCB0aGlzIGZvciBlRFAgYW55bW9yZSBvbiBsb25nIHB1bHNlLCB3aGljaCBJIGFzc3VtZSBp cwo+IGhhcm1sZXNzCj4gc2luY2UgdGhlIGJpdHMgd2UgYXJlIHJlYWRpbmcgZnJvbSBEUENEIHNo b3VsZG4ndCBjaGFuZ2U/Cj4gCj4gPiAtCj4gPiAtCQlpbnRlbF9kcF9wcm9iZV9vdWkoaW50ZWxf ZHApOwo+ID4gLQo+ID4gLQkJaWYgKCFpbnRlbF9kcF9wcm9iZV9tc3QoaW50ZWxfZHApKSB7Cj4g PiAtCQkJZHJtX21vZGVzZXRfbG9jaygmZGV2Cj4gPiAtPm1vZGVfY29uZmlnLmNvbm5lY3Rpb25f bXV0ZXgsIE5VTEwpOwo+ID4gLQkJCWludGVsX2RwX2NoZWNrX2xpbmtfc3RhdHVzKGludGVsX2Rw KTsKPiA+IC0JCQlkcm1fbW9kZXNldF91bmxvY2soJmRldgo+ID4gLT5tb2RlX2NvbmZpZy5jb25u ZWN0aW9uX211dGV4KTsKPiA+IC0JCQlnb3RvIG1zdF9mYWlsOwo+ID4gLQkJfQo+IAo+IEhtbSwg c28gdGhpcyBpcyB3aGVyZSB0aGF0IGh1bmsgZnJvbSBwYXRjaCAxIEkgc2FpZCBzaG91bGQgYmUg YSBzZXBhcmF0ZSBwYXRjaAo+IGNvbWVzIGZyb20uIExvb2tzIGxpa2UgaW4gYmVsb25ncyB0byB0 aGlzIHBhdGNoLgo+IAo+ID4gIAl9IGVsc2Ugewo+ID4gIAkJaWYgKGludGVsX2RwLT5pc19tc3Qp IHsKPiA+ICAJCQlpZiAoaW50ZWxfZHBfY2hlY2tfbXN0X3N0YXR1cyhpbnRlbF9kcCkgPT0gLUVJ TlZBTCkKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50 ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6 Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK