Re: [PATCH] drm/i915: Remove duplicated dpcd write on hsw_psr_enable_sink.

Paulo Zanoni
2015-11-16T16:44:04Z

2015-11-12 20:46 GMT-02:00 Rodrigo Vivi <rodrigo.vivi@intel.com>:
> Commit (89251b17) intended to remove this line and let only one
> DP_PSR_EN_CFG set, but it was wrong and this call is now duplicated
> at the code.
>
> Also "& ~DP_PSR_MAIN_LINK_ACTIVE" doesn't do anything at all. It
> was like that since I introduced this call but probably the idea
> was to be informative and make clear statement that we were not using
> the link standby. So it is better to remove this one here and let
> the code a bit cleaner.
>
> v2: Improve commit message as requested by Paulo.
>

Another side effect not mentioned in the commit message is that now
we're flipping the DP_PSR_ENABLE bit a little later than we were
before, but it looks like this is not a problem.

Reviewed-by: Paulo Zanoni <paulo.r.zanoni@intel.com>

> Cc: Paulo Zanoni <paulo.r.zanoni@intel.com>
> Tested-by: Brian Norris <briannorris@chromium.org>
> Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
> ---
> drivers/gpu/drm/i915/intel_psr.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_psr.c b/drivers/gpu/drm/i915/intel_psr.c
> index e5ae844..e5b3fce 100644
> --- a/drivers/gpu/drm/i915/intel_psr.c
> +++ b/drivers/gpu/drm/i915/intel_psr.c
> @@ -172,9 +172,6 @@ static void hsw_psr_enable_sink(struct intel_dp *intel_dp)
>
> aux_clock_divider = intel_dp->get_aux_clock_divider(intel_dp, 0);
>
> - drm_dp_dpcd_writeb(&intel_dp->aux, DP_PSR_EN_CFG,
> - DP_PSR_ENABLE & ~DP_PSR_MAIN_LINK_ACTIVE);
> -
> /* Enable AUX frame sync at sink */
> if (dev_priv->psr.aux_frame_sync)
> drm_dp_dpcd_writeb(&intel_dp->aux,
> --
> 2.4.3
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx

--
Paulo Zanoni