From: "Vivi, Rodrigo" <rodrigo.vivi@intel.com>
To: "daniel@ffwll.ch" <daniel@ffwll.ch>,
"rodrigo.vivi@gmail.com" <rodrigo.vivi@gmail.com>
Cc: "daniel.vetter@ffwll.ch" <daniel.vetter@ffwll.ch>,
"intel-gfx@lists.freedesktop.org"
<intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH 0/5] Sink CRC stabilization
Date: Wed, 18 Nov 2015 18:46:41 +0000 [thread overview]
Message-ID: <1447872440.15751.103.camel@intel.com> (raw)
In-Reply-To: <20151118145507.GX20799@phenom.ffwll.local>
On Wed, 2015-11-18 at 15:55 +0100, Daniel Vetter wrote:
> On Mon, Nov 16, 2015 at 03:59:15PM +0000, Rodrigo Vivi wrote:
> > Hi Daniel,
> >
> > could you please ignore patch 5 in this series and merge the 4
> > first
> > patches.
>
> I merged an earlier instance of the first 4 patches. Has anything
> changed?
no changes. thanks for merging and sorry for the doubled noise!
> Please double-check the right versions landed in dinq.
just did. thanks!
>
> Thanks, Daniel
>
> >
> > The aux mutex is really unreliable and doesn't help on all SKLs so
> > better
> > to just ignore that.
> >
> > Thanks,
> > Rodrigo.
> >
> > On Thu, Nov 12, 2015 at 11:03 AM Rodrigo Vivi <
> > rodrigo.vivi@gmail.com>
> > wrote:
> >
> > > On Thu, Nov 12, 2015 at 10:56 AM Vivi, Rodrigo <
> > > rodrigo.vivi@intel.com>
> > > wrote:
> > >
> > > > On Thu, 2015-11-12 at 12:17 +0200, Jani Nikula wrote:
> > > > > On Wed, 11 Nov 2015, Rodrigo Vivi <rodrigo.vivi@intel.com>
> > > > > wrote:
> > > > > > Let's start spliting that big series that enables PSR with
> > > > > > this
> > > > > > sink crc
> > > > > > stabilization.
> > > > > >
> > > > > > Also I'm adding Wayne's mutex that stabilizes sink CRC on
> > > > > > Skylake.
> > > > > >
> > > > > > All patches already reviewed and ready to merge.
> > > > >
> > > > > Disagreed on the hw mutex patch.
> > > >
> > > > I wasn't considered it as nacked. But it seems that we have
> > > > more to
> > > > discuss around it.
> > > >
> > > > Although I don't see a reason of blocking a patch that follow
> > > > spec, it
> > > > is reviewed, and it is used to fix a bug, unblock validation
> > > > and only
> > > > used for the particular case that is just used on automated
> > > > validation
> > > > and not broadly to all aux communications.
> > > >
> > >
> > > Oh, now I saw you had comments there on the patch. So please
> > > ignore this
> > > complain and accept my apologies.
> > >
> > >
> > > >
> > > > >
> > > > > BR,
> > > > > Jani.
> > > > >
> > > > > >
> > > > > > Thank you very much Paulo for the review and Thank you
> > > > > > Wayne for
> > > > > > the
> > > > > > SKL aux mutex.
> > > > > >
> > > > > > Thanks,
> > > > > > Rodrigo.
> > > > > >
> > > > > > Boyer, Wayne (1):
> > > > > > drm/i915/skl: implement DP Aux Mutex framework
> > > > > >
> > > > > > Rodrigo Vivi (4):
> > > > > > drm/i915: Allow 1 vblank to let Sink CRC calculation to
> > > > > > start or
> > > > > > stop.
> > > > > > drm/i915: Make Sink crc calculation waiting for counter
> > > > > > to reset.
> > > > > > drm/i915: Stop tracking last calculated Sink CRC.
> > > > > > drm/i915: Rely on TEST_SINK_START instead of tracking
> > > > > > Sink CRC
> > > > > > state
> > > > > > on dev_priv.
> > > > > >
> > > > > > drivers/gpu/drm/i915/i915_drv.h | 1 +
> > > > > > drivers/gpu/drm/i915/i915_reg.h | 5 ++
> > > > > > drivers/gpu/drm/i915/intel_dp.c | 126
> > > > > > +++++++++++++++++++++++++++
> > > > > > ------------
> > > > > > drivers/gpu/drm/i915/intel_drv.h | 7 ---
> > > > > > 4 files changed, 93 insertions(+), 46 deletions(-)
> > > > >
> > > > _______________________________________________
> > > > Intel-gfx mailing list
> > > > Intel-gfx@lists.freedesktop.org
> > > > http://lists.freedesktop.org/mailman/listinfo/intel-gfx
> > > >
> > >
>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
prev parent reply other threads:[~2015-11-18 18:46 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-11 19:05 [PATCH 0/5] Sink CRC stabilization Rodrigo Vivi
2015-11-11 19:05 ` [PATCH 1/5] drm/i915: Allow 1 vblank to let Sink CRC calculation to start or stop Rodrigo Vivi
2015-11-11 19:05 ` [PATCH 2/5] drm/i915: Make Sink crc calculation waiting for counter to reset Rodrigo Vivi
2015-11-11 19:05 ` [PATCH 3/5] drm/i915: Stop tracking last calculated Sink CRC Rodrigo Vivi
2015-11-11 19:05 ` [PATCH 4/5] drm/i915: Rely on TEST_SINK_START instead of tracking Sink CRC state on dev_priv Rodrigo Vivi
2015-11-11 19:05 ` [PATCH 5/5] drm/i915/skl: implement DP Aux Mutex framework Rodrigo Vivi
2015-11-12 0:41 ` [PATCH] drm/i915/skl: Implement " Wayne Boyer
2015-11-12 10:16 ` Jani Nikula
2015-11-12 10:17 ` [PATCH 0/5] Sink CRC stabilization Jani Nikula
2015-11-12 18:56 ` Vivi, Rodrigo
2015-11-12 19:02 ` Rodrigo Vivi
2015-11-16 15:59 ` Rodrigo Vivi
2015-11-18 14:55 ` Daniel Vetter
2015-11-18 18:46 ` Vivi, Rodrigo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1447872440.15751.103.camel@intel.com \
--to=rodrigo.vivi@intel.com \
--cc=daniel.vetter@ffwll.ch \
--cc=daniel@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
--cc=rodrigo.vivi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox