Re: [PATCH i-g-t] Add dmesg capture and dumping to tests and a test for it.

Chris Wilson
2015-11-18T17:33:08Z

On Wed, Nov 18, 2015 at 04:44:20PM +0100, Daniel Vetter wrote:
> On Mon, Nov 16, 2015 at 03:22:23PM +0200, Joonas Lahtinen wrote:
> > Cc: Thomas Wood <thomas.wood@intel.com>
> > Cc: Chris Wilson <chris@chris-wilson.co.uk>
> > Cc: Damien Lespiau <damien.lespiau@intel.com>
> > Signed-off-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
>
> Given that we have all that in piglit already the commit message is a bit
> thin on justification. Why do we need this in igt too? How does this
> interact with the piglit dmesg capture?

It's doesn't interfere with anyone else parsing kmsg/dmesg for
themselves, but it adds very useful functionality to standalone igt.
Which to me is significantly more valuable and I have been patching it
into igt for over a year and wished it was taken more seriously given
the number of incorrect bug reports generated.
-Chris

--
Chris Wilson, Intel Open Source Technology Centre