From mboxrd@z Thu Jan 1 00:00:00 1970 From: Imre Deak Subject: Re: [PATCH] drm/i915/guc: Move wait for GuC out of spinlock/unlock Date: Tue, 24 Nov 2015 15:26:33 +0200 Message-ID: <1448371593.32235.17.camel@intel.com> References: <20151120084542.GU17050@phenom.ffwll.local> <1448319778-29282-1-git-send-email-yu.dai@intel.com> <20151124130410.GW17050@phenom.ffwll.local> Reply-To: imre.deak@intel.com Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTP id D59016E904 for ; Tue, 24 Nov 2015 05:26:35 -0800 (PST) In-Reply-To: <20151124130410.GW17050@phenom.ffwll.local> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Daniel Vetter , yu.dai@intel.com Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gdGksIDIwMTUtMTEtMjQgYXQgMTQ6MDQgKzAxMDAsIERhbmllbCBWZXR0ZXIgd3JvdGU6Cj4g T24gTW9uLCBOb3YgMjMsIDIwMTUgYXQgMDM6MDI6NThQTSAtMDgwMCwgeXUuZGFpQGludGVsLmNv bSB3cm90ZToKPiA+IEZyb206IEFsZXggRGFpIDx5dS5kYWlAaW50ZWwuY29tPgo+ID4gCj4gPiBX aGVuIEd1QyBXb3JrIFF1ZXVlIGlzIGZ1bGwsIGRyaXZlciB3aWxsIHdhaXQgR3VDIGZvciBhdmFs aWFibGUKPiA+IHNwYWNlIGJ5IGRlbGF5aW5nIDFtcy4gVGhlIHdhaXQgbmVlZHMgdG8gYmUgb3V0 IG9mIHNwaW5sb2NraXJxIC8KPiA+IHVubG9jay4gT3RoZXJ3aXNlLCBsb2NrdXAgaGFwcGVucyBi ZWNhdXNlIGppZmZpZXMgd29uJ3QgYmUgdXBkYXRlZAo+ID4gZHVyIHRvIGlycSBpcyBkaXNhYmxl ZC4KPiA+IAo+ID4gSXNzdWUgaXMgZm91bmQgaW4gaWd0L2dlbV9jbG9zZV9yYWNlLgo+ID4gCj4g PiBTaWduZWQtb2ZmLWJ5OiBBbGV4IERhaSA8eXUuZGFpQGludGVsLmNvbT4KPiA+IC0tLQo+ID4g wqBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2d1Y19zdWJtaXNzaW9uLmMgfCAyNyArKysrKysr KysrKysrKysrKy0KPiA+IC0tLS0tLS0tLQo+ID4gwqAxIGZpbGUgY2hhbmdlZCwgMTcgaW5zZXJ0 aW9ucygrKSwgMTAgZGVsZXRpb25zKC0pCj4gPiAKPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dw dS9kcm0vaTkxNS9pOTE1X2d1Y19zdWJtaXNzaW9uLmMKPiA+IGIvZHJpdmVycy9ncHUvZHJtL2k5 MTUvaTkxNV9ndWNfc3VibWlzc2lvbi5jCj4gPiBpbmRleCAwYTZiMDA3Li4xNDE4Mzk3IDEwMDY0 NAo+ID4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9ndWNfc3VibWlzc2lvbi5jCj4g PiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2d1Y19zdWJtaXNzaW9uLmMKPiA+IEBA IC0yMDEsMTAgKzIwMSwxMyBAQCBzdGF0aWMgaW50IGd1Y19yaW5nX2Rvb3JiZWxsKHN0cnVjdAo+ ID4gaTkxNV9ndWNfY2xpZW50ICpnYykKPiA+IMKgCXVuaW9uIGd1Y19kb29yYmVsbF9xdyAqZGI7 Cj4gPiDCoAl2b2lkICpiYXNlOwo+ID4gwqAJaW50IGF0dGVtcHQgPSAyLCByZXQgPSAtRUFHQUlO Owo+ID4gKwl1bnNpZ25lZCBsb25nIGZsYWdzOwo+ID4gwqAKPiA+IMKgCWJhc2UgPSBrbWFwX2F0 b21pYyhpOTE1X2dlbV9vYmplY3RfZ2V0X3BhZ2UoZ2MtCj4gPiA+Y2xpZW50X29iaiwgMCkpOwo+ IAo+IFdlIGRvbid0IG5lZWQga21hcF9hdG9taWMgYW55bW9yZSBoZXJlIG5vdywgc2luY2UgaXQn cyBvdXRzaWRlIG9mIHRoZQo+IHNwaW5sb2NrLgo+IAo+ID4gwqAJZGVzYyA9IGJhc2UgKyBnYy0+ cHJvY19kZXNjX29mZnNldDsKPiA+IMKgCj4gPiArCXNwaW5fbG9ja19pcnFzYXZlKCZnYy0+d3Ff bG9jaywgZmxhZ3MpOwo+IAo+IFBsZWFzZSBkb24ndCB1c2UgdGhlIHN1cGVyLWdlbmVyaWMgX2ly cXNhdmUuIEl0J3MgZXhwZW5zaXZlIGFuZAo+IHJlc3VsdHMgaW4KPiBmcmFnaWxlIGNvZGUgd2hl biBzb21lb25lIGFjY2lkZW50YWxseSByZXVzZXMgc29tZXRoaW5nIGluIGFuCj4gaW50ZXJydXB0 Cj4gaGFuZGxlciB0aGF0IHdhcyBuZXZlciBtZWFudCB0byBydW4gaW4gdGhhdCBjb250ZXh0Lgo+ IAo+IEluc3RlYWQgcGxlYXNlIHVzZSB0aGUgbW9zdCBzcGVjaWZpYyBmdW50aW9uOgo+IC0gc3Bp bl9sb2NrIGlmIHlvdSBrbm93IHlvdSBhcmUgaW4gaXJxIGNvbnRleHQuCj4gLSBzaXBuX2xvY2tf aXJxIGlmIHlvdSBrbm93IHlvdSBhcmUgbm90LgoKUmlnaHQsIGFuZCBzaW1wbHkgc3Bpbl9sb2Nr KCkgaWYgdGhlIGxvY2sgaXMgbm90IHRha2VuIGluIElSUSBjb250ZXh0CmV2ZXIuCgo+IC0gc3Bp bl9sb2NrX2lycXNhdmUgc2hvdWxkIGJlIGEgYmlnIHdhcm5pbmcgc2lnbiB0aGF0IHlvdXIgY29k ZSBoYXMKPiDCoCBsYXllcmluZyBpc3N1ZXMuCj4gCj4gUGxlYXNlIGF1ZGl0IHRoZSBlbnRpcmUg Z3VjIGNvZGUgZm9yIHRoZSBhYm92ZSB0d28gaXNzdWVzLgoKQWdyZWVkLCBpdCBsb29rcyBpbmNv bnNpc3RlbnQgYXRtOiB3ZSBkbyBzcGluX2xvY2sod3FfbG9jaykgZnJvbQpkZWJ1Z2ZzIGFuZCBz cGluX2xvY2tfaXJxKHdxX2xvY2spIGZyb23CoGk5MTVfZ3VjX3N1Ym1pdCgpLiBOZWl0aGVyIG9m CnRoZW0gYXJlIGNhbGxlZCBmcm9tIElSUSBjb250ZXh0IEFGQUlDUywgaW4gd2hpY2ggY2FzZSBh IHNpbXBsZQpzcGluX2xvY2soKSB3b3VsZCBkby4KCi0tSW1yZQoKPiA+ICsKPiA+IMKgCS8qIFVw ZGF0ZSB0aGUgdGFpbCBzbyBpdCBpcyB2aXNpYmxlIHRvIEd1QyAqLwo+ID4gwqAJZGVzYy0+dGFp bCA9IGdjLT53cV90YWlsOwo+ID4gwqAKPiA+IEBAIC0yNDgsNyArMjUxLDEwIEBAIHN0YXRpYyBp bnQgZ3VjX3JpbmdfZG9vcmJlbGwoc3RydWN0Cj4gPiBpOTE1X2d1Y19jbGllbnQgKmdjKQo+ID4g wqAJCQlkYl9leGMuY29va2llID0gMTsKPiA+IMKgCX0KPiA+IMKgCj4gPiArCXNwaW5fdW5sb2Nr X2lycXJlc3RvcmUoJmdjLT53cV9sb2NrLCBmbGFncyk7Cj4gPiArCj4gPiDCoAlrdW5tYXBfYXRv bWljKGJhc2UpOwo+ID4gKwo+ID4gwqAJcmV0dXJuIHJldDsKPiA+IMKgfQo+ID4gwqAKPiA+IEBA IC00ODcsMTYgKzQ5MywxNiBAQCBzdGF0aWMgaW50IGd1Y19nZXRfd29ya3F1ZXVlX3NwYWNlKHN0 cnVjdAo+ID4gaTkxNV9ndWNfY2xpZW50ICpnYywgdTMyICpvZmZzZXQpCj4gPiDCoAlzdHJ1Y3Qg Z3VjX3Byb2Nlc3NfZGVzYyAqZGVzYzsKPiA+IMKgCXZvaWQgKmJhc2U7Cj4gPiDCoAl1MzIgc2l6 ZSA9IHNpemVvZihzdHJ1Y3QgZ3VjX3dxX2l0ZW0pOwo+ID4gLQlpbnQgcmV0ID0gMCwgdGltZW91 dF9jb3VudGVyID0gMjAwOwo+ID4gKwlpbnQgcmV0ID0gLUVUSU1FRE9VVCwgdGltZW91dF9jb3Vu dGVyID0gMjAwOwo+ID4gKwl1bnNpZ25lZCBsb25nIGZsYWdzOwo+ID4gwqAKPiA+IMKgCWJhc2Ug PSBrbWFwX2F0b21pYyhpOTE1X2dlbV9vYmplY3RfZ2V0X3BhZ2UoZ2MtCj4gPiA+Y2xpZW50X29i aiwgMCkpOwo+ID4gwqAJZGVzYyA9IGJhc2UgKyBnYy0+cHJvY19kZXNjX29mZnNldDsKPiA+IMKg Cj4gPiDCoAl3aGlsZSAodGltZW91dF9jb3VudGVyLS0gPiAwKSB7Cj4gPiAtCQlyZXQgPSB3YWl0 X2Zvcl9hdG9taWMoQ0lSQ19TUEFDRShnYy0+d3FfdGFpbCwKPiA+IGRlc2MtPmhlYWQsCj4gPiAt CQkJCWdjLT53cV9zaXplKSA+PSBzaXplLCAxKTsKPiA+ICsJCXNwaW5fbG9ja19pcnFzYXZlKCZn Yy0+d3FfbG9jaywgZmxhZ3MpOwo+ID4gwqAKPiA+IC0JCWlmICghcmV0KSB7Cj4gPiArCQlpZiAo Q0lSQ19TUEFDRShnYy0+d3FfdGFpbCwgZGVzYy0+aGVhZCwgZ2MtCj4gPiA+d3Ffc2l6ZSkgPj0g c2l6ZSkgewo+ID4gwqAJCQkqb2Zmc2V0ID0gZ2MtPndxX3RhaWw7Cj4gPiDCoAo+ID4gwqAJCQkv KiBhZHZhbmNlIHRoZSB0YWlsIGZvciBuZXh0IHdvcmtxdWV1ZQo+ID4gaXRlbSAqLwo+ID4gQEAg LTUwNSw3ICs1MTEsMTMgQEAgc3RhdGljIGludCBndWNfZ2V0X3dvcmtxdWV1ZV9zcGFjZShzdHJ1 Y3QKPiA+IGk5MTVfZ3VjX2NsaWVudCAqZ2MsIHUzMiAqb2Zmc2V0KQo+ID4gwqAKPiA+IMKgCQkJ LyogdGhpcyB3aWxsIGJyZWFrIHRoZSBsb29wICovCj4gPiDCoAkJCXRpbWVvdXRfY291bnRlciA9 IDA7Cj4gPiArCQkJcmV0ID0gMDsKPiA+IMKgCQl9Cj4gPiArCj4gPiArCQlzcGluX3VubG9ja19p cnFyZXN0b3JlKCZnYy0+d3FfbG9jaywgZmxhZ3MpOwo+ID4gKwo+ID4gKwkJaWYgKHRpbWVvdXRf Y291bnRlcikKPiA+ICsJCQl1c2xlZXBfcmFuZ2UoMTAwMCwgMjAwMCk7Cj4gCj4gRG8gd2UgcmVh bGx5IG5vdCBoYXZlIGEgaW50ZXJydXB0L3NpZ25hbCBmcm9tIHRoZSBndWMgd2hlbiBpdCBoYXMK PiBjbGVhcmVkCj4gdXAgc29tZSBzcGFjZT8KPiAKPiA+IMKgCX07Cj4gPiDCoAo+ID4gwqAJa3Vu bWFwX2F0b21pYyhiYXNlKTsKPiA+IEBAIC01OTcsMTkgKzYwOSwxNyBAQCBpbnQgaTkxNV9ndWNf c3VibWl0KHN0cnVjdCBpOTE1X2d1Y19jbGllbnQKPiA+ICpjbGllbnQsCj4gPiDCoHsKPiA+IMKg CXN0cnVjdCBpbnRlbF9ndWMgKmd1YyA9IGNsaWVudC0+Z3VjOwo+ID4gwqAJZW51bSBpbnRlbF9y aW5nX2lkIHJpbmdfaWQgPSBycS0+cmluZy0+aWQ7Cj4gPiAtCXVuc2lnbmVkIGxvbmcgZmxhZ3M7 Cj4gPiDCoAlpbnQgcV9yZXQsIGJfcmV0Owo+ID4gwqAKPiA+IMKgCS8qIE5lZWQgdGhpcyBiZWNh dXNlIG9mIHRoZSBkZWZlcnJlZCBwaW4gY3R4IGFuZCByaW5nICovCj4gPiDCoAkvKiBTaGFsbCB3 ZSBtb3ZlIHRoaXMgcmlnaHQgYWZ0ZXIgcmluZyBpcyBwaW5uZWQ/ICovCj4gPiDCoAlscl9jb250 ZXh0X3VwZGF0ZShycSk7Cj4gPiDCoAo+ID4gLQlzcGluX2xvY2tfaXJxc2F2ZSgmY2xpZW50LT53 cV9sb2NrLCBmbGFncyk7Cj4gPiAtCj4gPiDCoAlxX3JldCA9IGd1Y19hZGRfd29ya3F1ZXVlX2l0 ZW0oY2xpZW50LCBycSk7Cj4gPiDCoAlpZiAocV9yZXQgPT0gMCkKPiA+IMKgCQliX3JldCA9IGd1 Y19yaW5nX2Rvb3JiZWxsKGNsaWVudCk7Cj4gPiDCoAo+ID4gKwlzcGluX2xvY2soJmd1Yy0+aG9z dDJndWNfbG9jayk7Cj4gCj4gU28gYXQgZmlyc3QgSSB0aG91Z2h0IHRoZXJlJ3MgYSByYWNlIG5v dywgYnV0IHRoZW4gSSBsb29rZWQgYXQgd2hhdAo+IGhvc3QyZ3VjIGFuZCB3cV9sb2NrIHByb3Rl Y3QuIEl0IHNlZW1zIGxpa2UgdGhlIG9ubHkgdGhpbmcgdGhleSBkbyBpcwo+IHByb3RlY3QgYWdh aW5zdCBkZWJ1Z2ZzLCBhbGwgdGhlIHJlYWwgcHJvdGVjdGlvbiBhZ2FpbnN0IGluY29uc2lzdGVu dAo+IHN0YXRlIGlzIGRvbmUgdGhyb3VnaCBkZXYtPnN0cnVjdF9tdXRleC4KPiAKPiBDYW4ndCB3 ZSBqdXN0IHJpcCBvdXQgYWxsIHRoaXMgc3BpbmxvY2sgYnVzaW5lc3MgZnJvbSB0aGUgZ3VjIGNv ZGU/Cj4gSXQgd291bGQgYmUgZWFzaWVyIHRoYW4gZml4aW5nIHVwIHRoZSByYWNlcyBpbiBoZXJl LgoKCgo+IC1EYW5pZWwKPiAKPiA+IMKgCWNsaWVudC0+c3VibWlzc2lvbnNbcmluZ19pZF0gKz0g MTsKPiA+IMKgCWlmIChxX3JldCkgewo+ID4gwqAJCWNsaWVudC0+cV9mYWlsICs9IDE7Cj4gPiBA QCAtNjIwLDkgKzYzMCw2IEBAIGludCBpOTE1X2d1Y19zdWJtaXQoc3RydWN0IGk5MTVfZ3VjX2Ns aWVudAo+ID4gKmNsaWVudCwKPiA+IMKgCX0gZWxzZSB7Cj4gPiDCoAkJY2xpZW50LT5yZXRjb2Rl ID0gMDsKPiA+IMKgCX0KPiA+IC0Jc3Bpbl91bmxvY2tfaXJxcmVzdG9yZSgmY2xpZW50LT53cV9s b2NrLCBmbGFncyk7Cj4gPiAtCj4gPiAtCXNwaW5fbG9jaygmZ3VjLT5ob3N0Mmd1Y19sb2NrKTsK PiA+IMKgCWd1Yy0+c3VibWlzc2lvbnNbcmluZ19pZF0gKz0gMTsKPiA+IMKgCWd1Yy0+bGFzdF9z ZXFub1tyaW5nX2lkXSA9IHJxLT5zZXFubzsKPiA+IMKgCXNwaW5fdW5sb2NrKCZndWMtPmhvc3Qy Z3VjX2xvY2spOwo+ID4gLS0gCj4gPiAyLjUuMAo+ID4gCj4gCl9fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwt Z2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21h aWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==