From mboxrd@z Thu Jan 1 00:00:00 1970 From: Imre Deak Subject: Re: [PATCH] drm/i915/guc: Move wait for GuC out of spinlock/unlock Date: Tue, 24 Nov 2015 19:05:47 +0200 Message-ID: <1448384747.32235.27.camel@intel.com> References: <20151120084542.GU17050@phenom.ffwll.local> <1448319778-29282-1-git-send-email-yu.dai@intel.com> <20151124130410.GW17050@phenom.ffwll.local> <1448371593.32235.17.camel@intel.com> <565497B5.8070103@intel.com> Reply-To: imre.deak@intel.com Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTP id E54247206E for ; Tue, 24 Nov 2015 09:07:22 -0800 (PST) In-Reply-To: <565497B5.8070103@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Yu Dai , Daniel Vetter Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gdGksIDIwMTUtMTEtMjQgYXQgMDk6MDAgLTA4MDAsIFl1IERhaSB3cm90ZToKPiAKPiBPbiAx MS8yNC8yMDE1IDA1OjI2IEFNLCBJbXJlIERlYWsgd3JvdGU6Cj4gPiBPbiB0aSwgMjAxNS0xMS0y NCBhdCAxNDowNCArMDEwMCwgRGFuaWVsIFZldHRlciB3cm90ZToKPiA+ID4gT24gTW9uLCBOb3Yg MjMsIDIwMTUgYXQgMDM6MDI6NThQTSAtMDgwMCwgeXUuZGFpQGludGVsLmNvbSB3cm90ZToKPiA+ ID4gPiBGcm9tOiBBbGV4IERhaSA8eXUuZGFpQGludGVsLmNvbT4KPiA+ID4gPiAKPiA+ID4gPiBX aGVuIEd1QyBXb3JrIFF1ZXVlIGlzIGZ1bGwsIGRyaXZlciB3aWxsIHdhaXQgR3VDIGZvciBhdmFs aWFibGUKPiA+ID4gPiBzcGFjZSBieSBkZWxheWluZyAxbXMuIFRoZSB3YWl0IG5lZWRzIHRvIGJl IG91dCBvZiBzcGlubG9ja2lycQo+ID4gPiA+IC8KPiA+ID4gPiB1bmxvY2suIE90aGVyd2lzZSwg bG9ja3VwIGhhcHBlbnMgYmVjYXVzZSBqaWZmaWVzIHdvbid0IGJlCj4gPiA+ID4gdXBkYXRlZAo+ ID4gPiA+IGR1ciB0byBpcnEgaXMgZGlzYWJsZWQuCj4gPiA+ID4gCj4gPiA+ID4gSXNzdWUgaXMg Zm91bmQgaW4gaWd0L2dlbV9jbG9zZV9yYWNlLgo+ID4gPiA+IAo+ID4gPiA+IFNpZ25lZC1vZmYt Ynk6IEFsZXggRGFpIDx5dS5kYWlAaW50ZWwuY29tPgo+ID4gPiA+IC0tLQo+ID4gPiA+IMKgZHJp dmVycy9ncHUvZHJtL2k5MTUvaTkxNV9ndWNfc3VibWlzc2lvbi5jIHwgMjcKPiA+ID4gPiArKysr KysrKysrKysrKysrKy0KPiA+ID4gPiAtLS0tLS0tLS0KPiA+ID4gPiDCoDEgZmlsZSBjaGFuZ2Vk LCAxNyBpbnNlcnRpb25zKCspLCAxMCBkZWxldGlvbnMoLSkKPiA+ID4gPiAKPiA+ID4gPiBkaWZm IC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9ndWNfc3VibWlzc2lvbi5jCj4gPiA+ ID4gYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2d1Y19zdWJtaXNzaW9uLmMKPiA+ID4gPiBp bmRleCAwYTZiMDA3Li4xNDE4Mzk3IDEwMDY0NAo+ID4gPiA+IC0tLSBhL2RyaXZlcnMvZ3B1L2Ry bS9pOTE1L2k5MTVfZ3VjX3N1Ym1pc3Npb24uYwo+ID4gPiA+ICsrKyBiL2RyaXZlcnMvZ3B1L2Ry bS9pOTE1L2k5MTVfZ3VjX3N1Ym1pc3Npb24uYwo+ID4gPiA+IEBAIC0yMDEsMTAgKzIwMSwxMyBA QCBzdGF0aWMgaW50IGd1Y19yaW5nX2Rvb3JiZWxsKHN0cnVjdAo+ID4gPiA+IGk5MTVfZ3VjX2Ns aWVudCAqZ2MpCj4gPiA+ID4gwqAJdW5pb24gZ3VjX2Rvb3JiZWxsX3F3ICpkYjsKPiA+ID4gPiDC oAl2b2lkICpiYXNlOwo+ID4gPiA+IMKgCWludCBhdHRlbXB0ID0gMiwgcmV0ID0gLUVBR0FJTjsK PiA+ID4gPiArCXVuc2lnbmVkIGxvbmcgZmxhZ3M7Cj4gPiA+ID4gCj4gPiA+ID4gwqAJYmFzZSA9 IGttYXBfYXRvbWljKGk5MTVfZ2VtX29iamVjdF9nZXRfcGFnZShnYy0KPiA+ID4gPiA+IGNsaWVu dF9vYmosIDApKTsKPiA+ID4gCj4gPiA+IFdlIGRvbid0IG5lZWQga21hcF9hdG9taWMgYW55bW9y ZSBoZXJlIG5vdywgc2luY2UgaXQncyBvdXRzaWRlIG9mCj4gPiA+IHRoZQo+ID4gPiBzcGlubG9j ay4KPiA+ID4gCj4gPiA+ID4gwqAJZGVzYyA9IGJhc2UgKyBnYy0+cHJvY19kZXNjX29mZnNldDsK PiA+ID4gPiAKPiA+ID4gPiArCXNwaW5fbG9ja19pcnFzYXZlKCZnYy0+d3FfbG9jaywgZmxhZ3Mp Owo+ID4gPiAKPiA+ID4gUGxlYXNlIGRvbid0IHVzZSB0aGUgc3VwZXItZ2VuZXJpYyBfaXJxc2F2 ZS4gSXQncyBleHBlbnNpdmUgYW5kCj4gPiA+IHJlc3VsdHMgaW4KPiA+ID4gZnJhZ2lsZSBjb2Rl IHdoZW4gc29tZW9uZSBhY2NpZGVudGFsbHkgcmV1c2VzIHNvbWV0aGluZyBpbiBhbgo+ID4gPiBp bnRlcnJ1cHQKPiA+ID4gaGFuZGxlciB0aGF0IHdhcyBuZXZlciBtZWFudCB0byBydW4gaW4gdGhh dCBjb250ZXh0Lgo+ID4gPiAKPiA+ID4gSW5zdGVhZCBwbGVhc2UgdXNlIHRoZSBtb3N0IHNwZWNp ZmljIGZ1bnRpb246Cj4gPiA+IC0gc3Bpbl9sb2NrIGlmIHlvdSBrbm93IHlvdSBhcmUgaW4gaXJx IGNvbnRleHQuCj4gPiA+IC0gc2lwbl9sb2NrX2lycSBpZiB5b3Uga25vdyB5b3UgYXJlIG5vdC4K PiA+IAo+ID4gUmlnaHQsIGFuZCBzaW1wbHkgc3Bpbl9sb2NrKCkgaWYgdGhlIGxvY2sgaXMgbm90 IHRha2VuIGluIElSUQo+ID4gY29udGV4dAo+ID4gZXZlci4KPiAKPiBUaGlzIGlzIG5vdCBpbiBJ UlEgY29udGV4dC4gU28gSSB3aWxsIHVzZSBzcGluX2xvY2tfaXJxIGluc3RlYWQuCgpZb3UgY2Fu IGp1c3QgdXNlIHNwaW5fbG9jaygpLiBzcGluX2xvY2tfaXJxKCkgbWFrZXMgb25seSBzZW5zZSBp ZiB5b3UKdGFrZSB0aGUgbG9jayBpbiBJUlEgY29udGV4dCB0b28sIHdoaWNoIGlzIG5vdCB0aGUg Y2FzZS4KCj4gPiA+IC0gc3Bpbl9sb2NrX2lycXNhdmUgc2hvdWxkIGJlIGEgYmlnIHdhcm5pbmcg c2lnbiB0aGF0IHlvdXIgY29kZQo+ID4gPiBoYXMKPiA+ID4gwqAgbGF5ZXJpbmcgaXNzdWVzLgo+ ID4gPiAKPiA+ID4gUGxlYXNlIGF1ZGl0IHRoZSBlbnRpcmUgZ3VjIGNvZGUgZm9yIHRoZSBhYm92 ZSB0d28gaXNzdWVzLgo+ID4gCj4gPiBBZ3JlZWQsIGl0IGxvb2tzIGluY29uc2lzdGVudCBhdG06 IHdlIGRvIHNwaW5fbG9jayh3cV9sb2NrKSBmcm9tCj4gPiBkZWJ1Z2ZzIGFuZCBzcGluX2xvY2tf aXJxKHdxX2xvY2spIGZyb20gaTkxNV9ndWNfc3VibWl0KCkuIE5laXRoZXIKPiA+IG9mCj4gPiB0 aGVtIGFyZSBjYWxsZWQgZnJvbSBJUlEgY29udGV4dCBBRkFJQ1MsIGluIHdoaWNoIGNhc2UgYSBz aW1wbGUKPiA+IHNwaW5fbG9jaygpIHdvdWxkIGRvLgo+ID4gCj4gPiAtLUltcmUKPiA+IAo+ID4g PiA+ICsKPiA+ID4gPiDCoAkvKiBVcGRhdGUgdGhlIHRhaWwgc28gaXQgaXMgdmlzaWJsZSB0byBH dUMgKi8KPiA+ID4gPiDCoAlkZXNjLT50YWlsID0gZ2MtPndxX3RhaWw7Cj4gPiA+ID4gCj4gPiA+ ID4gQEAgLTI0OCw3ICsyNTEsMTAgQEAgc3RhdGljIGludCBndWNfcmluZ19kb29yYmVsbChzdHJ1 Y3QKPiA+ID4gPiBpOTE1X2d1Y19jbGllbnQgKmdjKQo+ID4gPiA+IMKgCQkJZGJfZXhjLmNvb2tp ZSA9IDE7Cj4gPiA+ID4gwqAJfQo+ID4gPiA+IAo+ID4gPiA+ICsJc3Bpbl91bmxvY2tfaXJxcmVz dG9yZSgmZ2MtPndxX2xvY2ssIGZsYWdzKTsKPiA+ID4gPiArCj4gPiA+ID4gwqAJa3VubWFwX2F0 b21pYyhiYXNlKTsKPiA+ID4gPiArCj4gPiA+ID4gwqAJcmV0dXJuIHJldDsKPiA+ID4gPiDCoH0K PiA+ID4gPiAKPiA+ID4gPiBAQCAtNDg3LDE2ICs0OTMsMTYgQEAgc3RhdGljIGludCBndWNfZ2V0 X3dvcmtxdWV1ZV9zcGFjZShzdHJ1Y3QKPiA+ID4gPiBpOTE1X2d1Y19jbGllbnQgKmdjLCB1MzIg Km9mZnNldCkKPiA+ID4gPiDCoAlzdHJ1Y3QgZ3VjX3Byb2Nlc3NfZGVzYyAqZGVzYzsKPiA+ID4g PiDCoAl2b2lkICpiYXNlOwo+ID4gPiA+IMKgCXUzMiBzaXplID0gc2l6ZW9mKHN0cnVjdCBndWNf d3FfaXRlbSk7Cj4gPiA+ID4gLQlpbnQgcmV0ID0gMCwgdGltZW91dF9jb3VudGVyID0gMjAwOwo+ ID4gPiA+ICsJaW50IHJldCA9IC1FVElNRURPVVQsIHRpbWVvdXRfY291bnRlciA9IDIwMDsKPiA+ ID4gPiArCXVuc2lnbmVkIGxvbmcgZmxhZ3M7Cj4gPiA+ID4gCj4gPiA+ID4gwqAJYmFzZSA9IGtt YXBfYXRvbWljKGk5MTVfZ2VtX29iamVjdF9nZXRfcGFnZShnYy0KPiA+ID4gPiA+IGNsaWVudF9v YmosIDApKTsKPiA+ID4gPiDCoAlkZXNjID0gYmFzZSArIGdjLT5wcm9jX2Rlc2Nfb2Zmc2V0Owo+ ID4gPiA+IAo+ID4gPiA+IMKgCXdoaWxlICh0aW1lb3V0X2NvdW50ZXItLSA+IDApIHsKPiA+ID4g PiAtCQlyZXQgPSB3YWl0X2Zvcl9hdG9taWMoQ0lSQ19TUEFDRShnYy0+d3FfdGFpbCwKPiA+ID4g PiBkZXNjLT5oZWFkLAo+ID4gPiA+IC0JCQkJZ2MtPndxX3NpemUpID49IHNpemUsIDEpOwo+ID4g PiA+ICsJCXNwaW5fbG9ja19pcnFzYXZlKCZnYy0+d3FfbG9jaywgZmxhZ3MpOwo+ID4gPiA+IAo+ ID4gPiA+IC0JCWlmICghcmV0KSB7Cj4gPiA+ID4gKwkJaWYgKENJUkNfU1BBQ0UoZ2MtPndxX3Rh aWwsIGRlc2MtPmhlYWQsIGdjLQo+ID4gPiA+ID4gd3Ffc2l6ZSkgPj0gc2l6ZSkgewo+ID4gPiA+ IMKgCQkJKm9mZnNldCA9IGdjLT53cV90YWlsOwo+ID4gPiA+IAo+ID4gPiA+IMKgCQkJLyogYWR2 YW5jZSB0aGUgdGFpbCBmb3IgbmV4dCB3b3JrcXVldWUKPiA+ID4gPiBpdGVtICovCj4gPiA+ID4g QEAgLTUwNSw3ICs1MTEsMTMgQEAgc3RhdGljIGludCBndWNfZ2V0X3dvcmtxdWV1ZV9zcGFjZShz dHJ1Y3QKPiA+ID4gPiBpOTE1X2d1Y19jbGllbnQgKmdjLCB1MzIgKm9mZnNldCkKPiA+ID4gPiAK PiA+ID4gPiDCoAkJCS8qIHRoaXMgd2lsbCBicmVhayB0aGUgbG9vcCAqLwo+ID4gPiA+IMKgCQkJ dGltZW91dF9jb3VudGVyID0gMDsKPiA+ID4gPiArCQkJcmV0ID0gMDsKPiA+ID4gPiDCoAkJfQo+ ID4gPiA+ICsKPiA+ID4gPiArCQlzcGluX3VubG9ja19pcnFyZXN0b3JlKCZnYy0+d3FfbG9jaywg ZmxhZ3MpOwo+ID4gPiA+ICsKPiA+ID4gPiArCQlpZiAodGltZW91dF9jb3VudGVyKQo+ID4gPiA+ ICsJCQl1c2xlZXBfcmFuZ2UoMTAwMCwgMjAwMCk7Cj4gPiA+IAo+ID4gPiBEbyB3ZSByZWFsbHkg bm90IGhhdmUgYSBpbnRlcnJ1cHQvc2lnbmFsIGZyb20gdGhlIGd1YyB3aGVuIGl0IGhhcwo+ID4g PiBjbGVhcmVkCj4gPiA+IHVwIHNvbWUgc3BhY2U/Cj4gPiA+IAo+IAo+IFRoaXMgaXMgbm90IGlt cGxlbWVudGVkIGluIGZ3IGFsdGhvdWdoIEkgdGhpbmsgaXQgY291bGQgYmUgZG9uZQo+IHRocm91 Z2ggCj4gdGhlIGd1YyB0byBob3N0IGludGVycnVwdC4gSSBhbSB3b3JyeSBhYm91dCB0aGF0IGlm IHdlIGltcGxlbWVudAo+IHRoaXMsIAo+IGl0IHdpbGwgZW5kIHVwIHdpdGggZHJpdmVyIGhhbmRs ZXMgdG9vIG1hbnkgaW50ZXJydXB0cyAobWF5YmUgc2FtZSAKPiBhbW91bnQgb2YgY29udGV4dCBz d2l0Y2gpLiBIb3dldmVyLCBpZGVhbGx5IHdlIGRvbid0IHdhbnQgdG8gaGFuZGxlIAo+IGludGVy cnVwdHMgYXQgYWxsLgo+ID4gPiA+IMKgCX07Cj4gPiA+ID4gCj4gPiA+ID4gwqAJa3VubWFwX2F0 b21pYyhiYXNlKTsKPiA+ID4gPiBAQCAtNTk3LDE5ICs2MDksMTcgQEAgaW50IGk5MTVfZ3VjX3N1 Ym1pdChzdHJ1Y3QKPiA+ID4gPiBpOTE1X2d1Y19jbGllbnQKPiA+ID4gPiAqY2xpZW50LAo+ID4g PiA+IMKgewo+ID4gPiA+IMKgCXN0cnVjdCBpbnRlbF9ndWMgKmd1YyA9IGNsaWVudC0+Z3VjOwo+ ID4gPiA+IMKgCWVudW0gaW50ZWxfcmluZ19pZCByaW5nX2lkID0gcnEtPnJpbmctPmlkOwo+ID4g PiA+IC0JdW5zaWduZWQgbG9uZyBmbGFnczsKPiA+ID4gPiDCoAlpbnQgcV9yZXQsIGJfcmV0Owo+ ID4gPiA+IAo+ID4gPiA+IMKgCS8qIE5lZWQgdGhpcyBiZWNhdXNlIG9mIHRoZSBkZWZlcnJlZCBw aW4gY3R4IGFuZCByaW5nCj4gPiA+ID4gKi8KPiA+ID4gPiDCoAkvKiBTaGFsbCB3ZSBtb3ZlIHRo aXMgcmlnaHQgYWZ0ZXIgcmluZyBpcyBwaW5uZWQ/ICovCj4gPiA+ID4gwqAJbHJfY29udGV4dF91 cGRhdGUocnEpOwo+ID4gPiA+IAo+ID4gPiA+IC0Jc3Bpbl9sb2NrX2lycXNhdmUoJmNsaWVudC0+ d3FfbG9jaywgZmxhZ3MpOwo+ID4gPiA+IC0KPiA+ID4gPiDCoAlxX3JldCA9IGd1Y19hZGRfd29y a3F1ZXVlX2l0ZW0oY2xpZW50LCBycSk7Cj4gPiA+ID4gwqAJaWYgKHFfcmV0ID09IDApCj4gPiA+ ID4gwqAJCWJfcmV0ID0gZ3VjX3JpbmdfZG9vcmJlbGwoY2xpZW50KTsKPiA+ID4gPiAKPiA+ID4g PiArCXNwaW5fbG9jaygmZ3VjLT5ob3N0Mmd1Y19sb2NrKTsKPiA+ID4gCj4gPiA+IFNvIGF0IGZp cnN0IEkgdGhvdWdodCB0aGVyZSdzIGEgcmFjZSBub3csIGJ1dCB0aGVuIEkgbG9va2VkIGF0Cj4g PiA+IHdoYXQKPiA+ID4gaG9zdDJndWMgYW5kIHdxX2xvY2sgcHJvdGVjdC4gSXQgc2VlbXMgbGlr ZSB0aGUgb25seSB0aGluZyB0aGV5Cj4gPiA+IGRvIGlzCj4gPiA+IHByb3RlY3QgYWdhaW5zdCBk ZWJ1Z2ZzLCBhbGwgdGhlIHJlYWwgcHJvdGVjdGlvbiBhZ2FpbnN0Cj4gPiA+IGluY29uc2lzdGVu dAo+ID4gPiBzdGF0ZSBpcyBkb25lIHRocm91Z2ggZGV2LT5zdHJ1Y3RfbXV0ZXguCj4gPiA+IAo+ ID4gPiBDYW4ndCB3ZSBqdXN0IHJpcCBvdXQgYWxsIHRoaXMgc3BpbmxvY2sgYnVzaW5lc3MgZnJv bSB0aGUgZ3VjCj4gPiA+IGNvZGU/Cj4gPiA+IEl0IHdvdWxkIGJlIGVhc2llciB0aGFuIGZpeGlu ZyB1cCB0aGUgcmFjZXMgaW4gaGVyZS4KPiA+IAo+ID4gCj4gCj4gWWVzLCBob3N0Mmd1YyBsb2Nr IGNhbiBiZSBkb25lIHRocm91Z2ggZGV2LT5zdHJ1Y3RfbXV0ZXguIEJ1dAo+IGRlZmluaXRlbHkg Cj4gd2UgZG9uJ3Qgd2FudCB0byBpbnRlcnJ1cHQgdGhlIHByb2Nlc3Mgd2hlbiBkcml2ZXIgcHJv Z3JhbSBndWMgd29yayAKPiBxdWV1ZSBhbmQgcmluZyB0aGUgZG9vciBiZWxsLgo+ID4gPiAtRGFu aWVsCj4gPiA+IAo+ID4gPiA+IMKgCWNsaWVudC0+c3VibWlzc2lvbnNbcmluZ19pZF0gKz0gMTsK PiA+ID4gPiDCoAlpZiAocV9yZXQpIHsKPiA+ID4gPiDCoAkJY2xpZW50LT5xX2ZhaWwgKz0gMTsK PiA+ID4gPiBAQCAtNjIwLDkgKzYzMCw2IEBAIGludCBpOTE1X2d1Y19zdWJtaXQoc3RydWN0IGk5 MTVfZ3VjX2NsaWVudAo+ID4gPiA+ICpjbGllbnQsCj4gPiA+ID4gwqAJfSBlbHNlIHsKPiA+ID4g PiDCoAkJY2xpZW50LT5yZXRjb2RlID0gMDsKPiA+ID4gPiDCoAl9Cj4gPiA+ID4gLQlzcGluX3Vu bG9ja19pcnFyZXN0b3JlKCZjbGllbnQtPndxX2xvY2ssIGZsYWdzKTsKPiA+ID4gPiAtCj4gPiA+ ID4gLQlzcGluX2xvY2soJmd1Yy0+aG9zdDJndWNfbG9jayk7Cj4gPiA+ID4gwqAJZ3VjLT5zdWJt aXNzaW9uc1tyaW5nX2lkXSArPSAxOwo+ID4gPiA+IMKgCWd1Yy0+bGFzdF9zZXFub1tyaW5nX2lk XSA9IHJxLT5zZXFubzsKPiA+ID4gPiDCoAlzcGluX3VubG9jaygmZ3VjLT5ob3N0Mmd1Y19sb2Nr KTsKPiA+ID4gPiAtLQo+ID4gPiA+IDIuNS4wCj4gPiA+ID4gCj4gPiA+IAo+IApfX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBs aXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cDovL2xpc3RzLmZyZWVkZXNr dG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=