From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ander Conselvan De Oliveira Subject: Re: [PATCH 02/12] drm/i915: Calculate watermark related members in the crtc_state, v3. Date: Wed, 25 Nov 2015 11:22:59 +0200 Message-ID: <1448443379.2907.10.camel@gmail.com> References: <1447945645-32005-1-git-send-email-maarten.lankhorst@linux.intel.com> <1447945645-32005-3-git-send-email-maarten.lankhorst@linux.intel.com> <1448373813.2672.19.camel@gmail.com> <56547A50.9010606@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-pa0-f52.google.com (mail-pa0-f52.google.com [209.85.220.52]) by gabe.freedesktop.org (Postfix) with ESMTPS id E5A746EA5A for ; Wed, 25 Nov 2015 01:23:05 -0800 (PST) Received: by padhx2 with SMTP id hx2so52043684pad.1 for ; Wed, 25 Nov 2015 01:23:05 -0800 (PST) In-Reply-To: <56547A50.9010606@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Maarten Lankhorst , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gVHVlLCAyMDE1LTExLTI0IGF0IDE1OjU1ICswMTAwLCBNYWFydGVuIExhbmtob3JzdCB3cm90 ZToKPiBPcCAyNC0xMS0xNSBvbSAxNTowMyBzY2hyZWVmIEFuZGVyIENvbnNlbHZhbiBEZSBPbGl2 ZWlyYToKPiA+IE9uIFRodSwgMjAxNS0xMS0xOSBhdCAxNjowNyArMDEwMCwgTWFhcnRlbiBMYW5r aG9yc3Qgd3JvdGU6Cj4gPiA+IFRoaXMgcmVtb3ZlcyBwcmUvcG9zdF93bV91cGRhdGUgZnJvbSBp bnRlbF9jcnRjLT5hdG9taWMsIGFuZAo+ID4gPiBjcmVhdGVzIGF0b21pYyBzdGF0ZSBmb3IgaXQg aW4gaW50ZWxfY3J0Yy4KPiA+ID4gCj4gPiA+IENoYW5nZXMgc2luY2UgdjE6Cj4gPiA+IC0gUmVi YXNlIG9uIHRvcCBvZiB3bSBjaGFuZ2VzLgo+ID4gPiBDaGFuZ2VzIHNpbmNlIHYyOgo+ID4gPiAt IFNwbGl0IGRpc2FibGVfY3hzciBpbnRvIGEgc2VwYXJhdGUgcGF0Y2guCj4gPiA+IAo+ID4gPiBT aWduZWQtb2ZmLWJ5OiBNYWFydGVuIExhbmtob3JzdCA8bWFhcnRlbi5sYW5raG9yc3RAbGludXgu aW50ZWwuY29tPgo+ID4gPiAtLS0KPiA+ID4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2F0 b21pYy5jICB8ICAxICsKPiA+ID4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXku YyB8IDMxICsrKysrKysrKysrKystLS0tLS0tLS0tLS0tLS0tLS0KPiA+ID4gIGRyaXZlcnMvZ3B1 L2RybS9pOTE1L2ludGVsX2Rydi5oICAgICB8ICAyICstCj4gPiA+ICAzIGZpbGVzIGNoYW5nZWQs IDE1IGluc2VydGlvbnMoKyksIDE5IGRlbGV0aW9ucygtKQo+ID4gPiAKPiA+ID4gZGlmZiAtLWdp dCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2F0b21pYy5jCj4gPiA+IGIvZHJpdmVycy9n cHUvZHJtL2k5MTUvaW50ZWxfYXRvbWljLmMKPiA+ID4gaW5kZXggOWYwNjM4YTM3YjZkLi40NjI1 ZjhhOWJhMTIgMTAwNjQ0Cj4gPiA+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2F0 b21pYy5jCj4gPiA+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2F0b21pYy5jCj4g PiA+IEBAIC05Niw2ICs5Niw3IEBAIGludGVsX2NydGNfZHVwbGljYXRlX3N0YXRlKHN0cnVjdCBk cm1fY3J0YyAqY3J0YykKPiA+ID4gIAljcnRjX3N0YXRlLT51cGRhdGVfcGlwZSA9IGZhbHNlOwo+ ID4gPiAgCWNydGNfc3RhdGUtPmRpc2FibGVfbHBfd20gPSBmYWxzZTsKPiA+ID4gIAljcnRjX3N0 YXRlLT5kaXNhYmxlX2N4c3IgPSBmYWxzZTsKPiA+ID4gKwljcnRjX3N0YXRlLT53bV9jaGFuZ2Vk ID0gZmFsc2U7Cj4gPiA+ICAKPiA+ID4gIAlyZXR1cm4gJmNydGNfc3RhdGUtPmJhc2U7Cj4gPiA+ ICB9Cj4gPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5 LmMKPiA+ID4gYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMKPiA+ID4gaW5k ZXggNWVlNjRlNjdhZDhhLi5kYjQ5OTU0MDYyNzcgMTAwNjQ0Cj4gPiA+IC0tLSBhL2RyaXZlcnMv Z3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYwo+ID4gPiArKysgYi9kcml2ZXJzL2dwdS9kcm0v aTkxNS9pbnRlbF9kaXNwbGF5LmMKPiA+ID4gQEAgLTQ3NDEsNiArNDc0MSw4IEBAIGludGVsX3By ZV9kaXNhYmxlX3ByaW1hcnkoc3RydWN0IGRybV9jcnRjICpjcnRjKQo+ID4gPiAgc3RhdGljIHZv aWQgaW50ZWxfcG9zdF9wbGFuZV91cGRhdGUoc3RydWN0IGludGVsX2NydGMgKmNydGMpCj4gPiA+ ICB7Cj4gPiA+ICAJc3RydWN0IGludGVsX2NydGNfYXRvbWljX2NvbW1pdCAqYXRvbWljID0gJmNy dGMtPmF0b21pYzsKPiA+ID4gKwlzdHJ1Y3QgaW50ZWxfY3J0Y19zdGF0ZSAqcGlwZV9jb25maWcg PQo+ID4gPiArCQl0b19pbnRlbF9jcnRjX3N0YXRlKGNydGMtPmJhc2Uuc3RhdGUpOwo+ID4gPiAg CXN0cnVjdCBkcm1fZGV2aWNlICpkZXYgPSBjcnRjLT5iYXNlLmRldjsKPiA+ID4gIAlzdHJ1Y3Qg ZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYgPSBkZXYtPmRldl9wcml2YXRlOwo+ID4gPiAgCj4g PiA+IEBAIC00NzUxLDcgKzQ3NTMsNyBAQCBzdGF0aWMgdm9pZCBpbnRlbF9wb3N0X3BsYW5lX3Vw ZGF0ZShzdHJ1Y3QKPiA+ID4gaW50ZWxfY3J0Ywo+ID4gPiAqY3J0YykKPiA+ID4gIAo+ID4gPiAg CWNydGMtPndtLmN4c3JfYWxsb3dlZCA9IHRydWU7Cj4gPiA+ICAKPiA+ID4gLQlpZiAoY3J0Yy0+ YXRvbWljLnVwZGF0ZV93bV9wb3N0KQo+ID4gPiArCWlmIChwaXBlX2NvbmZpZy0+d21fY2hhbmdl ZCkKPiA+ID4gIAkJaW50ZWxfdXBkYXRlX3dhdGVybWFya3MoJmNydGMtPmJhc2UpOwo+ID4gVGhp cyBhZGRzIGFuIGV4dHJhIGNhbGwgdG8gaW50ZWxfdXBkYXRlX3dhdGVybWFya3MoKSBmb3IgdGhl IGNhc2Ugd2hlcmUKPiA+IHByZXZpb3VzbHkgdXBkYXRlX3dtX3ByZSB3b3VsZCBiZSBzZXQuIFRo aXMgd29uJ3QgY2F1c2UgZXh0cmEgcmVnaXN0ZXIKPiA+IHdyaXRlcwo+ID4gYmVjYXVzZSBvZiB0 aGUgZGlydHkgY2hlY2ssIGJ1dCBJIHRoaW5rIGl0IGRlc2VydmVzIGEgbm90ZSBpbiB0aGUgY29t bWl0Cj4gPiBtZXNzYWdlLgo+IEkgdGhpbmsgaW50ZWxfdXBkYXRlX3dhdGVybWFya3MgbmVlZHMg dG8gYmUgZml4ZWQgdG8gdGFrZSBhIGNydGNfc3RhdGUgYW5kCj4gd2hldGhlciBwcmUvcG9zdCBj b21taXQgaXMgdXNlZC4KPiAKPiBJdCBsb29rcyB0byBtZSBsaWtlIGRvaW5nIGFueXRoaW5nIGVs c2UgY291bGQgYnVnIGlmIHdhdGVybWFya3MgYXJlIGNoYW5nZWQKPiB3aXRoIDEgcGxhbmUgYmVj b21pbmcgdmlzaWJsZSBhbmQgdGhlIG90aGVyIGludmlzaWJsZS4uCj4gPiA+ICAKPiA+ID4gIAlp ZiAoYXRvbWljLT51cGRhdGVfZmJjKQo+ID4gPiBAQCAtNDc4NCw2ICs0Nzg2LDkgQEAgc3RhdGlj IHZvaWQgaW50ZWxfcHJlX3BsYW5lX3VwZGF0ZShzdHJ1Y3QgaW50ZWxfY3J0Ywo+ID4gPiAqY3J0 YykKPiA+ID4gIAkJY3J0Yy0+d20uY3hzcl9hbGxvd2VkID0gZmFsc2U7Cj4gPiA+ICAJCWludGVs X3NldF9tZW1vcnlfY3hzcihkZXZfcHJpdiwgZmFsc2UpOwo+ID4gPiAgCX0KPiA+ID4gKwo+ID4g PiArCWlmICghbmVlZHNfbW9kZXNldCgmcGlwZV9jb25maWctPmJhc2UpICYmIHBpcGVfY29uZmln Cj4gPiA+IC0+d21fY2hhbmdlZCkKPiA+ID4gKwkJaW50ZWxfdXBkYXRlX3dhdGVybWFya3MoJmNy dGMtPmJhc2UpOwo+ID4gPiAgfQo+ID4gPiAgCj4gPiA+ICBzdGF0aWMgdm9pZCBpbnRlbF9jcnRj X2Rpc2FibGVfcGxhbmVzKHN0cnVjdCBkcm1fY3J0YyAqY3J0YywgdW5zaWduZWQKPiA+ID4gcGxh bmVfbWFzaykKPiA+ID4gQEAgLTExNzA2LDI1ICsxMTcxMSwxOCBAQCBpbnQgaW50ZWxfcGxhbmVf YXRvbWljX2NhbGNfY2hhbmdlcyhzdHJ1Y3QKPiA+ID4gZHJtX2NydGNfc3RhdGUgKmNydGNfc3Rh dGUsCj4gPiA+ICAJCQkgcGxhbmUtPmJhc2UuaWQsIHdhc192aXNpYmxlLCB2aXNpYmxlLAo+ID4g PiAgCQkJIHR1cm5fb2ZmLCB0dXJuX29uLCBtb2RlX2NoYW5nZWQpOwo+ID4gPiAgCj4gPiA+IC0J aWYgKHR1cm5fb24pIHsKPiA+ID4gLQkJaW50ZWxfY3J0Yy0+YXRvbWljLnVwZGF0ZV93bV9wcmUg PSB0cnVlOwo+ID4gPiAtCQkvKiBtdXN0IGRpc2FibGUgY3hzciBhcm91bmQgcGxhbmUgZW5hYmxl L2Rpc2FibGUgKi8KPiA+ID4gLQkJaWYgKHBsYW5lLT50eXBlICE9IERSTV9QTEFORV9UWVBFX0NV UlNPUikgewo+ID4gPiAtCQkJcGlwZV9jb25maWctPmRpc2FibGVfY3hzciA9IHRydWU7Cj4gPiA+ IC0JCQkvKiB0byBwb3RlbnRpYWxseSByZS1lbmFibGUgY3hzciAqLwo+ID4gPiAtCQkJaW50ZWxf Y3J0Yy0+YXRvbWljLndhaXRfdmJsYW5rID0gdHJ1ZTsKPiA+ID4gLQkJCWludGVsX2NydGMtPmF0 b21pYy51cGRhdGVfd21fcG9zdCA9IHRydWU7Cj4gPiA+IC0JCX0KPiA+ID4gLQl9IGVsc2UgaWYg KHR1cm5fb2ZmKSB7Cj4gPiA+IC0JCWludGVsX2NydGMtPmF0b21pYy51cGRhdGVfd21fcG9zdCA9 IHRydWU7Cj4gPiA+ICsJaWYgKHR1cm5fb24gfHwgdHVybl9vZmYpIHsKPiA+ID4gKwkJcGlwZV9j b25maWctPndtX2NoYW5nZWQgPSB0cnVlOwo+ID4gPiArCj4gPiA+ICAJCS8qIG11c3QgZGlzYWJs ZSBjeHNyIGFyb3VuZCBwbGFuZSBlbmFibGUvZGlzYWJsZSAqLwo+ID4gPiAgCQlpZiAocGxhbmUt PnR5cGUgIT0gRFJNX1BMQU5FX1RZUEVfQ1VSU09SKSB7Cj4gPiA+ICAJCQlpZiAoaXNfY3J0Y19l bmFibGVkKQo+ID4gPiAgCQkJCWludGVsX2NydGMtPmF0b21pYy53YWl0X3ZibGFuayA9IHRydWU7 Cj4gPiA+ICAJCQlwaXBlX2NvbmZpZy0+ZGlzYWJsZV9jeHNyID0gdHJ1ZTsKPiA+ID4gIAkJfQo+ ID4gPiAtCX0gZWxzZSBpZiAoaW50ZWxfd21fbmVlZF91cGRhdGUocGxhbmUsIHBsYW5lX3N0YXRl KSkgewo+ID4gPiAtCQlpbnRlbF9jcnRjLT5hdG9taWMudXBkYXRlX3dtX3ByZSA9IHRydWU7Cj4g PiA+ICsJfSBlbHNlIGlmICgod2FzX3Zpc2libGUgfHwgdmlzaWJsZSkgJiYKPiA+IFNvIHRoaXMg YXZvaWRzIHdhdGVybWFyayBjaGFuZ2VzIHdoZW4gdGhlIHBsYW5lIGlzIG5vdCB2aXNpYmxlIGJl Zm9yZSBvcgo+ID4gYWZ0ZXIKPiA+IHRoZSB1cGRhdGUuIFdvdWxkbid0IGl0IGJlIGJldHRlciB0 byBmaXggaW50ZWxfd21fbmVlZF91cGRhdGUoKSBpbnN0ZWFkIGlmCj4gPiByZXR1cm5zIHRydWUg aW4gdGhhdCBjYXNlPwo+IAo+IElmIHZpc2libGUgaXMgY2hhbmdlZCB3bV9jaGFuZ2VkID0gdHJ1 ZSBpcyBhbHdheXMgc2V0LiBJdCB3b3VsZCBnbyB0aHJvdWdoIHRoZQo+ICh0dXJuX29uIHx8IHR1 cm5fb2ZmKSBjYXNlLgo+IAo+IEkgZ3Vlc3MgY2hlY2tpbmcgd2FzX3Zpc2libGUgfHwgdmlzaWJs ZSBpcyBvdmVya2lsbCwgYW5kIGNvdWxkIGJlIGNoYW5nZWQgdG8KPiBqdXN0IHZpc2libGUgJiYg aW50ZWxfd21fbmVlZF91cGRhdGUocGxhbmUsIHBsYW5lX3N0YXRlKS4KCldoYXQgSSBtZWFudCBp cyB0aGF0IEkgZmluZCBvZGQgdGhhdCBpbnRlbF93bV9uZWVkX3VwZGF0ZSgpIHJldHVybnMgdHJ1 ZSB3aGVuCmJvdGggd2FzX3Zpc2libGUgYW5kIHZpc2libGUgaXMgZmFsc2UuIFNpbmNlIHRoYXQg ZnVuY3Rpb24gaXMgc3VwcG9zZWQgdG8KY29tcGFyZSB0d28gcGxhbmUgc3RhdGVzIGFuZCB0ZWxs IHVzIGlmIGEgd20gdXBkYXRlIGlzIG5lZWRlZCwgSSdkIHJhdGhlciBhZGQKdGhlIHZpc2libGUg Y2hlY2sgdGhlcmUuCgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Au b3JnCmh0dHA6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1n ZngK