From: Imre Deak <imre.deak@intel.com>
To: Bob Paauwe <bob.j.paauwe@intel.com>,
intel-gfx <intel-gfx@lists.freedesktop.org>
Cc: Thomas Wood <thomas.wood@intel.com>
Subject: Re: [PATCH] igt/pm_rps: current freq < user specified min is not a fail (v3)
Date: Fri, 04 Dec 2015 16:34:57 +0200 [thread overview]
Message-ID: <1449239697.14707.13.camel@intel.com> (raw)
In-Reply-To: <1449188880-19856-1-git-send-email-bob.j.paauwe@intel.com>
On to, 2015-12-03 at 16:28 -0800, Bob Paauwe wrote:
> Since commit
>
> commit aed242ff7ebb697e4dff912bd4dc7ec7192f7581
> Author: Chris Wilson <chris@chris-wilson.co.uk>
> Date: Wed Mar 18 09:48:21 2015 +0000
>
> drm/i915: Relax RPS contraints to allows setting minfreq on
> idle
>
> it is now possible that the current frequency will drop be the user
> specified minimum frequency to the "idle" or RPn frequency. Update
> the
> pm_rps tests to reflect that droping below the user specified
> minimum
> is no longer considered a failure.
>
> v2: Add check RPn <= current freq. (Me)
> v3: Use RPn instead of MIN frequency in idle check (Imre)
> Signed-off-by: Bob Paauwe <bob.j.paauwe@intel.com>
Thanks, looks ok to me:
Reviewed-by: Imre Deak <imre.deak@intel.com>
I can also push this to IGT.
> ---
> tests/pm_rps.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/tests/pm_rps.c b/tests/pm_rps.c
> index 74f08f4..9d054fd 100644
> --- a/tests/pm_rps.c
> +++ b/tests/pm_rps.c
> @@ -146,7 +146,7 @@ static void checkit(const int *freqs)
> {
> igt_assert_lte(freqs[MIN], freqs[MAX]);
> igt_assert_lte(freqs[CUR], freqs[MAX]);
> - igt_assert_lte(freqs[MIN], freqs[CUR]);
> + igt_assert_lte(freqs[RPn], freqs[CUR]);
> igt_assert_lte(freqs[RPn], freqs[MIN]);
> igt_assert_lte(freqs[MAX], freqs[RP0]);
> igt_assert_lte(freqs[RP1], freqs[RP0]);
> @@ -472,14 +472,14 @@ static void idle_check(void)
> read_freqs(freqs);
> dump(freqs);
> checkit(freqs);
> - if (freqs[CUR] == freqs[MIN])
> + if (freqs[CUR] == freqs[RPn])
> break;
> usleep(1000 * IDLE_WAIT_TIMESTEP_MSEC);
> wait += IDLE_WAIT_TIMESTEP_MSEC;
> } while (wait < IDLE_WAIT_TIMEOUT_MSEC);
>
> - igt_assert_eq(freqs[CUR], freqs[MIN]);
> - igt_debug("Required %d msec to reach cur=min\n", wait);
> + igt_assert_eq(freqs[CUR], freqs[RPn]);
> + igt_debug("Required %d msec to reach cur=idle\n", wait);
> }
>
> #define LOADED_WAIT_TIMESTEP_MSEC 100
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2015-12-04 14:34 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-11 21:37 [PATCH i-g-t] igt/pm_rps: current freq < user specified min is no longer a fail Bob Paauwe
2015-11-12 9:18 ` Imre Deak
2015-11-12 18:17 ` Bob Paauwe
2015-11-30 11:30 ` Imre Deak
2015-12-01 0:23 ` [PATCH 0/2] igt/pm_rps: Handle freq < user min in specific cases Bob Paauwe
2015-12-01 0:23 ` [PATCH 1/2] igt/pm_rps: current freq < user specified min is not a fail (v2) Bob Paauwe
2015-12-01 13:51 ` Imre Deak
2015-12-04 0:28 ` [PATCH] igt/pm_rps: current freq < user specified min is not a fail (v3) Bob Paauwe
2015-12-04 14:34 ` Imre Deak [this message]
2015-12-01 0:23 ` [PATCH 2/2] igt/pm_rps: Add checks for freq = idle (RPn) in specific cases Bob Paauwe
2015-12-01 13:56 ` Imre Deak
2015-12-01 17:22 ` Bob Paauwe
2015-12-01 17:43 ` Imre Deak
2015-12-04 0:43 ` Bob Paauwe
2015-12-04 15:22 ` Imre Deak
2015-12-04 18:37 ` Bob Paauwe
2015-12-04 20:58 ` Imre Deak
2015-12-04 22:41 ` Bob Paauwe
2015-12-07 15:00 ` Imre Deak
2015-12-07 21:56 ` Bob Paauwe
2015-12-11 8:48 ` Kamble, Sagar A
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1449239697.14707.13.camel@intel.com \
--to=imre.deak@intel.com \
--cc=bob.j.paauwe@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=thomas.wood@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).