From: Imre Deak <imre.deak@intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Intel graphics driver community testing & development
<intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH] drm/i915: Cancel hangcheck before GPU is suspended
Date: Thu, 10 Dec 2015 11:32:50 +0200 [thread overview]
Message-ID: <1449739970.25404.0.camel@intel.com> (raw)
In-Reply-To: <20151209161907.GG29974@nuc-i3427.alporthouse.com>
On Wed, 2015-12-09 at 16:19 +0000, Chris Wilson wrote:
> On Wed, Dec 09, 2015 at 04:10:03PM +0200, Imre Deak wrote:
> > On ke, 2015-12-09 at 15:56 +0200, Joonas Lahtinen wrote:
> > > In order to avoid accessing GPU registers while GPU is suspended
> > > cancel
> > > the hangcheck work before calling intel_suspend_complete which
> > > actually
> > > puts the GPU to suspend. Otherwise hangcheck might do MMIO reads
> > > to a
> > > suspended GPU.
> > >
> > > Placement before intel_guc_suspend is imitated from
> > > i915_drm_suspend
> > > which cancels the work at i915_gem_suspend, to keep the functions
> > > similar.
> > >
> > > On VLV systems, namely BYT, this was causing an error during
> > > runtime
> > > suspend cycle:
> > >
> > > [drm:vlv_check_no_gt_access [i915]] *ERROR* GT register access
> > > while
> > > GT waking disabled
> > >
> > > Testcase: igt/pm_rpm/basic-rte
> > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=93121
> > >
> > > Signed-off-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
> > > Cc: Imre Deak <imre.deak@intel.com>
> > > Cc: Chris Wilson <chris@chris-wilson.co.uk>
> >
> > Yep, looks good to me:
> > Reviewed-by: Imre Deak <imre.deak@intel.com>
>
> Well Imre also shotdown the simple tryget plan, so the only thing I
> can
> say is that I'd rather move the cancel_sync(hangcheck) out of the
> intel_runtime_suspend() into the mark_idle to match it's counterpart
> in
> mark_busy.
>
> Patch in the post, so for now
> Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
Pushed to dinq, thanks for the patch and review.
> -Chris
>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
prev parent reply other threads:[~2015-12-10 9:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-09 13:56 [PATCH] drm/i915: Cancel hangcheck before GPU is suspended Joonas Lahtinen
2015-12-09 14:10 ` Imre Deak
2015-12-09 16:19 ` Chris Wilson
2015-12-10 9:32 ` Imre Deak [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1449739970.25404.0.camel@intel.com \
--to=imre.deak@intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox