* [PATCH v2] drm/i915: Correct max delay for HDMI hotplug live status checking @ 2015-12-14 9:38 Gary Wang 2015-12-14 11:29 ` Jani Nikula 0 siblings, 1 reply; 9+ messages in thread From: Gary Wang @ 2015-12-14 9:38 UTC (permalink / raw) To: intel-gfx The total delay of HDMI hotplug detecting with 30ms have already been split into a resolution of 3 retries of 10ms each, for the worst cases. But it still suffered from only waiting 10ms at most in intel_hdmi_detect(). This patch corrects it by reading hotplug status with 4 times at most for 30ms delay. v2: - straight up to loop execution for more clear in code readability Reviewed-by: Cooper Chiou <cooper.chiou@intel.com> Tested-by: Gary Wang <gary.c.wang@intel.com> Cc: Daniel Vetter <daniel@ffwll.ch> Cc: Gavin Hindman <gavin.hindman@intel.com> Cc: Sonika Jindal <sonika.jindal@intel.com> Cc: Shashank Sharma <shashank.sharma@intel.com> Signed-off-by: Gary Wang <gary.c.wang@intel.com> --- drivers/gpu/drm/i915/intel_hdmi.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) mode change 100644 => 100755 drivers/gpu/drm/i915/intel_hdmi.c diff --git a/drivers/gpu/drm/i915/intel_hdmi.c b/drivers/gpu/drm/i915/intel_hdmi.c old mode 100644 new mode 100755 index 6825543..97ed16f --- a/drivers/gpu/drm/i915/intel_hdmi.c +++ b/drivers/gpu/drm/i915/intel_hdmi.c @@ -1387,16 +1387,18 @@ intel_hdmi_detect(struct drm_connector *connector, bool force) struct intel_hdmi *intel_hdmi = intel_attached_hdmi(connector); struct drm_i915_private *dev_priv = to_i915(connector->dev); bool live_status = false; - unsigned int retry = 3; + unsigned int retry; DRM_DEBUG_KMS("[CONNECTOR:%d:%s]\n", connector->base.id, connector->name); intel_display_power_get(dev_priv, POWER_DOMAIN_GMBUS); - while (!live_status && --retry) { + for (retry = 0; retry <= 3; retry++) { live_status = intel_digital_port_connected(dev_priv, hdmi_to_dig_port(intel_hdmi)); + if (live_status || (retry == 3)) + break; mdelay(10); } -- 1.9.1 _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH v2] drm/i915: Correct max delay for HDMI hotplug live status checking 2015-12-14 9:38 [PATCH v2] drm/i915: Correct max delay for HDMI hotplug live status checking Gary Wang @ 2015-12-14 11:29 ` Jani Nikula 2015-12-15 2:30 ` Wang, Gary C 2015-12-15 4:40 ` Gary Wang 0 siblings, 2 replies; 9+ messages in thread From: Jani Nikula @ 2015-12-14 11:29 UTC (permalink / raw) To: Gary Wang, intel-gfx On Mon, 14 Dec 2015, Gary Wang <gary.c.wang@intel.com> wrote: > The total delay of HDMI hotplug detecting with 30ms have already > been split into a resolution of 3 retries of 10ms each, for the worst > cases. But it still suffered from only waiting 10ms at most in > intel_hdmi_detect(). This patch corrects it by reading hotplug status > with 4 times at most for 30ms delay. It used to try twice, with 10 ms in between, but also with 10 ms after the last attempt, success or not. > > v2: > - straight up to loop execution for more clear in code readability > > Reviewed-by: Cooper Chiou <cooper.chiou@intel.com> > Tested-by: Gary Wang <gary.c.wang@intel.com> > Cc: Daniel Vetter <daniel@ffwll.ch> > Cc: Gavin Hindman <gavin.hindman@intel.com> > Cc: Sonika Jindal <sonika.jindal@intel.com> > Cc: Shashank Sharma <shashank.sharma@intel.com> > Signed-off-by: Gary Wang <gary.c.wang@intel.com> > --- > drivers/gpu/drm/i915/intel_hdmi.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > mode change 100644 => 100755 drivers/gpu/drm/i915/intel_hdmi.c > > diff --git a/drivers/gpu/drm/i915/intel_hdmi.c b/drivers/gpu/drm/i915/intel_hdmi.c > old mode 100644 > new mode 100755 > index 6825543..97ed16f > --- a/drivers/gpu/drm/i915/intel_hdmi.c > +++ b/drivers/gpu/drm/i915/intel_hdmi.c > @@ -1387,16 +1387,18 @@ intel_hdmi_detect(struct drm_connector *connector, bool force) > struct intel_hdmi *intel_hdmi = intel_attached_hdmi(connector); > struct drm_i915_private *dev_priv = to_i915(connector->dev); > bool live_status = false; > - unsigned int retry = 3; > + unsigned int retry; > > DRM_DEBUG_KMS("[CONNECTOR:%d:%s]\n", > connector->base.id, connector->name); > > intel_display_power_get(dev_priv, POWER_DOMAIN_GMBUS); > > - while (!live_status && --retry) { > + for (retry = 0; retry <= 3; retry++) { > live_status = intel_digital_port_connected(dev_priv, > hdmi_to_dig_port(intel_hdmi)); > + if (live_status || (retry == 3)) > + break; > mdelay(10); > } Basically the "retry <= 3" is never the stop condition in your loop, and is thus misleading. How about this instead, with the paradigm counting for loop: for (try = 0; !live_status && try < 4; try++) { if (try) mdelay(10); live_status = intel_digital_port_connected(...); } Note that I didn't actually check if this is the right thing to do; this is just your loop rewritten as I'd write it... ;) BR, Jani. -- Jani Nikula, Intel Open Source Technology Center _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v2] drm/i915: Correct max delay for HDMI hotplug live status checking 2015-12-14 11:29 ` Jani Nikula @ 2015-12-15 2:30 ` Wang, Gary C 2015-12-15 4:40 ` Gary Wang 1 sibling, 0 replies; 9+ messages in thread From: Wang, Gary C @ 2015-12-15 2:30 UTC (permalink / raw) To: Jani Nikula, intel-gfx@lists.freedesktop.org Yes, your code is clear. It tried to check hot-plug with 4 times based on delay setup (30ms) in following patch, commit 237ed86c693d8a8e4db476976aeb30df4deac74b Author: Sonika Jindal <sonika.jindal@xxxxxxxxx> Date: Tue Sep 15 09:44:20 2015 +0530 drm/i915: Check live status before reading edid I will refine patch for your review again. Thanks! Gary -----Original Message----- From: Jani Nikula [mailto:jani.nikula@linux.intel.com] Sent: Monday, December 14, 2015 7:29 PM To: Wang, Gary C <gary.c.wang@intel.com>; intel-gfx@lists.freedesktop.org Subject: Re: [Intel-gfx] [PATCH v2] drm/i915: Correct max delay for HDMI hotplug live status checking On Mon, 14 Dec 2015, Gary Wang <gary.c.wang@intel.com> wrote: > The total delay of HDMI hotplug detecting with 30ms have already been > split into a resolution of 3 retries of 10ms each, for the worst > cases. But it still suffered from only waiting 10ms at most in > intel_hdmi_detect(). This patch corrects it by reading hotplug status > with 4 times at most for 30ms delay. It used to try twice, with 10 ms in between, but also with 10 ms after the last attempt, success or not. > > v2: > - straight up to loop execution for more clear in code readability > > Reviewed-by: Cooper Chiou <cooper.chiou@intel.com> > Tested-by: Gary Wang <gary.c.wang@intel.com> > Cc: Daniel Vetter <daniel@ffwll.ch> > Cc: Gavin Hindman <gavin.hindman@intel.com> > Cc: Sonika Jindal <sonika.jindal@intel.com> > Cc: Shashank Sharma <shashank.sharma@intel.com> > Signed-off-by: Gary Wang <gary.c.wang@intel.com> > --- > drivers/gpu/drm/i915/intel_hdmi.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) mode change 100644 > => 100755 drivers/gpu/drm/i915/intel_hdmi.c > > diff --git a/drivers/gpu/drm/i915/intel_hdmi.c > b/drivers/gpu/drm/i915/intel_hdmi.c > old mode 100644 > new mode 100755 > index 6825543..97ed16f > --- a/drivers/gpu/drm/i915/intel_hdmi.c > +++ b/drivers/gpu/drm/i915/intel_hdmi.c > @@ -1387,16 +1387,18 @@ intel_hdmi_detect(struct drm_connector *connector, bool force) > struct intel_hdmi *intel_hdmi = intel_attached_hdmi(connector); > struct drm_i915_private *dev_priv = to_i915(connector->dev); > bool live_status = false; > - unsigned int retry = 3; > + unsigned int retry; > > DRM_DEBUG_KMS("[CONNECTOR:%d:%s]\n", > connector->base.id, connector->name); > > intel_display_power_get(dev_priv, POWER_DOMAIN_GMBUS); > > - while (!live_status && --retry) { > + for (retry = 0; retry <= 3; retry++) { > live_status = intel_digital_port_connected(dev_priv, > hdmi_to_dig_port(intel_hdmi)); > + if (live_status || (retry == 3)) > + break; > mdelay(10); > } Basically the "retry <= 3" is never the stop condition in your loop, and is thus misleading. How about this instead, with the paradigm counting for loop: for (try = 0; !live_status && try < 4; try++) { if (try) mdelay(10); live_status = intel_digital_port_connected(...); } Note that I didn't actually check if this is the right thing to do; this is just your loop rewritten as I'd write it... ;) BR, Jani. -- Jani Nikula, Intel Open Source Technology Center _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH v2] drm/i915: Correct max delay for HDMI hotplug live status checking 2015-12-14 11:29 ` Jani Nikula 2015-12-15 2:30 ` Wang, Gary C @ 2015-12-15 4:40 ` Gary Wang 2015-12-18 1:21 ` Wang, Gary C 2015-12-21 10:29 ` Daniel Vetter 1 sibling, 2 replies; 9+ messages in thread From: Gary Wang @ 2015-12-15 4:40 UTC (permalink / raw) To: intel-gfx The total delay of HDMI hotplug detecting with 30ms have already been split into a resolution of 3 retries of 10ms each, for the worst cases. But it still suffered from only waiting 10ms at most in intel_hdmi_detect(). This patch corrects it by reading hotplug status with 4 times at most for 30ms delay. v2: - straight up to loop execution for more clear in code readability - mdelay will replace with msleep by Daniel's new patch drm/i915: mdelay(10) considered harmful - suggest to re-evaluate try times for being compatible to old HDMI monitor Reviewed-by: Cooper Chiou <cooper.chiou@intel.com> Tested-by: Gary Wang <gary.c.wang@intel.com> Cc: Jani Nikula <jani.nikula@linux.intel.com> Cc: Daniel Vetter <daniel@ffwll.ch> Cc: Gavin Hindman <gavin.hindman@intel.com> Cc: Sonika Jindal <sonika.jindal@intel.com> Cc: Shashank Sharma <shashank.sharma@intel.com> Signed-off-by: Gary Wang <gary.c.wang@intel.com> --- drivers/gpu/drm/i915/intel_hdmi.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) mode change 100644 => 100755 drivers/gpu/drm/i915/intel_hdmi.c diff --git a/drivers/gpu/drm/i915/intel_hdmi.c b/drivers/gpu/drm/i915/intel_hdmi.c old mode 100644 new mode 100755 index 6825543..912d6c3 --- a/drivers/gpu/drm/i915/intel_hdmi.c +++ b/drivers/gpu/drm/i915/intel_hdmi.c @@ -1387,17 +1387,18 @@ intel_hdmi_detect(struct drm_connector *connector, bool force) struct intel_hdmi *intel_hdmi = intel_attached_hdmi(connector); struct drm_i915_private *dev_priv = to_i915(connector->dev); bool live_status = false; - unsigned int retry = 3; + unsigned int try; DRM_DEBUG_KMS("[CONNECTOR:%d:%s]\n", connector->base.id, connector->name); intel_display_power_get(dev_priv, POWER_DOMAIN_GMBUS); - while (!live_status && --retry) { + for (try = 0; !live_status && try < 4; try++) { + if (try) + mdelay(10); live_status = intel_digital_port_connected(dev_priv, hdmi_to_dig_port(intel_hdmi)); - mdelay(10); } if (!live_status) -- 1.9.1 _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH v2] drm/i915: Correct max delay for HDMI hotplug live status checking 2015-12-15 4:40 ` Gary Wang @ 2015-12-18 1:21 ` Wang, Gary C 2015-12-21 10:29 ` Daniel Vetter 1 sibling, 0 replies; 9+ messages in thread From: Wang, Gary C @ 2015-12-18 1:21 UTC (permalink / raw) To: intel-gfx@lists.freedesktop.org For BSW platform, it seems 10ms delay of hot-plug detecting is not enough and to cause high fail-rate on old HDMI monitor, and I would like correct it. Then user needs to wait screen blank for 2 mins or re-plugin cable (impact to user experience). Thanks for your review. Gary -----Original Message----- From: Wang, Gary C Sent: Tuesday, December 15, 2015 12:41 PM To: intel-gfx@lists.freedesktop.org Cc: Wang, Gary C <gary.c.wang@intel.com>; Jani Nikula <jani.nikula@linux.intel.com>; Daniel Vetter <daniel@ffwll.ch>; Hindman, Gavin <gavin.hindman@intel.com>; Jindal, Sonika <sonika.jindal@intel.com>; Sharma, Shashank <shashank.sharma@intel.com> Subject: [PATCH v2] drm/i915: Correct max delay for HDMI hotplug live status checking The total delay of HDMI hotplug detecting with 30ms have already been split into a resolution of 3 retries of 10ms each, for the worst cases. But it still suffered from only waiting 10ms at most in intel_hdmi_detect(). This patch corrects it by reading hotplug status with 4 times at most for 30ms delay. v2: - straight up to loop execution for more clear in code readability - mdelay will replace with msleep by Daniel's new patch drm/i915: mdelay(10) considered harmful - suggest to re-evaluate try times for being compatible to old HDMI monitor Reviewed-by: Cooper Chiou <cooper.chiou@intel.com> Tested-by: Gary Wang <gary.c.wang@intel.com> Cc: Jani Nikula <jani.nikula@linux.intel.com> Cc: Daniel Vetter <daniel@ffwll.ch> Cc: Gavin Hindman <gavin.hindman@intel.com> Cc: Sonika Jindal <sonika.jindal@intel.com> Cc: Shashank Sharma <shashank.sharma@intel.com> Signed-off-by: Gary Wang <gary.c.wang@intel.com> --- drivers/gpu/drm/i915/intel_hdmi.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) mode change 100644 => 100755 drivers/gpu/drm/i915/intel_hdmi.c diff --git a/drivers/gpu/drm/i915/intel_hdmi.c b/drivers/gpu/drm/i915/intel_hdmi.c old mode 100644 new mode 100755 index 6825543..912d6c3 --- a/drivers/gpu/drm/i915/intel_hdmi.c +++ b/drivers/gpu/drm/i915/intel_hdmi.c @@ -1387,17 +1387,18 @@ intel_hdmi_detect(struct drm_connector *connector, bool force) struct intel_hdmi *intel_hdmi = intel_attached_hdmi(connector); struct drm_i915_private *dev_priv = to_i915(connector->dev); bool live_status = false; - unsigned int retry = 3; + unsigned int try; DRM_DEBUG_KMS("[CONNECTOR:%d:%s]\n", connector->base.id, connector->name); intel_display_power_get(dev_priv, POWER_DOMAIN_GMBUS); - while (!live_status && --retry) { + for (try = 0; !live_status && try < 4; try++) { + if (try) + mdelay(10); live_status = intel_digital_port_connected(dev_priv, hdmi_to_dig_port(intel_hdmi)); - mdelay(10); } if (!live_status) -- 1.9.1 _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH v2] drm/i915: Correct max delay for HDMI hotplug live status checking 2015-12-15 4:40 ` Gary Wang 2015-12-18 1:21 ` Wang, Gary C @ 2015-12-21 10:29 ` Daniel Vetter 2015-12-21 10:37 ` Chris Wilson 1 sibling, 1 reply; 9+ messages in thread From: Daniel Vetter @ 2015-12-21 10:29 UTC (permalink / raw) To: Gary Wang; +Cc: intel-gfx On Tue, Dec 15, 2015 at 12:40:30PM +0800, Gary Wang wrote: > The total delay of HDMI hotplug detecting with 30ms have already > been split into a resolution of 3 retries of 10ms each, for the worst > cases. But it still suffered from only waiting 10ms at most in > intel_hdmi_detect(). This patch corrects it by reading hotplug status > with 4 times at most for 30ms delay. > > v2: > - straight up to loop execution for more clear in code readability > - mdelay will replace with msleep by Daniel's new patch > > drm/i915: mdelay(10) considered harmful > > - suggest to re-evaluate try times for being compatible to old HDMI monitor > > Reviewed-by: Cooper Chiou <cooper.chiou@intel.com> > Tested-by: Gary Wang <gary.c.wang@intel.com> > Cc: Jani Nikula <jani.nikula@linux.intel.com> > Cc: Daniel Vetter <daniel@ffwll.ch> > Cc: Gavin Hindman <gavin.hindman@intel.com> > Cc: Sonika Jindal <sonika.jindal@intel.com> > Cc: Shashank Sharma <shashank.sharma@intel.com> > Signed-off-by: Gary Wang <gary.c.wang@intel.com> Queued for -next (including cc: fixes), thanks for the patch. -Daniel > --- > drivers/gpu/drm/i915/intel_hdmi.c | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > mode change 100644 => 100755 drivers/gpu/drm/i915/intel_hdmi.c > > diff --git a/drivers/gpu/drm/i915/intel_hdmi.c b/drivers/gpu/drm/i915/intel_hdmi.c > old mode 100644 > new mode 100755 > index 6825543..912d6c3 > --- a/drivers/gpu/drm/i915/intel_hdmi.c > +++ b/drivers/gpu/drm/i915/intel_hdmi.c > @@ -1387,17 +1387,18 @@ intel_hdmi_detect(struct drm_connector *connector, bool force) > struct intel_hdmi *intel_hdmi = intel_attached_hdmi(connector); > struct drm_i915_private *dev_priv = to_i915(connector->dev); > bool live_status = false; > - unsigned int retry = 3; > + unsigned int try; > > DRM_DEBUG_KMS("[CONNECTOR:%d:%s]\n", > connector->base.id, connector->name); > > intel_display_power_get(dev_priv, POWER_DOMAIN_GMBUS); > > - while (!live_status && --retry) { > + for (try = 0; !live_status && try < 4; try++) { > + if (try) > + mdelay(10); > live_status = intel_digital_port_connected(dev_priv, > hdmi_to_dig_port(intel_hdmi)); > - mdelay(10); > } > > if (!live_status) > -- > 1.9.1 > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v2] drm/i915: Correct max delay for HDMI hotplug live status checking 2015-12-21 10:29 ` Daniel Vetter @ 2015-12-21 10:37 ` Chris Wilson 2015-12-21 11:52 ` Daniel Vetter 0 siblings, 1 reply; 9+ messages in thread From: Chris Wilson @ 2015-12-21 10:37 UTC (permalink / raw) To: Daniel Vetter; +Cc: intel-gfx On Mon, Dec 21, 2015 at 11:29:16AM +0100, Daniel Vetter wrote: > On Tue, Dec 15, 2015 at 12:40:30PM +0800, Gary Wang wrote: > > The total delay of HDMI hotplug detecting with 30ms have already > > been split into a resolution of 3 retries of 10ms each, for the worst > > cases. But it still suffered from only waiting 10ms at most in > > intel_hdmi_detect(). This patch corrects it by reading hotplug status > > with 4 times at most for 30ms delay. > > > > v2: > > - straight up to loop execution for more clear in code readability > > - mdelay will replace with msleep by Daniel's new patch > > > > drm/i915: mdelay(10) considered harmful > > > > - suggest to re-evaluate try times for being compatible to old HDMI monitor > > > > Reviewed-by: Cooper Chiou <cooper.chiou@intel.com> > > Tested-by: Gary Wang <gary.c.wang@intel.com> > > Cc: Jani Nikula <jani.nikula@linux.intel.com> > > Cc: Daniel Vetter <daniel@ffwll.ch> > > Cc: Gavin Hindman <gavin.hindman@intel.com> > > Cc: Sonika Jindal <sonika.jindal@intel.com> > > Cc: Shashank Sharma <shashank.sharma@intel.com> > > Signed-off-by: Gary Wang <gary.c.wang@intel.com> > > Queued for -next (including cc: fixes), thanks for the patch. Using mdelay() or fixed to use msleep()? -Chris -- Chris Wilson, Intel Open Source Technology Centre _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v2] drm/i915: Correct max delay for HDMI hotplug live status checking 2015-12-21 10:37 ` Chris Wilson @ 2015-12-21 11:52 ` Daniel Vetter 2015-12-22 2:54 ` Wang, Gary C 0 siblings, 1 reply; 9+ messages in thread From: Daniel Vetter @ 2015-12-21 11:52 UTC (permalink / raw) To: Chris Wilson, Daniel Vetter, Gary Wang, intel-gfx On Mon, Dec 21, 2015 at 10:37:25AM +0000, Chris Wilson wrote: > On Mon, Dec 21, 2015 at 11:29:16AM +0100, Daniel Vetter wrote: > > On Tue, Dec 15, 2015 at 12:40:30PM +0800, Gary Wang wrote: > > > The total delay of HDMI hotplug detecting with 30ms have already > > > been split into a resolution of 3 retries of 10ms each, for the worst > > > cases. But it still suffered from only waiting 10ms at most in > > > intel_hdmi_detect(). This patch corrects it by reading hotplug status > > > with 4 times at most for 30ms delay. > > > > > > v2: > > > - straight up to loop execution for more clear in code readability > > > - mdelay will replace with msleep by Daniel's new patch > > > > > > drm/i915: mdelay(10) considered harmful > > > > > > - suggest to re-evaluate try times for being compatible to old HDMI monitor > > > > > > Reviewed-by: Cooper Chiou <cooper.chiou@intel.com> > > > Tested-by: Gary Wang <gary.c.wang@intel.com> > > > Cc: Jani Nikula <jani.nikula@linux.intel.com> > > > Cc: Daniel Vetter <daniel@ffwll.ch> > > > Cc: Gavin Hindman <gavin.hindman@intel.com> > > > Cc: Sonika Jindal <sonika.jindal@intel.com> > > > Cc: Shashank Sharma <shashank.sharma@intel.com> > > > Signed-off-by: Gary Wang <gary.c.wang@intel.com> > > > > Queued for -next (including cc: fixes), thanks for the patch. > > Using mdelay() or fixed to use msleep()? msleep patch was merged already, I just had to resolve the conflict. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v2] drm/i915: Correct max delay for HDMI hotplug live status checking 2015-12-21 11:52 ` Daniel Vetter @ 2015-12-22 2:54 ` Wang, Gary C 0 siblings, 0 replies; 9+ messages in thread From: Wang, Gary C @ 2015-12-22 2:54 UTC (permalink / raw) To: Daniel Vetter, Chris Wilson, intel-gfx@lists.freedesktop.org Sorry for my incorrect grammar on my patch. It should be following description (mdelay-->msleep), ... v2: - straight up to loop execution for more clear in code readability - mdelay will be replaced with msleep by Daniel's new patch drm/i915: mdelay(10) considered harmful ... Gary -----Original Message----- From: Daniel Vetter [mailto:daniel.vetter@ffwll.ch] On Behalf Of Daniel Vetter Sent: Monday, December 21, 2015 7:52 PM To: Chris Wilson <chris@chris-wilson.co.uk>; Daniel Vetter <daniel@ffwll.ch>; Wang, Gary C <gary.c.wang@intel.com>; intel-gfx@lists.freedesktop.org Subject: Re: [Intel-gfx] [PATCH v2] drm/i915: Correct max delay for HDMI hotplug live status checking On Mon, Dec 21, 2015 at 10:37:25AM +0000, Chris Wilson wrote: > On Mon, Dec 21, 2015 at 11:29:16AM +0100, Daniel Vetter wrote: > > On Tue, Dec 15, 2015 at 12:40:30PM +0800, Gary Wang wrote: > > > The total delay of HDMI hotplug detecting with 30ms have already > > > been split into a resolution of 3 retries of 10ms each, for the > > > worst cases. But it still suffered from only waiting 10ms at most > > > in intel_hdmi_detect(). This patch corrects it by reading hotplug > > > status with 4 times at most for 30ms delay. > > > > > > v2: > > > - straight up to loop execution for more clear in code readability > > > - mdelay will replace with msleep by Daniel's new patch > > > > > > drm/i915: mdelay(10) considered harmful > > > > > > - suggest to re-evaluate try times for being compatible to old > > > HDMI monitor > > > > > > Reviewed-by: Cooper Chiou <cooper.chiou@intel.com> > > > Tested-by: Gary Wang <gary.c.wang@intel.com> > > > Cc: Jani Nikula <jani.nikula@linux.intel.com> > > > Cc: Daniel Vetter <daniel@ffwll.ch> > > > Cc: Gavin Hindman <gavin.hindman@intel.com> > > > Cc: Sonika Jindal <sonika.jindal@intel.com> > > > Cc: Shashank Sharma <shashank.sharma@intel.com> > > > Signed-off-by: Gary Wang <gary.c.wang@intel.com> > > > > Queued for -next (including cc: fixes), thanks for the patch. > > Using mdelay() or fixed to use msleep()? msleep patch was merged already, I just had to resolve the conflict. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2015-12-22 2:54 UTC | newest] Thread overview: 9+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2015-12-14 9:38 [PATCH v2] drm/i915: Correct max delay for HDMI hotplug live status checking Gary Wang 2015-12-14 11:29 ` Jani Nikula 2015-12-15 2:30 ` Wang, Gary C 2015-12-15 4:40 ` Gary Wang 2015-12-18 1:21 ` Wang, Gary C 2015-12-21 10:29 ` Daniel Vetter 2015-12-21 10:37 ` Chris Wilson 2015-12-21 11:52 ` Daniel Vetter 2015-12-22 2:54 ` Wang, Gary C
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).