public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Intel graphics driver community testing & development
	<intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH 4/6] drm/i915: Add i915.debug parameter
Date: Fri, 18 Dec 2015 12:01:41 +0200	[thread overview]
Message-ID: <1450432901.4143.3.camel@linux.intel.com> (raw)
In-Reply-To: <20151217210217.GD29834@nuc-i3427.alporthouse.com>

On to, 2015-12-17 at 21:02 +0000, Chris Wilson wrote:
> On Thu, Dec 17, 2015 at 09:25:49PM +0200, Joonas Lahtinen wrote:
> > Add i915.debug parameter to control output in cases where the debug
> > output
> > amount will be massive and as such is unsuitable for everyday use,
> > but still
> > significant in value when solving bugs.
> > 
> > Cc: Chris Wilson <chris@chris-wilson.co.uk>
> > Signed-off-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
> 
> Maybe i915.verbose_checks ?
> 
> Too similar to i915.verbose_state_checks though?
> 
> Just trying to differentiate from drm.debug which we will also be
> settings.

As discussed in IRC, I will go with WARN_RECUR and i915.warn_recurring,
those can potentially be pushed upstream all the way to kernel core.

Regards, Joonas

> -Chris
> 
-- 
Joonas Lahtinen
Open Source Technology Center
Intel Corporation

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2015-12-18 10:01 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-17 19:25 [RFC][PATCH 0/6] Optionally display recurring warning messages Joonas Lahtinen
2015-12-17 19:25 ` [PATCH 1/6] drm/i915: Compile time concatenate WARN_ON macro strings Joonas Lahtinen
2015-12-18  9:28   ` Chris Wilson
2015-12-17 19:25 ` [PATCH 2/6] drm/i915: Decouple struct i915_params i915 into i915_params.h Joonas Lahtinen
2015-12-17 20:59   ` Chris Wilson
2015-12-18  9:21     ` Chris Wilson
2015-12-17 19:25 ` [PATCH 3/6] drm/i915: Reorder i915_params struct Joonas Lahtinen
2015-12-17 21:00   ` Chris Wilson
2015-12-17 19:25 ` [PATCH 4/6] drm/i915: Add i915.debug parameter Joonas Lahtinen
2015-12-17 21:02   ` Chris Wilson
2015-12-18 10:01     ` Joonas Lahtinen [this message]
2015-12-17 19:25 ` [PATCH 5/6] drm/i915: Add helpers to reduce (repetitive) noise Joonas Lahtinen
2015-12-17 21:10   ` Chris Wilson
2015-12-18  8:20     ` Joonas Lahtinen
2015-12-17 19:25 ` [PATCH 6/6] drm/i915: Use I915_WARN_RECUR for recurring warning messages Joonas Lahtinen
2015-12-18  8:20 ` ✗ warning: Fi.CI.BAT Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1450432901.4143.3.camel@linux.intel.com \
    --to=joonas.lahtinen@linux.intel.com \
    --cc=chris@chris-wilson.co.uk \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox