Re: [PATCH] drm/i915: Update Skylake DDI translation table for HDMI.

["Vivi, Rodrigo" <rodrigo.vivi@intel.com>]

On Tue, 2016-01-05 at 20:39 +0200, Ville Syrjälä wrote:
> On Tue, Jan 05, 2016 at 07:32:59AM -0800, Rodrigo Vivi wrote:
> > When debuging an intermittent corrupted screen I suspected on DDI
> > translation table and checked we are out of date with the spec.
> > 
> > I'm not sure this will fix my bug yet, but it is always good to
> > follow
> > the spec.
> > 
> > Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
> > ---
> >  drivers/gpu/drm/i915/intel_ddi.c | 20 ++++++++++----------
> >  1 file changed, 10 insertions(+), 10 deletions(-)
> > 
> > diff --git a/drivers/gpu/drm/i915/intel_ddi.c
> > b/drivers/gpu/drm/i915/intel_ddi.c
> > index e6408e5..c7e3114 100644
> > --- a/drivers/gpu/drm/i915/intel_ddi.c
> > +++ b/drivers/gpu/drm/i915/intel_ddi.c
> > @@ -225,27 +225,27 @@ static const struct ddi_buf_trans
> > skl_ddi_translations_hdmi[] = {
> >  	{ 0x00007011, 0x00000088, 0x0 },
> >  	{ 0x00000018, 0x000000A1, 0x0 },
> >  	{ 0x00000018, 0x00000098, 0x0 },
> > -	{ 0x00004013, 0x00000088, 0x0 },
> > -	{ 0x00006012, 0x00000087, 0x0 },
> > +	{ 0x00004013, 0x00000088, 0x1 },
>                                   ^^^
> 
> 0x0
> 
> > +	{ 0x80006012, 0x000000CD, 0x0 },
>                                   ^^^
> 0x1

Thanks

> 
> The rest looks fine.
> 
> >  	{ 0x00000018, 0x000000DF, 0x0 },
> > -	{ 0x00003015, 0x00000087, 0x0 },	/* Default */
> > -	{ 0x00003015, 0x000000C7, 0x0 },
> > -	{ 0x00000018, 0x000000C7, 0x0 },
> > +	{ 0x80003015, 0x000000CD, 0x1 },	/* Default */
> > +	{ 0x80003015, 0x000000C0, 0x1 },
> > +	{ 0x80000018, 0x000000C0, 0x1 },
> >  };
> >  
> >  /* Skylake Y */
> >  static const struct ddi_buf_trans skl_y_ddi_translations_hdmi[] =
> > {
> >  	{ 0x00000018, 0x000000A1, 0x0 },
> >  	{ 0x00005012, 0x000000DF, 0x0 },
> > -	{ 0x00007011, 0x00000084, 0x0 },
> > +	{ 0x80007011, 0x000000CB, 0x3 },
> >  	{ 0x00000018, 0x000000A4, 0x0 },
> >  	{ 0x00000018, 0x0000009D, 0x0 },
> >  	{ 0x00004013, 0x00000080, 0x0 },
> > -	{ 0x00006013, 0x000000C7, 0x0 },
> > +	{ 0x80006013, 0x000000C0, 0x3 },
> >  	{ 0x00000018, 0x0000008A, 0x0 },
> > -	{ 0x00003015, 0x000000C7, 0x0 },	/* Default */
> > -	{ 0x80003015, 0x000000C7, 0x7 },	/* Uses I_boost
> > level 0x7 */
> 
> Since you're removing this pointless "Uses I_boost..." comment,
> maybe remove all such comments as a followup?

good idea. I will...
> 
> > -	{ 0x00000018, 0x000000C7, 0x0 },
> > +	{ 0x80003015, 0x000000C0, 0x3 },	/* Default */
> > +	{ 0x80003015, 0x000000C0, 0x3 },
> > +	{ 0x80000018, 0x000000C0, 0x3 },
> >  };
> >  
> >  struct bxt_ddi_buf_trans {
> > -- 
> > 2.4.3
> > 
> > _______________________________________________
> > Intel-gfx mailing list
> > Intel-gfx@lists.freedesktop.org
> > http://lists.freedesktop.org/mailman/listinfo/intel-gfx
> 
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx