From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mika Kahola Subject: Re: [PATCH v2 2/6] drm/i915: move VBT based LVDS presence check to intel_bios.c Date: Thu, 14 Jan 2016 14:52:17 +0200 Message-ID: <1452775937.4104.27.camel@sorvi> References: <0323f70aa048b8c236ad25dba58eafdd77513edb.1452541881.git.jani.nikula@intel.com> Reply-To: mika.kahola@intel.com Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by gabe.freedesktop.org (Postfix) with ESMTP id AE2266E038 for ; Thu, 14 Jan 2016 04:50:58 -0800 (PST) In-Reply-To: <0323f70aa048b8c236ad25dba58eafdd77513edb.1452541881.git.jani.nikula@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Jani Nikula Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gTW9uLCAyMDE2LTAxLTExIGF0IDIxOjU0ICswMjAwLCBKYW5pIE5pa3VsYSB3cm90ZToKPiBI aWRlIGtub3dsZWRnZSBhYm91dCBWQlQgY2hpbGQgZGV2aWNlcyBpbiBpbnRlbF9iaW9zLmMuCj4g ClRlc3RlZC1ieTogTWlrYSBLYWhvbGEgPG1pa2Eua2Fob2xhQGludGVsLmNvbT4KPiBTaWduZWQt b2ZmLWJ5OiBKYW5pIE5pa3VsYSA8amFuaS5uaWt1bGFAaW50ZWwuY29tPgo+IC0tLQo+ICBkcml2 ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2Rydi5oICAgfCAgMSArCj4gIGRyaXZlcnMvZ3B1L2RybS9p OTE1L2ludGVsX2Jpb3MuYyB8IDUwICsrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysr Kwo+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9sdmRzLmMgfCA1MyArLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0KPiAgMyBmaWxlcyBjaGFuZ2VkLCA1MiBpbnNlcnRp b25zKCspLCA1MiBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJt L2k5MTUvaTkxNV9kcnYuaCBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZHJ2LmgKPiBpbmRl eCAzODIyYzQ2NWQzZGMuLjVmMGQ0NGIzODBhYSAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9k cm0vaTkxNS9pOTE1X2Rydi5oCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kcnYu aAo+IEBAIC0zMzQ4LDYgKzMzNDgsNyBAQCBleHRlcm4gdm9pZCBpbnRlbF9pMmNfcmVzZXQoc3Ry dWN0IGRybV9kZXZpY2UgKmRldik7Cj4gIGludCBpbnRlbF9iaW9zX2luaXQoc3RydWN0IGRybV9p OTE1X3ByaXZhdGUgKmRldl9wcml2KTsKPiAgYm9vbCBpbnRlbF9iaW9zX2lzX3ZhbGlkX3ZidChj b25zdCB2b2lkICpidWYsIHNpemVfdCBzaXplKTsKPiAgYm9vbCBpbnRlbF9iaW9zX2lzX3R2X3By ZXNlbnQoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2KTsKPiArYm9vbCBpbnRlbF9i aW9zX2lzX2x2ZHNfcHJlc2VudChzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYsIHU4 ICppMmNfcGluKTsKPiAgCj4gIC8qIGludGVsX29wcmVnaW9uLmMgKi8KPiAgI2lmZGVmIENPTkZJ R19BQ1BJCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Jpb3MuYyBi L2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Jpb3MuYwo+IGluZGV4IGJiOWU4YjA4NmI2My4u MDk5ZjNmMDAwMmEyIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Jp b3MuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Jpb3MuYwo+IEBAIC0xNDUz LDMgKzE0NTMsNTMgQEAgYm9vbCBpbnRlbF9iaW9zX2lzX3R2X3ByZXNlbnQoc3RydWN0IGRybV9p OTE1X3ByaXZhdGUgKmRldl9wcml2KQo+ICAKPiAgCXJldHVybiBmYWxzZTsKPiAgfQo+ICsKPiAr LyoqCj4gKyAqIGludGVsX2Jpb3NfaXNfbHZkc19wcmVzZW50IC0gaXMgTFZEUyBwcmVzZW50IGlu IFZCVAo+ICsgKiBAZGV2X3ByaXY6CWk5MTUgZGV2aWNlIGluc3RhbmNlCj4gKyAqIEBpMmNfcGlu OglpMmMgcGluIGZvciBMVkRTIGlmIHByZXNlbnQKPiArICoKPiArICogUmV0dXJuIHRydWUgaWYg TFZEUyBpcyBwcmVzZW50LiBJZiBubyBjaGlsZCBkZXZpY2VzIHdlcmUgcGFyc2VkIGZyb20gVkJU LAo+ICsgKiBhc3N1bWUgTFZEUyBpcyBwcmVzZW50Lgo+ICsgKi8KPiArYm9vbCBpbnRlbF9iaW9z X2lzX2x2ZHNfcHJlc2VudChzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYsIHU4ICpp MmNfcGluKQo+ICt7Cj4gKwlpbnQgaTsKPiArCj4gKwlpZiAoIWRldl9wcml2LT52YnQuY2hpbGRf ZGV2X251bSkKPiArCQlyZXR1cm4gdHJ1ZTsKPiArCj4gKwlmb3IgKGkgPSAwOyBpIDwgZGV2X3By aXYtPnZidC5jaGlsZF9kZXZfbnVtOyBpKyspIHsKPiArCQl1bmlvbiBjaGlsZF9kZXZpY2VfY29u ZmlnICp1Y2hpbGQgPSBkZXZfcHJpdi0+dmJ0LmNoaWxkX2RldiArIGk7Cj4gKwkJc3RydWN0IG9s ZF9jaGlsZF9kZXZfY29uZmlnICpjaGlsZCA9ICZ1Y2hpbGQtPm9sZDsKPiArCj4gKwkJLyogSWYg dGhlIGRldmljZSB0eXBlIGlzIG5vdCBMRlAsIGNvbnRpbnVlLgo+ICsJCSAqIFdlIGhhdmUgdG8g Y2hlY2sgYm90aCB0aGUgbmV3IGlkZW50aWZpZXJzIGFzIHdlbGwgYXMgdGhlCj4gKwkJICogb2xk IGZvciBjb21wYXRpYmlsaXR5IHdpdGggc29tZSBCSU9TZXMuCj4gKwkJICovCj4gKwkJaWYgKGNo aWxkLT5kZXZpY2VfdHlwZSAhPSBERVZJQ0VfVFlQRV9JTlRfTEZQICYmCj4gKwkJICAgIGNoaWxk LT5kZXZpY2VfdHlwZSAhPSBERVZJQ0VfVFlQRV9MRlApCj4gKwkJCWNvbnRpbnVlOwo+ICsKPiAr CQlpZiAoaW50ZWxfZ21idXNfaXNfdmFsaWRfcGluKGRldl9wcml2LCBjaGlsZC0+aTJjX3Bpbikp Cj4gKwkJCSppMmNfcGluID0gY2hpbGQtPmkyY19waW47Cj4gKwo+ICsJCS8qIEhvd2V2ZXIsIHdl IGNhbm5vdCB0cnVzdCB0aGUgQklPUyB3cml0ZXJzIHRvIHBvcHVsYXRlCj4gKwkJICogdGhlIFZC VCBjb3JyZWN0bHkuICBTaW5jZSBMVkRTIHJlcXVpcmVzIGFkZGl0aW9uYWwKPiArCQkgKiBpbmZv cm1hdGlvbiBmcm9tIEFJTSBibG9ja3MsIGEgbm9uLXplcm8gYWRkaW4gb2Zmc2V0IGlzCj4gKwkJ ICogYSBnb29kIGluZGljYXRvciB0aGF0IHRoZSBMVkRTIGlzIGFjdHVhbGx5IHByZXNlbnQuCj4g KwkJICovCj4gKwkJaWYgKGNoaWxkLT5hZGRpbl9vZmZzZXQpCj4gKwkJCXJldHVybiB0cnVlOwo+ ICsKPiArCQkvKiBCdXQgZXZlbiB0aGVuIHNvbWUgQklPUyB3cml0ZXJzIHBlcmZvcm0gc29tZSBi bGFjayBtYWdpYwo+ICsJCSAqIGFuZCBpbnN0YW50aWF0ZSB0aGUgZGV2aWNlIHdpdGhvdXQgcmVm ZXJlbmNlIHRvIGFueQo+ICsJCSAqIGFkZGl0aW9uYWwgZGF0YS4gIFRydXN0IHRoYXQgaWYgdGhl IFZCVCB3YXMgd3JpdHRlbiBpbnRvCj4gKwkJICogdGhlIE9wUmVnaW9uIHRoZW4gdGhleSBoYXZl IHZhbGlkYXRlZCB0aGUgTFZEUydzIGV4aXN0ZW5jZS4KPiArCQkgKi8KPiArCQlpZiAoZGV2X3By aXYtPm9wcmVnaW9uLnZidCkKPiArCQkJcmV0dXJuIHRydWU7Cj4gKwl9Cj4gKwo+ICsJcmV0dXJu IGZhbHNlOwo+ICt9Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2x2 ZHMuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2x2ZHMuYwo+IGluZGV4IDBkYTAyNDBj YWY4MS4uODBmODY4NGU1MTM3IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2lu dGVsX2x2ZHMuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2x2ZHMuYwo+IEBA IC03NzIsNTcgKzc3Miw2IEBAIHN0YXRpYyBjb25zdCBzdHJ1Y3QgZG1pX3N5c3RlbV9pZCBpbnRl bF9ub19sdmRzW10gPSB7Cj4gIAl7IH0JLyogdGVybWluYXRpbmcgZW50cnkgKi8KPiAgfTsKPiAg Cj4gLS8qCj4gLSAqIEVudW1lcmF0ZSB0aGUgY2hpbGQgZGV2IGFycmF5IHBhcnNlZCBmcm9tIFZC VCB0byBjaGVjayB3aGV0aGVyCj4gLSAqIHRoZSBMVkRTIGlzIHByZXNlbnQuCj4gLSAqIElmIGl0 IGlzIHByZXNlbnQsIHJldHVybiAxLgo+IC0gKiBJZiBpdCBpcyBub3QgcHJlc2VudCwgcmV0dXJu IGZhbHNlLgo+IC0gKiBJZiBubyBjaGlsZCBkZXYgaXMgcGFyc2VkIGZyb20gVkJULCBpdCBhc3N1 bWVzIHRoYXQgdGhlIExWRFMgaXMgcHJlc2VudC4KPiAtICovCj4gLXN0YXRpYyBib29sIGx2ZHNf aXNfcHJlc2VudF9pbl92YnQoc3RydWN0IGRybV9kZXZpY2UgKmRldiwKPiAtCQkJCSAgIHU4ICpp MmNfcGluKQo+IC17Cj4gLQlzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYgPSBkZXYt PmRldl9wcml2YXRlOwo+IC0JaW50IGk7Cj4gLQo+IC0JaWYgKCFkZXZfcHJpdi0+dmJ0LmNoaWxk X2Rldl9udW0pCj4gLQkJcmV0dXJuIHRydWU7Cj4gLQo+IC0JZm9yIChpID0gMDsgaSA8IGRldl9w cml2LT52YnQuY2hpbGRfZGV2X251bTsgaSsrKSB7Cj4gLQkJdW5pb24gY2hpbGRfZGV2aWNlX2Nv bmZpZyAqdWNoaWxkID0gZGV2X3ByaXYtPnZidC5jaGlsZF9kZXYgKyBpOwo+IC0JCXN0cnVjdCBv bGRfY2hpbGRfZGV2X2NvbmZpZyAqY2hpbGQgPSAmdWNoaWxkLT5vbGQ7Cj4gLQo+IC0JCS8qIElm IHRoZSBkZXZpY2UgdHlwZSBpcyBub3QgTEZQLCBjb250aW51ZS4KPiAtCQkgKiBXZSBoYXZlIHRv IGNoZWNrIGJvdGggdGhlIG5ldyBpZGVudGlmaWVycyBhcyB3ZWxsIGFzIHRoZQo+IC0JCSAqIG9s ZCBmb3IgY29tcGF0aWJpbGl0eSB3aXRoIHNvbWUgQklPU2VzLgo+IC0JCSAqLwo+IC0JCWlmIChj aGlsZC0+ZGV2aWNlX3R5cGUgIT0gREVWSUNFX1RZUEVfSU5UX0xGUCAmJgo+IC0JCSAgICBjaGls ZC0+ZGV2aWNlX3R5cGUgIT0gREVWSUNFX1RZUEVfTEZQKQo+IC0JCQljb250aW51ZTsKPiAtCj4g LQkJaWYgKGludGVsX2dtYnVzX2lzX3ZhbGlkX3BpbihkZXZfcHJpdiwgY2hpbGQtPmkyY19waW4p KQo+IC0JCQkqaTJjX3BpbiA9IGNoaWxkLT5pMmNfcGluOwo+IC0KPiAtCQkvKiBIb3dldmVyLCB3 ZSBjYW5ub3QgdHJ1c3QgdGhlIEJJT1Mgd3JpdGVycyB0byBwb3B1bGF0ZQo+IC0JCSAqIHRoZSBW QlQgY29ycmVjdGx5LiAgU2luY2UgTFZEUyByZXF1aXJlcyBhZGRpdGlvbmFsCj4gLQkJICogaW5m b3JtYXRpb24gZnJvbSBBSU0gYmxvY2tzLCBhIG5vbi16ZXJvIGFkZGluIG9mZnNldCBpcwo+IC0J CSAqIGEgZ29vZCBpbmRpY2F0b3IgdGhhdCB0aGUgTFZEUyBpcyBhY3R1YWxseSBwcmVzZW50Lgo+ IC0JCSAqLwo+IC0JCWlmIChjaGlsZC0+YWRkaW5fb2Zmc2V0KQo+IC0JCQlyZXR1cm4gdHJ1ZTsK PiAtCj4gLQkJLyogQnV0IGV2ZW4gdGhlbiBzb21lIEJJT1Mgd3JpdGVycyBwZXJmb3JtIHNvbWUg YmxhY2sgbWFnaWMKPiAtCQkgKiBhbmQgaW5zdGFudGlhdGUgdGhlIGRldmljZSB3aXRob3V0IHJl ZmVyZW5jZSB0byBhbnkKPiAtCQkgKiBhZGRpdGlvbmFsIGRhdGEuICBUcnVzdCB0aGF0IGlmIHRo ZSBWQlQgd2FzIHdyaXR0ZW4gaW50bwo+IC0JCSAqIHRoZSBPcFJlZ2lvbiB0aGVuIHRoZXkgaGF2 ZSB2YWxpZGF0ZWQgdGhlIExWRFMncyBleGlzdGVuY2UuCj4gLQkJICovCj4gLQkJaWYgKGRldl9w cml2LT5vcHJlZ2lvbi52YnQpCj4gLQkJCXJldHVybiB0cnVlOwo+IC0JfQo+IC0KPiAtCXJldHVy biBmYWxzZTsKPiAtfQo+IC0KPiAgc3RhdGljIGludCBpbnRlbF9kdWFsX2xpbmtfbHZkc19jYWxs YmFjayhjb25zdCBzdHJ1Y3QgZG1pX3N5c3RlbV9pZCAqaWQpCj4gIHsKPiAgCURSTV9JTkZPKCJG b3JjaW5nIGx2ZHMgdG8gZHVhbCBsaW5rIG1vZGUgb24gJXNcbiIsIGlkLT5pZGVudCk7Cj4gQEAg LTk3OSw3ICs5MjgsNyBAQCB2b2lkIGludGVsX2x2ZHNfaW5pdChzdHJ1Y3QgZHJtX2RldmljZSAq ZGV2KQo+ICAJfQo+ICAKPiAgCXBpbiA9IEdNQlVTX1BJTl9QQU5FTDsKPiAtCWlmICghbHZkc19p c19wcmVzZW50X2luX3ZidChkZXYsICZwaW4pKSB7Cj4gKwlpZiAoIWludGVsX2Jpb3NfaXNfbHZk c19wcmVzZW50KGRldl9wcml2LCAmcGluKSkgewo+ICAJCWlmICgobHZkcyAmIExWRFNfUE9SVF9F TikgPT0gMCkgewo+ICAJCQlEUk1fREVCVUdfS01TKCJMVkRTIGlzIG5vdCBwcmVzZW50IGluIFZC VFxuIik7Cj4gIAkJCXJldHVybjsKCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVl ZGVza3RvcC5vcmcKaHR0cDovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZv L2ludGVsLWdmeAo=