public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Jani Nikula <jani.nikula@intel.com>
To: "Bjørn Mork" <bjorn@mork.no>, "Gerd Hoffmann" <kraxel@redhat.com>
Cc: Daniel Vetter <daniel.vetter@intel.com>,
	Jani Nikula <jani.nikula@linux.intel.com>,
	intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: [PATCH] Revert "drm/i915: more virtual south bridge detection"
Date: Mon, 25 Jan 2016 10:26:00 +0200	[thread overview]
Message-ID: <1453710360-30099-1-git-send-email-jani.nikula@intel.com> (raw)
In-Reply-To: <87y4bes74m.fsf@nemi.mork.no>

This reverts

commit 39bfcd5235e07e95ad3e70eab8e0b85db181de9e
Author: Gerd Hoffmann <kraxel@redhat.com>
Date:   Thu Nov 26 12:03:51 2015 +0100

    drm/i915: more virtual south bridge detection

because it mistakes real physical south bridges for virtual ones.

Reported-by: Bjørn Mork <bjorn@mork.no>
Reference: http://mid.gmane.org/87y4bes74m.fsf@nemi.mork.no
Cc: Gerd Hoffmann <kraxel@redhat.com>
Fixes: 39bfcd5235e0 ("drm/i915: more virtual south bridge detection")
Signed-off-by: Jani Nikula <jani.nikula@intel.com>

---

Bjørn, please provide your Tested-by.

Gerd, back to the drawing board, I'm afraid.
---
 drivers/gpu/drm/i915/i915_drv.c | 3 +--
 drivers/gpu/drm/i915/i915_drv.h | 1 -
 2 files changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c
index 706b8eabfaf4..a702262daefc 100644
--- a/drivers/gpu/drm/i915/i915_drv.c
+++ b/drivers/gpu/drm/i915/i915_drv.c
@@ -500,8 +500,7 @@ void intel_detect_pch(struct drm_device *dev)
 				DRM_DEBUG_KMS("Found SunrisePoint LP PCH\n");
 				WARN_ON(!IS_SKYLAKE(dev) &&
 					!IS_KABYLAKE(dev));
-			} else if ((id == INTEL_PCH_P2X_DEVICE_ID_TYPE) ||
-				   (id == INTEL_PCH_QEMU_DEVICE_ID_TYPE)) {
+			} else if (id == INTEL_PCH_P2X_DEVICE_ID_TYPE) {
 				dev_priv->pch_type = intel_virt_detect_pch(dev);
 			} else
 				continue;
diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h
index afb0beee9975..1c06661ebf08 100644
--- a/drivers/gpu/drm/i915/i915_drv.h
+++ b/drivers/gpu/drm/i915/i915_drv.h
@@ -2645,7 +2645,6 @@ struct drm_i915_cmd_table {
 #define INTEL_PCH_SPT_DEVICE_ID_TYPE		0xA100
 #define INTEL_PCH_SPT_LP_DEVICE_ID_TYPE		0x9D00
 #define INTEL_PCH_P2X_DEVICE_ID_TYPE		0x7100
-#define INTEL_PCH_QEMU_DEVICE_ID_TYPE		0x2900 /* qemu q35 has 2918 */
 
 #define INTEL_PCH_TYPE(dev) (__I915__(dev)->pch_type)
 #define HAS_PCH_SPT(dev) (INTEL_PCH_TYPE(dev) == PCH_SPT)
-- 
2.1.4

  reply	other threads:[~2016-01-25  8:26 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-25  2:52 Regression in v4.5-rc1, bisected to commit 39bfcd5235e0 ("drm/i915: more virtual south bridge detection") Bjørn Mork
2016-01-25  8:26 ` Jani Nikula [this message]
2016-01-25  9:18   ` [PATCH] Revert "drm/i915: more virtual south bridge detection" Bjørn Mork
2016-01-25  8:54 ` ✗ Fi.CI.BAT: failure for " Patchwork
2016-01-25 15:49 ` Regression in v4.5-rc1, bisected to commit 39bfcd5235e0 ("drm/i915: more virtual south bridge detection") Bruno Wolff III
2016-01-26 10:49 ` Harald Arnesen
2016-01-26 11:59 ` Harald Arnesen
2016-01-28  8:00 ` ✓ Fi.CI.BAT: success for Revert "drm/i915: more virtual south bridge detection" Patchwork
2016-01-28  8:12 ` Patchwork
2016-01-28 13:12 ` Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1453710360-30099-1-git-send-email-jani.nikula@intel.com \
    --to=jani.nikula@intel.com \
    --cc=bjorn@mork.no \
    --cc=daniel.vetter@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=jani.nikula@linux.intel.com \
    --cc=kraxel@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox