From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ander Conselvan De Oliveira Subject: Re: [PATCH 2/5] drm/i915: Cleaning up intel_dp_hpd_pulse Date: Tue, 26 Jan 2016 15:22:50 +0200 Message-ID: <1453814570.2695.18.camel@gmail.com> References: <1453199833-10401-1-git-send-email-shubhangi.shrivastava@intel.com> <1453199833-10401-2-git-send-email-shubhangi.shrivastava@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-pf0-f172.google.com (mail-pf0-f172.google.com [209.85.192.172]) by gabe.freedesktop.org (Postfix) with ESMTPS id 43F437207A for ; Tue, 26 Jan 2016 05:22:57 -0800 (PST) Received: by mail-pf0-f172.google.com with SMTP id 65so11449442pfd.2 for ; Tue, 26 Jan 2016 05:22:57 -0800 (PST) In-Reply-To: <1453199833-10401-2-git-send-email-shubhangi.shrivastava@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Shubhangi Shrivastava , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gVHVlLCAyMDE2LTAxLTE5IGF0IDE2OjA3ICswNTMwLCBTaHViaGFuZ2kgU2hyaXZhc3RhdmEg d3JvdGU6Cj4gQ3VycmVudCBEUCBkZXRlY3Rpb24gaGFzIERQQ0Qgb3BlcmF0aW9ucyBzcGxpdCBh Y3Jvc3MKPiBpbnRlbF9kcF9ocGRfcHVsc2UgYW5kIGludGVsX2RwX2RldGVjdCB3aGljaCBjb250 YWlucwo+IGR1cGxpY2F0ZXMgYXMgd2VsbC4gQWxzbyBpbnRlbF9kcF9kZXRlY3QgaXMgY2FsbGVk Cj4gZHVyaW5nIG1vZGVzIGVudW1lcmF0aW9uIGFzIHdlbGwgd2hpY2ggd2lsbCByZXN1bHQKPiBp biBtdWx0aXBsZSBkcGNkIG9wZXJhdGlvbnMuIFNvIHRoaXMgcGF0Y2ggdHJpZXMKPiB0byBzb2x2 ZSBib3RoIHRoZXNlIGJ5IGJyaW5naW5nIGFsbCBEUENEIG9wZXJhdGlvbnMKPiBpbiBvbmUgc2lu Z2xlIGZ1bmN0aW9uIGFuZCBtYWtlIGludGVsX2RwX2RldGVjdAo+IHVzZSBleGlzdGluZyB2YWx1 ZXMgaW5zdGVhZCBvZiByZXBlYXRpbmcgc2FtZSBzdGVwcy4KPiAKPiB2MjogUHVsbGVkIGluIGEg aHVuayBmcm9tIGxhc3QgcGF0Y2ggb2YgdGhlIHNlcmllcyB0bwo+ICAgICB0aGlzIHBhdGNoLiAo QW5kZXIpCj4gdjM6IEFkZGVkIE1TVCBob3RwbHVnIGhhbmRsaW5nLiAoQW5kZXIpCj4gCj4gVGVz dGVkLWJ5OiBOYXRoYW4gRCBDaW9iYW51IDxuYXRoYW4uZC5jaW9iYW51QGludGVsLmNvbT4KPiBT aWduZWQtb2ZmLWJ5OiBTaXZha3VtYXIgVGh1bGFzaW1hbmkgPHNpdmFrdW1hci50aHVsYXNpbWFu aUBpbnRlbC5jb20+Cj4gU2lnbmVkLW9mZi1ieTogU2h1YmhhbmdpIFNocml2YXN0YXZhIDxzaHVi aGFuZ2kuc2hyaXZhc3RhdmFAaW50ZWwuY29tPgo+IC0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vaTkx NS9pbnRlbF9kcC5jIHwgNzEgKysrKysrKysrKysrKysrKysrKysrKysrKy0tLS0tLS0tLS0tLS0t LQo+IC0KPiAgMSBmaWxlIGNoYW5nZWQsIDQ0IGluc2VydGlvbnMoKyksIDI3IGRlbGV0aW9ucygt KQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcC5jIGIvZHJp dmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHAuYwo+IGluZGV4IDg5NjlmZjkuLjgyZWUxOGQgMTAw NjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHAuYwo+ICsrKyBiL2RyaXZl cnMvZ3B1L2RybS9pOTE1L2ludGVsX2RwLmMKClsuLi5dCgo+IEBAIC00NjkzLDcgKzQ3MTcsOCBA QCBpbnRlbF9kcF9kZXRlY3Qoc3RydWN0IGRybV9jb25uZWN0b3IgKmNvbm5lY3RvciwgYm9vbAo+ IGZvcmNlKQo+ICAJCXJldHVybiBjb25uZWN0b3Jfc3RhdHVzX2Rpc2Nvbm5lY3RlZDsKPiAgCX0K PiAgCj4gLQlpbnRlbF9kcF9sb25nX3B1bHNlKGludGVsX2RwLT5hdHRhY2hlZF9jb25uZWN0b3Ip Owo+ICsJaWYgKGZvcmNlKQo+ICsJCWludGVsX2RwX2xvbmdfcHVsc2UoaW50ZWxfZHAtPmF0dGFj aGVkX2Nvbm5lY3Rvcik7CgpJIGRpZG4ndCBub3RpY2UgdGhpcyBhdCBmaXJzdCwgYnV0IGZvcmNl IGlzIG5vdCB0aGUgcmlnaHQgdGhpbmcgdG8gY2hlY2sgZm9yCmhlcmUuIEl0IGlzIGJhc2ljYWxs eSBpbnRlbmRlZCB0byBhdm9pZCBkb2luZyBsb2FkIGRldGVjdGlvbiAoc2VlCmludGVsX2dldF9s b2FkX2RldGVjdF9waXBlKCkpIG9uIGF1dG9tYXRlZCBwb2xsaW5nLiBCdXQgd2Ugc3RpbGwgaGF2 ZSB0byB0cnkKZGV0ZWN0aW9uIGhlcmUgd2hlbiBmb3JjZSA9IGZhbHNlLCBvdGhlcndpc2UgdGhp cyB3aWxsIGNhdXNlIGEgcmVncmVzc2lvbi4KCklmIHlvdSBwbHVnIGluIGEgRFAgZGV2aWNlIHdo aWxlIHN1c3BlbmRlZCwgdGhhdCBkZXZpY2Ugd29uJ3QgZ2V0IGRldGVjdGVkLApzaW5jZSB3ZSBk b24ndCBnZXQgYW4gSFBEIGZvciBpdC4gUHJldmlvdXNseSwgdGhlIGNhbGwgZG8gaW50ZWxfZHBf ZGV0ZWN0KCkgd2l0aApmb3JjZSA9IGZhbHNlIGZyb20gaW50ZWxfZHJtX3Jlc3VtZSgpICh2aWEg ZHJtX2hlbHBlcl9ocGRfaXJxX2V2ZW50KCkpIHdvdWxkCmNhdXNlIGEgZnVsbCBkZXRlY3Rpb24u CgpUbyBhdm9pZCB0aGUgcmVwZWF0ZWQgRFBDRCBvcGVyYXRpb25zLCBJIHRoaW5rIHdlIG5lZWQg YSBtb3JlIGV4cGxpY2l0IG1lY2hhbmlzbQp0byBzaWduYWwgdGhhdCB3ZSBhbHJlYWR5IGhhbmRs ZWQgdGhlIGxvbmcgcHVsc2UgdmlhIHRoZSBIUEQgaGFuZGxlci4gSW4KaW50ZWxfZHBfaHBkX3B1 bHNlKCkgd2UgY291bGQgc2V0IGEgZmxhZyB0aGF0IHRlbGxzIHdlIGp1c3QgaGFuZGxlZCBhIGxv bmcgcHVsc2UKZm9yIHRoZSBnaXZlbiBwb3J0LiBUaGUgY2FsbCB0byBpbnRlbF9kcF9sb25nX3B1 bHNlKCkgaW4gaW50ZWxfZHBfZGV0ZWN0KCkgd291bGQKdGhlbiBiZSBkZXBlbmRlbnQgb24gdGhh dCBmbGFnLgoKRm9yIHRoYXQgcmVhc29uIEkgaGF2ZSB0byByZXRyYWN0IG15IFItYiBmcm9tIHRo aXMgcGF0Y2guCgpBbmRlcgogCj4gIAlpZiAoaW50ZWxfY29ubmVjdG9yLT5kZXRlY3RfZWRpZCkK PiAgCQlyZXR1cm4gY29ubmVjdG9yX3N0YXR1c19jb25uZWN0ZWQ7Cj4gQEAgLTUwMjYsMjUgKzUw NTEsMjUgQEAgaW50ZWxfZHBfaHBkX3B1bHNlKHN0cnVjdCBpbnRlbF9kaWdpdGFsX3BvcnQKPiAq aW50ZWxfZGlnX3BvcnQsIGJvb2wgbG9uZ19ocGQpCj4gIAkJLyogaW5kaWNhdGUgdGhhdCB3ZSBu ZWVkIHRvIHJlc3RhcnQgbGluayB0cmFpbmluZyAqLwo+ICAJCWludGVsX2RwLT50cmFpbl9zZXRf dmFsaWQgPSBmYWxzZTsKPiAgCj4gLQkJaWYgKCFpbnRlbF9kaWdpdGFsX3BvcnRfY29ubmVjdGVk KGRldl9wcml2LCBpbnRlbF9kaWdfcG9ydCkpCj4gLQkJCWdvdG8gbXN0X2ZhaWw7Cj4gLQo+IC0J CWlmICghaW50ZWxfZHBfZ2V0X2RwY2QoaW50ZWxfZHApKSB7Cj4gLQkJCWdvdG8gbXN0X2ZhaWw7 Cj4gLQkJfQo+IC0KPiAtCQlpbnRlbF9kcF9wcm9iZV9vdWkoaW50ZWxfZHApOwo+ICsJCWludGVs X2RwX2xvbmdfcHVsc2UoaW50ZWxfZHAtPmF0dGFjaGVkX2Nvbm5lY3Rvcik7Cj4gKwkJaWYgKGlu dGVsX2RwLT5pc19tc3QpCj4gKwkJCXJldCA9IElSUV9IQU5ETEVEOwo+ICsJCWdvdG8gcHV0X3Bv d2VyOwo+ICAKPiAtCQlpZiAoIWludGVsX2RwX3Byb2JlX21zdChpbnRlbF9kcCkpIHsKPiAtCQkJ ZHJtX21vZGVzZXRfbG9jaygmZGV2LT5tb2RlX2NvbmZpZy5jb25uZWN0aW9uX211dGV4LAo+IE5V TEwpOwo+IC0JCQlpbnRlbF9kcF9jaGVja19saW5rX3N0YXR1cyhpbnRlbF9kcCk7Cj4gLQkJCWRy bV9tb2Rlc2V0X3VubG9jaygmZGV2Cj4gLT5tb2RlX2NvbmZpZy5jb25uZWN0aW9uX211dGV4KTsK PiAtCQkJZ290byBtc3RfZmFpbDsKPiAtCQl9Cj4gIAl9IGVsc2Ugewo+ICAJCWlmIChpbnRlbF9k cC0+aXNfbXN0KSB7Cj4gLQkJCWlmIChpbnRlbF9kcF9jaGVja19tc3Rfc3RhdHVzKGludGVsX2Rw KSA9PSAtRUlOVkFMKQo+IC0JCQkJZ290byBtc3RfZmFpbDsKPiArCQkJaWYgKGludGVsX2RwX2No ZWNrX21zdF9zdGF0dXMoaW50ZWxfZHApID09IC1FSU5WQUwpIHsKPiArCQkJCS8qCj4gKwkJCQkg KiBJZiB3ZSB3ZXJlIGluIE1TVCBtb2RlLCBhbmQgZGV2aWNlIGlzIG5vdAo+ICsJCQkJICogdGhl cmUsIGdldCBvdXQgb2YgTVNUIG1vZGUKPiArCQkJCSAqLwo+ICsJCQkJRFJNX0RFQlVHX0tNUygi TVNUIGRldmljZSBtYXkgaGF2ZQo+IGRpc2FwcGVhcmVkICVkIHZzICVkXG4iLAo+ICsJCQkJCWlu dGVsX2RwLT5pc19tc3QsIGludGVsX2RwCj4gLT5tc3RfbWdyLm1zdF9zdGF0ZSk7Cj4gKwkJCQlp bnRlbF9kcC0+aXNfbXN0ID0gZmFsc2U7Cj4gKwkJCQlkcm1fZHBfbXN0X3RvcG9sb2d5X21ncl9z ZXRfbXN0KCZpbnRlbF9kcAo+IC0+bXN0X21nciwKPiArCQkJCQkJCQlpbnRlbF9kcAo+IC0+aXNf bXN0KTsKPiArCQkJCWdvdG8gcHV0X3Bvd2VyOwo+ICsJCQl9Cj4gIAkJfQo+ICAKPiAgCQlpZiAo IWludGVsX2RwLT5pc19tc3QpIHsKPiBAQCAtNTA1NiwxNCArNTA4MSw2IEBAIGludGVsX2RwX2hw ZF9wdWxzZShzdHJ1Y3QgaW50ZWxfZGlnaXRhbF9wb3J0Cj4gKmludGVsX2RpZ19wb3J0LCBib29s IGxvbmdfaHBkKQo+ICAKPiAgCXJldCA9IElSUV9IQU5ETEVEOwo+ICAKPiAtCWdvdG8gcHV0X3Bv d2VyOwo+IC1tc3RfZmFpbDoKPiAtCS8qIGlmIHdlIHdlcmUgaW4gTVNUIG1vZGUsIGFuZCBkZXZp Y2UgaXMgbm90IHRoZXJlIGdldCBvdXQgb2YgTVNUCj4gbW9kZSAqLwo+IC0JaWYgKGludGVsX2Rw LT5pc19tc3QpIHsKPiAtCQlEUk1fREVCVUdfS01TKCJNU1QgZGV2aWNlIG1heSBoYXZlIGRpc2Fw cGVhcmVkICVkIHZzICVkXG4iLAo+IGludGVsX2RwLT5pc19tc3QsIGludGVsX2RwLT5tc3RfbWdy Lm1zdF9zdGF0ZSk7Cj4gLQkJaW50ZWxfZHAtPmlzX21zdCA9IGZhbHNlOwo+IC0JCWRybV9kcF9t c3RfdG9wb2xvZ3lfbWdyX3NldF9tc3QoJmludGVsX2RwLT5tc3RfbWdyLCBpbnRlbF9kcAo+IC0+ aXNfbXN0KTsKPiAtCX0KPiAgcHV0X3Bvd2VyOgo+ICAJaW50ZWxfZGlzcGxheV9wb3dlcl9wdXQo ZGV2X3ByaXYsIHBvd2VyX2RvbWFpbik7Cj4gIApfX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0 cy5mcmVlZGVza3RvcC5vcmcKaHR0cDovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xp c3RpbmZvL2ludGVsLWdmeAo=