* [PATCH] drm/i915/skl: Fix DMC load on Skylake J0 and K0
@ 2016-01-28 23:19 Mat Martineau
2016-01-28 23:26 ` Vivi, Rodrigo
2016-01-29 11:30 ` ✗ Fi.CI.BAT: failure for " Patchwork
0 siblings, 2 replies; 5+ messages in thread
From: Mat Martineau @ 2016-01-28 23:19 UTC (permalink / raw)
To: intel-gfx; +Cc: Rodrigo Vivi
The driver does not load firmware for unknown steppings, so these new
steppings must be added to the list.
Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
Signed-off-by: Mat Martineau <mathew.j.martineau@linux.intel.com>
---
drivers/gpu/drm/i915/intel_csr.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/intel_csr.c b/drivers/gpu/drm/i915/intel_csr.c
index 9bb63a8..450bab7 100644
--- a/drivers/gpu/drm/i915/intel_csr.c
+++ b/drivers/gpu/drm/i915/intel_csr.c
@@ -177,7 +177,8 @@ static const struct stepping_info kbl_stepping_info[] = {
static const struct stepping_info skl_stepping_info[] = {
{'A', '0'}, {'B', '0'}, {'C', '0'},
{'D', '0'}, {'E', '0'}, {'F', '0'},
- {'G', '0'}, {'H', '0'}, {'I', '0'}
+ {'G', '0'}, {'H', '0'}, {'I', '0'},
+ {'J', '0'}, {'K', '0'}
};
static const struct stepping_info bxt_stepping_info[] = {
--
2.7.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] drm/i915/skl: Fix DMC load on Skylake J0 and K0
2016-01-28 23:19 [PATCH] drm/i915/skl: Fix DMC load on Skylake J0 and K0 Mat Martineau
@ 2016-01-28 23:26 ` Vivi, Rodrigo
2016-02-01 16:01 ` Mat Martineau
2016-01-29 11:30 ` ✗ Fi.CI.BAT: failure for " Patchwork
1 sibling, 1 reply; 5+ messages in thread
From: Vivi, Rodrigo @ 2016-01-28 23:26 UTC (permalink / raw)
To: intel-gfx@lists.freedesktop.org,
mathew.j.martineau@linux.intel.com
First of all:
Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
I've checked with DMC folks that DMC 1.23 that we are currently using
and the following releases support J0 and K0.
With this patch we are covering all SKL steppings we know so far, but
besides being concern with new steppings appearing at any moment I'm
mostly concerned about KBL where I just saw a KBL revid=8 and we were
considering revid=0 as KBL H0. So I'm asking myself if we do have
better ways of handling this and preferably killing this table.
In case someone have a good idea please let me know.
But for now we need to move fast with this patch.
Thanks,
Rodrigo.
On Thu, 2016-01-28 at 15:19 -0800, Mat Martineau wrote:
> The driver does not load firmware for unknown steppings, so these new
> steppings must be added to the list.
>
> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> Signed-off-by: Mat Martineau <mathew.j.martineau@linux.intel.com>
> ---
> drivers/gpu/drm/i915/intel_csr.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_csr.c
> b/drivers/gpu/drm/i915/intel_csr.c
> index 9bb63a8..450bab7 100644
> --- a/drivers/gpu/drm/i915/intel_csr.c
> +++ b/drivers/gpu/drm/i915/intel_csr.c
> @@ -177,7 +177,8 @@ static const struct stepping_info
> kbl_stepping_info[] = {
> static const struct stepping_info skl_stepping_info[] = {
> {'A', '0'}, {'B', '0'}, {'C', '0'},
> {'D', '0'}, {'E', '0'}, {'F', '0'},
> - {'G', '0'}, {'H', '0'}, {'I', '0'}
> + {'G', '0'}, {'H', '0'}, {'I', '0'},
> + {'J', '0'}, {'K', '0'}
> };
>
> static const struct stepping_info bxt_stepping_info[] = {
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] drm/i915/skl: Fix DMC load on Skylake J0 and K0
2016-01-28 23:26 ` Vivi, Rodrigo
@ 2016-02-01 16:01 ` Mat Martineau
2016-02-01 17:00 ` Vivi, Rodrigo
0 siblings, 1 reply; 5+ messages in thread
From: Mat Martineau @ 2016-02-01 16:01 UTC (permalink / raw)
To: Vivi, Rodrigo, daniel.vetter; +Cc: intel-gfx@lists.freedesktop.org
Rodrigo and Daniel -
On Thu, 28 Jan 2016, Vivi, Rodrigo wrote:
>
> Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
>
> I've checked with DMC folks that DMC 1.23 that we are currently using
> and the following releases support J0 and K0.
>
> With this patch we are covering all SKL steppings we know so far, but
> besides being concern with new steppings appearing at any moment I'm
> mostly concerned about KBL where I just saw a KBL revid=8 and we were
> considering revid=0 as KBL H0. So I'm asking myself if we do have
> better ways of handling this and preferably killing this table.
>
> In case someone have a good idea please let me know.
>
> But for now we need to move fast with this patch.
Is this patch ready to merge?
Thanks,
Mat
> On Thu, 2016-01-28 at 15:19 -0800, Mat Martineau wrote:
>> The driver does not load firmware for unknown steppings, so these new
>> steppings must be added to the list.
>>
>> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
>> Signed-off-by: Mat Martineau <mathew.j.martineau@linux.intel.com>
>> ---
>> drivers/gpu/drm/i915/intel_csr.c | 3 ++-
>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/i915/intel_csr.c
>> b/drivers/gpu/drm/i915/intel_csr.c
>> index 9bb63a8..450bab7 100644
>> --- a/drivers/gpu/drm/i915/intel_csr.c
>> +++ b/drivers/gpu/drm/i915/intel_csr.c
>> @@ -177,7 +177,8 @@ static const struct stepping_info
>> kbl_stepping_info[] = {
>> static const struct stepping_info skl_stepping_info[] = {
>> {'A', '0'}, {'B', '0'}, {'C', '0'},
>> {'D', '0'}, {'E', '0'}, {'F', '0'},
>> - {'G', '0'}, {'H', '0'}, {'I', '0'}
>> + {'G', '0'}, {'H', '0'}, {'I', '0'},
>> + {'J', '0'}, {'K', '0'}
>> };
>>
>> static const struct stepping_info bxt_stepping_info[] = {
--
Mat Martineau
Intel OTC
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] drm/i915/skl: Fix DMC load on Skylake J0 and K0
2016-02-01 16:01 ` Mat Martineau
@ 2016-02-01 17:00 ` Vivi, Rodrigo
0 siblings, 0 replies; 5+ messages in thread
From: Vivi, Rodrigo @ 2016-02-01 17:00 UTC (permalink / raw)
To: mathew.j.martineau@linux.intel.com, Vetter, Daniel
Cc: intel-gfx@lists.freedesktop.org
On Mon, 2016-02-01 at 08:01 -0800, Mat Martineau wrote:
> Rodrigo and Daniel -
>
> On Thu, 28 Jan 2016, Vivi, Rodrigo wrote:
>
> >
> > Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
> >
> > I've checked with DMC folks that DMC 1.23 that we are currently
> > using
> > and the following releases support J0 and K0.
> >
> > With this patch we are covering all SKL steppings we know so far,
> > but
> > besides being concern with new steppings appearing at any moment
> > I'm
> > mostly concerned about KBL where I just saw a KBL revid=8 and we
> > were
> > considering revid=0 as KBL H0. So I'm asking myself if we do have
> > better ways of handling this and preferably killing this table.
> >
> > In case someone have a good idea please let me know.
> >
> > But for now we need to move fast with this patch.
>
>
> Is this patch ready to merge?
I just merged to -dinq.
Thanks,
Rodrigo.
>
> Thanks,
> Mat
>
>
> > On Thu, 2016-01-28 at 15:19 -0800, Mat Martineau wrote:
> > > The driver does not load firmware for unknown steppings, so these
> > > new
> > > steppings must be added to the list.
> > >
> > > Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> > > Signed-off-by: Mat Martineau <mathew.j.martineau@linux.intel.com>
> > > ---
> > > drivers/gpu/drm/i915/intel_csr.c | 3 ++-
> > > 1 file changed, 2 insertions(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/gpu/drm/i915/intel_csr.c
> > > b/drivers/gpu/drm/i915/intel_csr.c
> > > index 9bb63a8..450bab7 100644
> > > --- a/drivers/gpu/drm/i915/intel_csr.c
> > > +++ b/drivers/gpu/drm/i915/intel_csr.c
> > > @@ -177,7 +177,8 @@ static const struct stepping_info
> > > kbl_stepping_info[] = {
> > > static const struct stepping_info skl_stepping_info[] = {
> > > {'A', '0'}, {'B', '0'}, {'C', '0'},
> > > {'D', '0'}, {'E', '0'}, {'F', '0'},
> > > - {'G', '0'}, {'H', '0'}, {'I', '0'}
> > > + {'G', '0'}, {'H', '0'}, {'I', '0'},
> > > + {'J', '0'}, {'K', '0'}
> > > };
> > >
> > > static const struct stepping_info bxt_stepping_info[] = {
>
> --
> Mat Martineau
> Intel OTC
>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread
* ✗ Fi.CI.BAT: failure for drm/i915/skl: Fix DMC load on Skylake J0 and K0
2016-01-28 23:19 [PATCH] drm/i915/skl: Fix DMC load on Skylake J0 and K0 Mat Martineau
2016-01-28 23:26 ` Vivi, Rodrigo
@ 2016-01-29 11:30 ` Patchwork
1 sibling, 0 replies; 5+ messages in thread
From: Patchwork @ 2016-01-29 11:30 UTC (permalink / raw)
To: Mat Martineau; +Cc: intel-gfx
== Summary ==
Series 2908v1 drm/i915/skl: Fix DMC load on Skylake J0 and K0
http://patchwork.freedesktop.org/api/1.0/series/2908/revisions/1/mbox/
Test kms_pipe_crc_basic:
Subgroup nonblocking-crc-pipe-a:
skip -> PASS (byt-nuc)
bdw-nuci7 total:156 pass:147 dwarn:0 dfail:0 fail:0 skip:9
bdw-ultra total:159 pass:147 dwarn:0 dfail:0 fail:0 skip:12
bsw-nuc-2 total:159 pass:129 dwarn:0 dfail:0 fail:0 skip:30
byt-nuc total:159 pass:136 dwarn:0 dfail:0 fail:0 skip:23
hsw-brixbox total:159 pass:146 dwarn:0 dfail:0 fail:0 skip:13
hsw-gt2 total:159 pass:149 dwarn:0 dfail:0 fail:0 skip:10
ilk-hp8440p total:159 pass:111 dwarn:0 dfail:0 fail:0 skip:48
skl-i5k-2 total:159 pass:144 dwarn:1 dfail:0 fail:0 skip:14
snb-dellxps total:159 pass:137 dwarn:0 dfail:0 fail:0 skip:22
snb-x220t total:159 pass:137 dwarn:0 dfail:0 fail:1 skip:21
HANGED ivb-t430s in Patchwork_1317/ivb-t430s/tests/0.json:igt@gem_mmap_gtt@basic-short Patchwork_1317/ivb-t430s/tests/10.json:igt@gem_sync@basic-bsd2 Patchwork_1317/ivb-t430s/tests/11.json:igt@gem_sync@basic-bsd1 Patchwork_1317/ivb-t430s/tests/12.json:igt@gem_tiled_blits@basic Patchwork_1317/ivb-t430s/tests/13.json:igt@gem_flink_basic@double-flink Patchwork_1317/ivb-t430s/tests/14.json:igt@kms_addfb_basic@addfb25-framebuffer-vs-set-tiling Patchwork_1317/ivb-t430s/tests/15.json:igt@gem_ringfill@basic-default Patchwork_1317/ivb-t430s/tests/16.json:igt@gem_storedw_loop@basic-default Patchwork_1317/ivb-t430s/tests/17.json:igt@gem_mmap_gtt@basic-write-gtt-no-prefault Patchwork_1317/ivb-t430s/tests/18.json:igt@pm_backlight@basic-brightness Patchwork_1317/ivb-t430s/tests/19.json:igt@kms_flip@basic-flip-vs-wf_vblank Patchwork_1317/ivb-t430s/tests/1.json:igt@gem_tiled_fence_blits@basic Patchwork_1317/ivb-t430s/tests/20.json:igt@gem_ctx_param_basic@invalid-size-get Patchwork_1317/ivb-t430s/tes
ts/21.json:igt@gem_storedw_loop@basic-render Patchwork_1317/ivb-t430s/tests/22.json:igt@kms_pipe_crc_basic@read-crc-pipe-c-frame-sequence Patchwork_1317/ivb-t430s/tests/23.json:igt@gem_exec_basic@basic-vebox Patchwork_1317/ivb-t430s/tests/24.json:igt@kms_pipe_crc_basic@nonblocking-crc-pipe-c-frame-sequence Patchwork_1317/ivb-t430s/tests/25.json:igt@kms_pipe_crc_basic@bad-source Patchwork_1317/ivb-t430s/tests/26.json:igt@kms_pipe_crc_basic@hang-read-crc-pipe-c Patchwork_1317/ivb-t430s/tests/27.json:igt@kms_pipe_crc_basic@hang-read-crc-pipe-b Patchwork_1317/ivb-t430s/tests/28.json:igt@kms_pipe_crc_basic@hang-read-crc-pipe-a Patchwork_1317/ivb-t430s/tests/29.json:igt@kms_force_connector_basic@force-connector-state Patchwork_1317/ivb-t430s/tests/2.json:igt@kms_pipe_crc_basic@read-crc-pipe-a Patchwork_1317/ivb-t430s/tests/30.json:igt@gem_ctx_exec@basic Patchwork_1317/ivb-t430s/tests/31.json:igt@gem_mmap@basic Patchwork_1317/ivb-t430s/tests/32.json:igt@prime_self_import@basic-with_one_bo
Patchwork_1317/ivb-t430s/tests/33.json:igt@kms_addfb_basic@addfb25-bad-modifier Patchwork_1317/ivb-t430s/tests/34.json:igt@gem_mmap_gtt@basic-read-write Patchwork_1317/ivb-t430s/tests/35.json:igt@gem_mmap_gtt@basic-write-cpu-read-gtt Patchwork_1317/ivb-t430s/tests/36.json:igt@gem_mmap_gtt@basic Patchwork_1317/ivb-t430s/tests/37.json:igt@gem_flink_basic@bad-flink Patchwork_1317/ivb-t430s/tests/38.json:igt@gem_basic@create-fd-close Patchwork_1317/ivb-t430s/tests/39.json:igt@kms_flip@basic-flip-vs-dpms Patchwork_1317/ivb-t430s/tests/3.json:igt@gem_ctx_param_basic@root-set Patchwork_1317/ivb-t430s/tests/40.json:igt@gem_ctx_param_basic@invalid-size-set Patchwork_1317/ivb-t430s/tests/41.json:igt@gem_exec_basic@basic-bsd2 Patchwork_1317/ivb-t430s/tests/42.json:igt@gem_exec_basic@basic-bsd1 Patchwork_1317/ivb-t430s/tests/43.json:igt@kms_addfb_basic@addfb25-x-tiled-mismatch Patchwork_1317/ivb-t430s/tests/44.json:igt@prime_self_import@basic-llseek-size Patchwork_1317/ivb-t430s/tests/45.json:i
gt@drv_module_reload_basic Patchwork_1317/ivb-t430s/tests/46.json:igt@kms_pipe_crc_basic@nonblocking-crc-pipe-b Patchwork_1317/ivb-t430s/tests/47.json:igt@kms_pipe_crc_basic@nonblocking-crc-pipe-c Patchwork_1317/ivb-t430s/tests/48.json:igt@kms_pipe_crc_basic@nonblocking-crc-pipe-a Patchwork_1317/ivb-t430s/tests/49.json:igt@gem_exec_parse@basic-allowed Patchwork_1317/ivb-t430s/tests/4.json:igt@kms_addfb_basic@bo-too-small Patchwork_1317/ivb-t430s/tests/50.json:igt@kms_addfb_basic@framebuffer-vs-set-tiling Patchwork_1317/ivb-t430s/tests/51.json:igt@prime_self_import@basic-with_fd_dup Patchwork_1317/ivb-t430s/tests/52.json:igt@gem_mmap_gtt@basic-write-no-prefault Patchwork_1317/ivb-t430s/tests/53.json:igt@gem_storedw_loop@basic-bsd2 Patchwork_1317/ivb-t430s/tests/54.json:igt@gem_sync@basic-blt Patchwork_1317/ivb-t430s/tests/55.json:igt@gem_storedw_loop@basic-bsd1 Patchwork_1317/ivb-t430s/tests/56.json:igt@gem_flink_basic@bad-open Patchwork_1317/ivb-t430s/tests/57.json:igt@gem_exec_basi
c@basic-bsd Patchwork_1317/ivb-t430s/tests/58.json:igt@kms_addfb_basic@addfb25-y-tiled Patchwork_1317/ivb-t430s/tests/59.json:igt@gem_mmap_gtt@basic-write-read-distinct Patchwork_1317/ivb-t430s/tests/5.json:igt@gem_mmap@basic-small-bo Patchwork_1317/ivb-t430s/tests/60.json:igt@kms_pipe_crc_basic@read-crc-pipe-b-frame-sequence Patchwork_1317/ivb-t430s/tests/61.json:igt@kms_force_connector_basic@prune-stale-modes Patchwork_1317/ivb-t430s/tests/62.json:igt@kms_pipe_crc_basic@bad-nb-words-3 Patchwork_1317/ivb-t430s/tests/63.json:igt@kms_pipe_crc_basic@bad-nb-words-1 Patchwork_1317/ivb-t430s/tests/64.json:igt@pm_rpm@basic-rte Patchwork_1317/ivb-t430s/tests/65.json:igt@gem_ctx_param_basic@non-root-set Patchwork_1317/ivb-t430s/tests/66.json:igt@kms_addfb_basic@bad-pitch-65536 Patchwork_1317/ivb-t430s/tests/67.json:igt@kms_addfb_basic@bad-pitch-128 Patchwork_1317/ivb-t430s/tests/68.json:igt@gem_storedw_loop@basic-vebox Patchwork_1317/ivb-t430s/tests/69.json:igt@gem_ctx_param_basic@root-set-
no-zeromap-enabled Patchwork_1317/ivb-t430s/tests/6.json:igt@kms_addfb_basic@basic-x-tiled Patchwork_1317/ivb-t430s/tests/70.json:igt@kms_psr_sink_crc@psr_basic Patchwork_1317/ivb-t430s/tests/71.json:igt@core_prop_blob@basic Patchwork_1317/ivb-t430s/tests/72.json:igt@gem_linear_blits@basic Patchwork_1317/ivb-t430s/tests/73.json:igt@gem_mmap_gtt@basic-small-bo Patchwork_1317/ivb-t430s/tests/74.json:igt@kms_pipe_crc_basic@nonblocking-crc-pipe-b-frame-sequence Patchwork_1317/ivb-t430s/tests/75.json:igt@kms_addfb_basic@tile-pitch-mismatch Patchwork_1317/ivb-t430s/tests/76.json:igt@gem_pwrite@basic Patchwork_1317/ivb-t430s/tests/77.json:igt@gem_ctx_param_basic@basic-default Patchwork_1317/ivb-t430s/tests/78.json:igt@kms_force_connector_basic@force-edid Patchwork_1317/ivb-t430s/tests/79.json:igt@kms_sink_crc_basic Patchwork_1317/ivb-t430s/tests/7.json:igt@gem_mmap_gtt@basic-read-no-prefault Patchwork_1317/ivb-t430s/tests/80.json:igt@gem_storedw_loop@basic-bsd Patchwork_1317/ivb-t430s/test
s/81.json:igt@gem_mmap_gtt@basic-read-write-distinct Patchwork_1317/ivb-t430s/tests/82.json:igt@gem_mmap_gtt@basic-small-copy Patchwork_1317/ivb-t430s/tests/83.json:igt@kms_addfb_basic@unused-handle Patchwork_1317/ivb-t430s/tests/84.json:igt@kms_addfb_basic@basic-y-tiled Patchwork_1317/ivb-t430s/tests/85.json:igt@gem_sync@basic-default Patchwork_1317/ivb-t430s/tests/86.json:igt@kms_addfb_basic@bad-pitch-0 Patchwork_1317/ivb-t430s/tests/87.json:igt@pm_rpm@basic-pci-d3-state Patchwork_1317/ivb-t430s/tests/88.json:igt@gem_render_tiled_blits@basic Patchwork_1317/ivb-t430s/tests/89.json:igt@drv_getparams_basic@basic-subslice-total Patchwork_1317/ivb-t430s/tests/8.json:igt@gem_ctx_basic Patchwork_1317/ivb-t430s/tests/90.json:igt@gem_tiled_pread_basic Patchwork_1317/ivb-t430s/tests/91.json:igt@kms_addfb_basic@unused-modifier Patchwork_1317/ivb-t430s/tests/92.json:igt@kms_addfb_basic@addfb25-y-tiled-small Patchwork_1317/ivb-t430s/tests/93.json:igt@kms_addfb_basic@bad-pitch-32 Patchwork_1317
/ivb-t430s/tests/94.json:igt@gem_mmap_gtt@basic-small-bo-tiledx Patchwork_1317/ivb-t430s/tests/9.json:igt@gem_mmap_gtt@basic-write-read
Results at /archive/results/CI_IGT_test/Patchwork_1317/
5de97b25e5f3c5a63ee243a9d3b22d30792f7d3e drm-intel-nightly: 2016y-01m-29d-07h-32m-09s UTC integration manifest
a7bde9039cb290e37dded710e3330b2586212bba drm/i915/skl: Fix DMC load on Skylake J0 and K0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2016-02-01 17:01 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-01-28 23:19 [PATCH] drm/i915/skl: Fix DMC load on Skylake J0 and K0 Mat Martineau
2016-01-28 23:26 ` Vivi, Rodrigo
2016-02-01 16:01 ` Mat Martineau
2016-02-01 17:00 ` Vivi, Rodrigo
2016-01-29 11:30 ` ✗ Fi.CI.BAT: failure for " Patchwork
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).