From: Mika Kahola <mika.kahola@intel.com>
To: Jani Nikula <jani.nikula@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915/BXT: Configure DSI after enabling DSI pll
Date: Wed, 03 Feb 2016 14:59:11 +0200 [thread overview]
Message-ID: <1454504351.4104.146.camel@sorvi> (raw)
In-Reply-To: <8760y62ldn.fsf@intel.com>
On Wed, 2016-02-03 at 11:28 +0200, Jani Nikula wrote:
> On Tue, 02 Feb 2016, Ramalingam C <ramalingam.c@intel.com> wrote:
> > We need to enable DSI PLL before configuring the DSI registers.
> >
> > Signed-off-by: Ramalingam C <ramalingam.c@intel.com>
> > ---
> > drivers/gpu/drm/i915/intel_dsi.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/i915/intel_dsi.c b/drivers/gpu/drm/i915/intel_dsi.c
> > index 91cef35..378f879 100644
> > --- a/drivers/gpu/drm/i915/intel_dsi.c
> > +++ b/drivers/gpu/drm/i915/intel_dsi.c
> > @@ -478,8 +478,8 @@ static void intel_dsi_pre_enable(struct intel_encoder *encoder)
> >
> > DRM_DEBUG_KMS("\n");
> >
> > - intel_dsi_prepare(encoder);
> > intel_enable_dsi_pll(encoder);
> > + intel_dsi_prepare(encoder);
>
> I'd really like to have this tested on BYT/CHV DSI to ensure we're not
> breaking anything.
>
> BR,
> Jani.
>
We have CI results for this. Should we be worried about CPU fifo
underrun?
http://benchsrv.fi.intel.com/archive/results/CI_IGT_test/Patchwork_1344/
>
>
> >
> > /* Panel Enable over CRC PMIC */
> > if (intel_dsi->gpio_panel)
>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2016-02-03 12:57 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-02 17:51 [PATCH] drm/i915/BXT: Configure DSI after enabling DSI pll Ramalingam C
2016-02-03 2:21 ` Thulasimani, Sivakumar
2016-02-03 9:27 ` Jani Nikula
2016-02-03 10:26 ` Mika Kahola
2016-02-03 10:59 ` Jani Nikula
2016-02-03 11:55 ` Jani Nikula
2016-02-03 12:32 ` Ramalingam C
2016-02-03 12:50 ` Ramalingam C
2016-02-03 7:26 ` Mika Kahola
2016-02-03 7:46 ` ✗ Fi.CI.BAT: warning for " Patchwork
2016-02-03 9:28 ` [PATCH] " Jani Nikula
2016-02-03 12:59 ` Mika Kahola [this message]
2016-02-15 16:18 ` Daniel Vetter
2016-02-03 13:52 ` ✗ Fi.CI.BAT: failure for drm/i915/BXT: Configure DSI after enabling DSI pll (rev2) Patchwork
2016-02-04 9:09 ` Jani Nikula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1454504351.4104.146.camel@sorvi \
--to=mika.kahola@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).