From: Dave Gordon <david.s.gordon@intel.com>
To: intel-gfx@lists.freedesktop.org
Subject: [PATCH v5 00/11] A collection of cleanups, revisited
Date: Fri, 5 Feb 2016 18:33:37 +0000 [thread overview]
Message-ID: <1454697228-33164-1-git-send-email-david.s.gordon@intel.com> (raw)
Various things can go wrong during initialisation and teardown, but they
usually don't, so the error-handling paths go largely untested. This
collection of patches fixes some things I recently noticed. Some might
lead to a kernel OOPS, but mostly they're leaks and other inconsistencies.
Includes Nick Hoath's patch to swap context/engine teardown, because that
helps make setup & teardown more consistent too; but more importantly, that
patch [10/11] is dependent on patch [9/11] of this set to work correctly.
Applying [10/11] without at least [9/11] as well may cause a fault on
driver unload!
v2:
Patches reordered and the previous [1/4] split into [4..6/6],
so that the bugs that it's fixing are more clearly visible
(Mika Kuoppala, although he said it wasn't actually *necessary*).
v3:
Patches reordered again; the bug fixes are now in patches 3 and 5.
The former could stand alone; the latter depends on patch 4 and is
a prerequisite for Nick's patch [6/6] to function.
v4:
Rebased
v5:
Patches repartitioned, reordered, and rebased again.
The first two are now the ones that have already been reviewed
(R-b: Chris Wilson), the remaining ones have been broken up
into smaller more digestible chunks.
Dave Gordon (9):
drm/i915: unmap the correct page in intel_logical_ring_cleanup()
drm/i915: consolidate LRC mode HWSP setup & teardown
drm/i915: remove useless copypasted code
drm/i915: tidy up initialisation failure paths (GEM)
drm/i915: tidy initialisation failure paths (legacy, part 1)
drm/i915: tidy initialisation failure paths (legacy, part 2)
drm/i915: tidy initialisation failure paths (legacy, part 3)
drm/i915: tear down hardware status page mappings earlier
drm/i915: make LRC status page teardown code a bit more robust
Nick Hoath (2):
drm/i915: two small moves towards more consistency
drm/i915: interchange context/engine cleanup order
drivers/gpu/drm/i915/i915_dma.c | 4 +-
drivers/gpu/drm/i915/i915_drv.h | 2 +-
drivers/gpu/drm/i915/i915_gem.c | 28 ++++++++------
drivers/gpu/drm/i915/intel_lrc.c | 65 ++++++++++++++++++++-------------
drivers/gpu/drm/i915/intel_ringbuffer.c | 40 ++++++++------------
5 files changed, 75 insertions(+), 64 deletions(-)
--
1.9.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next reply other threads:[~2016-02-05 18:34 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-05 18:33 Dave Gordon [this message]
2016-02-05 18:33 ` [PATCH v5 01/11] drm/i915: unmap the correct page in intel_logical_ring_cleanup() Dave Gordon
2016-02-05 18:33 ` [PATCH v5 02/11] drm/i915: consolidate LRC mode HWSP setup & teardown Dave Gordon
2016-02-05 18:33 ` [PATCH v5 03/11] drm/i915: remove useless copypasted code Dave Gordon
2016-02-05 18:33 ` [PATCH v5 04/11] drm/i915: tidy up initialisation failure paths (GEM) Dave Gordon
2016-02-05 18:33 ` [PATCH v5 05/11] drm/i915: tidy initialisation failure paths (legacy, part 1) Dave Gordon
2016-02-05 18:33 ` [PATCH v5 06/11] drm/i915: tidy initialisation failure paths (legacy, part 2) Dave Gordon
2016-02-05 18:33 ` [PATCH v5 07/11] drm/i915: tidy initialisation failure paths (legacy, part 3) Dave Gordon
2016-02-05 18:33 ` [PATCH v5 08/11] drm/i915: two small moves towards more consistency Dave Gordon
2016-02-05 18:33 ` [PATCH v5 09/11] drm/i915: tear down hardware status page mappings earlier Dave Gordon
2016-02-05 18:33 ` [PATCH v5 10/11] drm/i915: interchange context/engine cleanup order Dave Gordon
2016-02-05 18:33 ` [PATCH v5 11/11] drm/i915: make LRC status page teardown code a bit more robust Dave Gordon
2016-02-08 12:58 ` ✓ Fi.CI.BAT: success for A collection of cleanups, revisited Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1454697228-33164-1-git-send-email-david.s.gordon@intel.com \
--to=david.s.gordon@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).