From: Imre Deak <imre.deak@intel.com>
To: intel-gfx@lists.freedesktop.org
Subject: [PATCH 00/12] drm/i915: add missing display power refs
Date: Fri, 12 Feb 2016 18:55:09 +0200 [thread overview]
Message-ID: <1455296121-4742-1-git-send-email-imre.deak@intel.com> (raw)
This patchset adds missing display power domain references during
modeset HW readout, which I noticed via wakeref warnings the
corresponding HW accesses triggered. The crt and ddi patches have a
concrete bugzilla reference they fix, I don't know of reports that would
be fixed by the rest of the patches in the set. On the way I also
noticed other places which are potentially racy (debugfs CRC, VGA
disabling, pipe_assert) so I fixed those up too.
I left the IRQ setup and error capture code as-is: the former happens
during driver loading and resume, so the power is guaranteed to stay on
for the whole sequence. For error capture, we decided early on that we
won't add any locking around these accesses to minimize the chance for
locking inversions. Also for this we would need to grab a mutex which
isn't possible on the error capture path.
Mika came up with a very similar fix, since he suspects that it could
also be related to recent DMC problems. We agreed that I send mine since
it uses the more optimal rpm_get_if_in_use() helper (and looks more
polished).
Imre Deak (12):
drm/i915: add helper to get a display power ref if it was already
enabled
drm/i915: ensure the HW is powered during display pipe HW readout
drm/i915/ibx: ensure the HW is powered during PLL HW readout
drm/i915: ensure the HW is powered when disabling VGA
drm/i915: ensure the HW is powered during HW access in assert_pipe
drm/i915/crt: ensure the HW is powered during HW state readout
drm/i915/ddi: ensure the HW is powered during HW state readout
drm/i915: ensure the HW is powered when accessing the CRC HW block
drm/i915/dp: ensure the HW is powered during HW state readout
drm/i915/dsi: ensure the HW is powered during HW state readout
drm/i915/hdmi: ensure the HW is powered during HW state readout
drm/i915/lvds: ensure the HW is powered during HW state readout
drivers/gpu/drm/i915/i915_debugfs.c | 28 ++++++--
drivers/gpu/drm/i915/intel_crt.c | 13 +++-
drivers/gpu/drm/i915/intel_ddi.c | 116 ++++++++++++++++++++++----------
drivers/gpu/drm/i915/intel_display.c | 86 ++++++++++++++++-------
drivers/gpu/drm/i915/intel_dp.c | 18 +++--
drivers/gpu/drm/i915/intel_drv.h | 3 +
drivers/gpu/drm/i915/intel_dsi.c | 13 +++-
drivers/gpu/drm/i915/intel_hdmi.c | 14 +++-
drivers/gpu/drm/i915/intel_lvds.c | 14 +++-
drivers/gpu/drm/i915/intel_runtime_pm.c | 111 +++++++++++++++++++++++++-----
10 files changed, 315 insertions(+), 101 deletions(-)
--
2.5.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next reply other threads:[~2016-02-12 16:55 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-12 16:55 Imre Deak [this message]
2016-02-12 16:55 ` [PATCH 01/12] drm/i915: add helper to get a display power ref if it was already enabled Imre Deak
2016-02-15 8:09 ` Joonas Lahtinen
2016-02-15 14:18 ` [PATCH v2 " Imre Deak
2016-02-17 12:17 ` [PATCH v3 " Imre Deak
2016-02-12 16:55 ` [PATCH 02/12] drm/i915: ensure the HW is powered during display pipe HW readout Imre Deak
2016-02-15 13:23 ` Mika Kuoppala
2016-02-12 16:55 ` [PATCH 03/12] drm/i915/ibx: ensure the HW is powered during PLL " Imre Deak
2016-02-15 13:59 ` Mika Kuoppala
2016-02-12 16:55 ` [PATCH 04/12] drm/i915: ensure the HW is powered when disabling VGA Imre Deak
2016-02-12 16:55 ` [PATCH 05/12] drm/i915: ensure the HW is powered during HW access in assert_pipe Imre Deak
2016-02-12 16:55 ` [PATCH 06/12] drm/i915/crt: ensure the HW is powered during HW state readout Imre Deak
2016-02-12 16:55 ` [PATCH 07/12] drm/i915/ddi: " Imre Deak
2016-02-12 16:55 ` [PATCH 08/12] drm/i915: ensure the HW is powered when accessing the CRC HW block Imre Deak
2016-02-16 16:02 ` Daniel Vetter
2016-02-17 12:20 ` Imre Deak
2016-02-17 16:09 ` Daniel Vetter
2016-02-12 16:55 ` [PATCH 09/12] drm/i915/dp: ensure the HW is powered during HW state readout Imre Deak
2016-02-12 16:55 ` [PATCH 10/12] drm/i915/dsi: " Imre Deak
2016-02-12 16:55 ` [PATCH 11/12] drm/i915/hdmi: " Imre Deak
2016-02-12 16:55 ` [PATCH 12/12] drm/i915/lvds: " Imre Deak
2016-02-16 16:05 ` Daniel Vetter
2016-02-16 16:47 ` Imre Deak
2016-02-16 11:15 ` ✗ Fi.CI.BAT: failure for drm/i915: add missing display power refs (rev2) Patchwork
2016-02-16 14:04 ` [PATCH 00/12] drm/i915: add missing display power refs Mika Kuoppala
2016-02-16 17:35 ` Imre Deak
2016-02-17 12:44 ` ✓ Fi.CI.BAT: success for drm/i915: add missing display power refs (rev3) Patchwork
2016-02-17 14:21 ` Imre Deak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1455296121-4742-1-git-send-email-imre.deak@intel.com \
--to=imre.deak@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).