intel-gfx.lists.freedesktop.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] drm/i915: Change WARN_ON(!wm_changed) to I915_STATE_WARN_ON()
@ 2016-02-22 19:22 Lyude
  2016-02-23  9:04 ` ✗ Fi.CI.BAT: failure for " Patchwork
                   ` (2 more replies)
  0 siblings, 3 replies; 5+ messages in thread
From: Lyude @ 2016-02-22 19:22 UTC (permalink / raw)
  To: intel-gfx
  Cc: Rob Clark, David Airlie,
	open list:INTEL DRM DRIVERS excluding Poulsbo, Moorestow..., linux-kernel@vger.kernel.org open list,
	Daniel Vetter

These warnings still seem to be present with DP MST configurations. They
don't actually indicate any impending doom, so we may as well use
I915_STATE_WARN_ON() here to help quiet things down a little bit for
distro kernel users.

Signed-off-by: Lyude <cpaul@redhat.com>
---
 drivers/gpu/drm/i915/intel_pm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
index a234687..1870185 100644
--- a/drivers/gpu/drm/i915/intel_pm.c
+++ b/drivers/gpu/drm/i915/intel_pm.c
@@ -3545,7 +3545,7 @@ static void skl_update_other_pipe_wm(struct drm_device *dev,
 		 * because it was really needed, so we expect the WM values to
 		 * be different.
 		 */
-		WARN_ON(!wm_changed);
+		I915_STATE_WARN_ON(!wm_changed);
 
 		skl_compute_wm_results(dev, &pipe_wm, r, intel_crtc);
 		r->dirty[intel_crtc->pipe] = true;
-- 
2.5.0

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* ✗ Fi.CI.BAT: failure for drm/i915: Change WARN_ON(!wm_changed) to I915_STATE_WARN_ON()
  2016-02-22 19:22 [PATCH] drm/i915: Change WARN_ON(!wm_changed) to I915_STATE_WARN_ON() Lyude
@ 2016-02-23  9:04 ` Patchwork
  2016-02-23 10:59 ` Patchwork
  2016-02-29 15:47 ` [PATCH] " Daniel Vetter
  2 siblings, 0 replies; 5+ messages in thread
From: Patchwork @ 2016-02-23  9:04 UTC (permalink / raw)
  To: cpaul; +Cc: intel-gfx

== Series Details ==

Series: drm/i915: Change WARN_ON(!wm_changed) to I915_STATE_WARN_ON()
URL   : https://patchwork.freedesktop.org/series/3698/
State : failure

== Summary ==

Series 3698v1 drm/i915: Change WARN_ON(!wm_changed) to I915_STATE_WARN_ON()
http://patchwork.freedesktop.org/api/1.0/series/3698/revisions/1/mbox/

Test core_prop_blob:
        Subgroup basic:
                incomplete -> PASS       (snb-x220t)
Test drv_getparams_basic:
        Subgroup basic-eu-total:
                incomplete -> PASS       (snb-x220t)
                pass       -> INCOMPLETE (ilk-hp8440p)
Test drv_module_reload_basic:
                pass       -> INCOMPLETE (ilk-hp8440p)
Test gem_basic:
        Subgroup create-close:
                pass       -> INCOMPLETE (ilk-hp8440p)
Test gem_cs_prefetch:
        Subgroup basic-default:
                incomplete -> PASS       (ilk-hp8440p)
Test gem_cs_tlb:
        Subgroup basic-default:
                pass       -> INCOMPLETE (ilk-hp8440p)
Test gem_ctx_basic:
                skip       -> INCOMPLETE (ilk-hp8440p)
Test gem_ctx_exec:
        Subgroup basic:
                skip       -> INCOMPLETE (ilk-hp8440p)
Test gem_ctx_param_basic:
        Subgroup basic:
                incomplete -> PASS       (snb-x220t)
                skip       -> INCOMPLETE (ilk-hp8440p)
        Subgroup basic-default:
                incomplete -> PASS       (snb-x220t)
        Subgroup invalid-param-set:
                skip       -> INCOMPLETE (ilk-hp8440p)
        Subgroup non-root-set:
                incomplete -> PASS       (snb-x220t)
        Subgroup non-root-set-no-zeromap:
                skip       -> INCOMPLETE (ilk-hp8440p)
        Subgroup root-set:
                incomplete -> PASS       (snb-x220t)
        Subgroup root-set-no-zeromap-disabled:
                incomplete -> PASS       (snb-x220t)
Test gem_exec_basic:
        Subgroup basic-blt:
                skip       -> INCOMPLETE (ilk-hp8440p)
        Subgroup basic-bsd2:
                incomplete -> SKIP       (snb-x220t)
        Subgroup basic-default:
                incomplete -> PASS       (snb-x220t)
Test gem_exec_parse:
        Subgroup basic-rejected:
                incomplete -> SKIP       (snb-x220t)
Test gem_flink_basic:
        Subgroup bad-flink:
                incomplete -> PASS       (snb-x220t)
        Subgroup bad-open:
                pass       -> INCOMPLETE (ilk-hp8440p)
        Subgroup basic:
                incomplete -> PASS       (snb-x220t)
        Subgroup double-flink:
                incomplete -> PASS       (snb-x220t)
        Subgroup flink-lifetime:
                pass       -> INCOMPLETE (ilk-hp8440p)
Test gem_mmap:
        Subgroup basic:
                incomplete -> PASS       (snb-x220t)
                pass       -> INCOMPLETE (ilk-hp8440p)
        Subgroup basic-small-bo:
                pass       -> INCOMPLETE (ilk-hp8440p)
Test gem_mmap_gtt:
        Subgroup basic:
                incomplete -> PASS       (snb-x220t)
        Subgroup basic-copy:
                pass       -> INCOMPLETE (ilk-hp8440p)
        Subgroup basic-read:
                incomplete -> PASS       (snb-x220t)
                pass       -> INCOMPLETE (ilk-hp8440p)
        Subgroup basic-read-write:
                incomplete -> PASS       (snb-x220t)
                pass       -> INCOMPLETE (ilk-hp8440p)
        Subgroup basic-read-write-distinct:
                pass       -> INCOMPLETE (ilk-hp8440p)
        Subgroup basic-short:
                pass       -> INCOMPLETE (ilk-hp8440p)
        Subgroup basic-small-bo-tiledy:
                pass       -> INCOMPLETE (ilk-hp8440p)
        Subgroup basic-small-copy:
                pass       -> INCOMPLETE (ilk-hp8440p)
        Subgroup basic-small-copy-xy:
                incomplete -> PASS       (snb-x220t)
                pass       -> INCOMPLETE (ilk-hp8440p)
        Subgroup basic-write:
                pass       -> INCOMPLETE (ilk-hp8440p)
        Subgroup basic-write-cpu-read-gtt:
                skip       -> INCOMPLETE (ilk-hp8440p)
        Subgroup basic-write-gtt:
                incomplete -> PASS       (snb-x220t)
        Subgroup basic-write-gtt-no-prefault:
                pass       -> INCOMPLETE (ilk-hp8440p)
        Subgroup basic-write-read-distinct:
                incomplete -> PASS       (snb-x220t)
Test gem_pread:
        Subgroup basic:
                incomplete -> PASS       (snb-x220t)
                pass       -> INCOMPLETE (ilk-hp8440p)
Test gem_pwrite:
        Subgroup basic:
                incomplete -> PASS       (snb-x220t)
                pass       -> INCOMPLETE (ilk-hp8440p)
Test gem_render_linear_blits:
        Subgroup basic:
                incomplete -> PASS       (snb-x220t)
Test gem_render_tiled_blits:
        Subgroup basic:
                incomplete -> PASS       (snb-x220t)
Test gem_ringfill:
        Subgroup basic-default-bomb:
                pass       -> INCOMPLETE (ilk-hp8440p)
        Subgroup basic-default-child:
                incomplete -> PASS       (snb-x220t)
                pass       -> INCOMPLETE (ilk-hp8440p)
        Subgroup basic-default-interruptible:
                incomplete -> PASS       (snb-x220t)
Test gem_storedw_loop:
        Subgroup basic-blt:
                skip       -> INCOMPLETE (ilk-hp8440p)
        Subgroup basic-bsd:
                skip       -> INCOMPLETE (ilk-hp8440p)
        Subgroup basic-bsd2:
                skip       -> INCOMPLETE (ilk-hp8440p)
        Subgroup basic-vebox:
                incomplete -> SKIP       (snb-x220t)
                skip       -> INCOMPLETE (ilk-hp8440p)
Test gem_sync:
        Subgroup basic-blt:
                skip       -> INCOMPLETE (ilk-hp8440p)
        Subgroup basic-bsd:
                incomplete -> PASS       (snb-x220t)
                pass       -> INCOMPLETE (ilk-hp8440p)
        Subgroup basic-bsd1:
                skip       -> INCOMPLETE (ilk-hp8440p)
        Subgroup basic-default:
                pass       -> INCOMPLETE (ilk-hp8440p)
        Subgroup basic-render:
                pass       -> INCOMPLETE (ilk-hp8440p)
        Subgroup basic-vebox:
                skip       -> INCOMPLETE (ilk-hp8440p)
Test gem_tiled_pread_basic:
                pass       -> INCOMPLETE (ilk-hp8440p)
Test kms_addfb_basic:
        Subgroup addfb25-bad-modifier:
                incomplete -> PASS       (snb-x220t)
                pass       -> INCOMPLETE (ilk-hp8440p)
        Subgroup addfb25-modifier-no-flag:
                incomplete -> PASS       (snb-x220t)
                pass       -> INCOMPLETE (ilk-hp8440p)
        Subgroup addfb25-x-tiled:
                pass       -> INCOMPLETE (ilk-hp8440p)
        Subgroup addfb25-y-tiled:
                pass       -> INCOMPLETE (ilk-hp8440p)
        Subgroup addfb25-y-tiled-small:
                incomplete -> SKIP       (snb-x220t)
        Subgroup addfb25-yf-tiled:
                incomplete -> PASS       (snb-x220t)
        Subgroup bad-pitch-0:
                incomplete -> PASS       (snb-x220t)
                pass       -> INCOMPLETE (ilk-hp8440p)
        Subgroup bad-pitch-1024:
                pass       -> INCOMPLETE (ilk-hp8440p)
        Subgroup bad-pitch-128:
                pass       -> INCOMPLETE (ilk-hp8440p)
        Subgroup bad-pitch-65536:
                pass       -> INCOMPLETE (ilk-hp8440p)
        Subgroup basic:
                incomplete -> PASS       (snb-x220t)
                pass       -> INCOMPLETE (ilk-hp8440p)
        Subgroup bo-too-small:
                pass       -> INCOMPLETE (ilk-hp8440p)
        Subgroup bo-too-small-due-to-tiling:
                incomplete -> PASS       (snb-x220t)
                pass       -> INCOMPLETE (ilk-hp8440p)
        Subgroup clobberred-modifier:
                pass       -> INCOMPLETE (ilk-hp8440p)
        Subgroup framebuffer-vs-set-tiling:
                pass       -> INCOMPLETE (ilk-hp8440p)
        Subgroup no-handle:
                incomplete -> PASS       (snb-x220t)
                pass       -> INCOMPLETE (ilk-hp8440p)
        Subgroup size-max:
                incomplete -> PASS       (snb-x220t)
                pass       -> INCOMPLETE (ilk-hp8440p)
        Subgroup small-bo:
                pass       -> INCOMPLETE (ilk-hp8440p)
        Subgroup tile-pitch-mismatch:
                pass       -> INCOMPLETE (ilk-hp8440p)
        Subgroup too-high:
                incomplete -> PASS       (snb-x220t)
                pass       -> INCOMPLETE (ilk-hp8440p)
        Subgroup unused-handle:
                incomplete -> PASS       (snb-x220t)
        Subgroup unused-modifier:
                incomplete -> PASS       (snb-x220t)
        Subgroup unused-offsets:
                pass       -> INCOMPLETE (ilk-hp8440p)
        Subgroup unused-pitches:
                pass       -> INCOMPLETE (ilk-hp8440p)
Test kms_flip:
        Subgroup basic-flip-vs-dpms:
                pass       -> INCOMPLETE (ilk-hp8440p) UNSTABLE
        Subgroup basic-flip-vs-wf_vblank:
                fail       -> PASS       (snb-x220t)
                pass       -> INCOMPLETE (ilk-hp8440p) UNSTABLE
        Subgroup basic-plain-flip:
                pass       -> INCOMPLETE (ilk-hp8440p)
Test kms_force_connector_basic:
        Subgroup force-connector-state:
                pass       -> INCOMPLETE (ilk-hp8440p)
        Subgroup force-load-detect:
                dmesg-fail -> FAIL       (hsw-gt2)
                fail       -> INCOMPLETE (ilk-hp8440p)
                fail       -> SKIP       (ivb-t430s)
Test kms_pipe_crc_basic:
        Subgroup bad-nb-words-1:
                incomplete -> PASS       (snb-x220t)
                pass       -> INCOMPLETE (ilk-hp8440p)
        Subgroup bad-nb-words-3:
                pass       -> INCOMPLETE (ilk-hp8440p)
        Subgroup bad-pipe:
                pass       -> INCOMPLETE (ilk-hp8440p)
        Subgroup bad-source:
                incomplete -> PASS       (snb-x220t)
        Subgroup hang-read-crc-pipe-b:
                incomplete -> PASS       (snb-x220t)
        Subgroup hang-read-crc-pipe-c:
                incomplete -> SKIP       (snb-x220t)
                skip       -> INCOMPLETE (ilk-hp8440p)
        Subgroup nonblocking-crc-pipe-a:
                pass       -> INCOMPLETE (ilk-hp8440p)
        Subgroup nonblocking-crc-pipe-a-frame-sequence:
                incomplete -> PASS       (snb-x220t)
                pass       -> INCOMPLETE (ilk-hp8440p)
        Subgroup nonblocking-crc-pipe-b:
                pass       -> INCOMPLETE (ilk-hp8440p)
        Subgroup nonblocking-crc-pipe-b-frame-sequence:
                incomplete -> PASS       (snb-x220t)
                pass       -> INCOMPLETE (ilk-hp8440p)
        Subgroup nonblocking-crc-pipe-c:
                incomplete -> SKIP       (snb-x220t)
                skip       -> INCOMPLETE (ilk-hp8440p)
        Subgroup nonblocking-crc-pipe-c-frame-sequence:
                skip       -> INCOMPLETE (ilk-hp8440p)
        Subgroup read-crc-pipe-a:
                pass       -> INCOMPLETE (ilk-hp8440p)
        Subgroup read-crc-pipe-a-frame-sequence:
                incomplete -> PASS       (snb-x220t)
        Subgroup read-crc-pipe-b-frame-sequence:
                incomplete -> PASS       (snb-x220t)
        Subgroup read-crc-pipe-c:
                pass       -> DMESG-WARN (hsw-gt2)
                skip       -> INCOMPLETE (ilk-hp8440p)
        Subgroup read-crc-pipe-c-frame-sequence:
                skip       -> INCOMPLETE (ilk-hp8440p)
        Subgroup suspend-read-crc-pipe-a:
                pass       -> INCOMPLETE (snb-dellxps)
        Subgroup suspend-read-crc-pipe-b:
                dmesg-warn -> PASS       (skl-i5k-2) UNSTABLE
                pass       -> INCOMPLETE (ilk-hp8440p)
        Subgroup suspend-read-crc-pipe-c:
                pass       -> DMESG-WARN (skl-i5k-2) UNSTABLE
Test kms_psr_sink_crc:
        Subgroup psr_basic:
                incomplete -> SKIP       (snb-x220t)
                skip       -> INCOMPLETE (ilk-hp8440p)
Test kms_setmode:
        Subgroup basic-clone-single-crtc:
                incomplete -> PASS       (snb-x220t)
Test kms_sink_crc_basic:
                skip       -> INCOMPLETE (ilk-hp8440p)
Test pm_backlight:
        Subgroup basic-brightness:
                pass       -> INCOMPLETE (ilk-hp8440p)
Test pm_rpm:
        Subgroup basic-pci-d3-state:
                pass       -> DMESG-WARN (byt-nuc)
        Subgroup basic-rte:
                pass       -> DMESG-WARN (bsw-nuc-2)
                dmesg-warn -> PASS       (byt-nuc) UNSTABLE
Test pm_rps:
        Subgroup basic-api:
                incomplete -> PASS       (snb-x220t)
Test prime_self_import:
        Subgroup basic-llseek-size:
                incomplete -> PASS       (snb-x220t)
                pass       -> INCOMPLETE (ilk-hp8440p)
        Subgroup basic-with_fd_dup:
                incomplete -> PASS       (snb-x220t)
                pass       -> INCOMPLETE (ilk-hp8440p)

bdw-nuci7        total:165  pass:154  dwarn:0   dfail:0   fail:0   skip:11 
bsw-nuc-2        total:168  pass:136  dwarn:1   dfail:0   fail:1   skip:30 
byt-nuc          total:168  pass:142  dwarn:1   dfail:0   fail:0   skip:25 
hsw-gt2          total:168  pass:156  dwarn:1   dfail:0   fail:1   skip:10 
ilk-hp8440p      total:168  pass:45   dwarn:0   dfail:0   fail:0   skip:22 
ivb-t430s        total:168  pass:153  dwarn:0   dfail:0   fail:0   skip:15 
skl-i5k-2        total:168  pass:151  dwarn:1   dfail:0   fail:0   skip:16 
snb-dellxps      total:48   pass:41   dwarn:0   dfail:0   fail:0   skip:6  
snb-x220t        total:168  pass:145  dwarn:0   dfail:1   fail:1   skip:21 

Results at /archive/results/CI_IGT_test/Patchwork_1458/

08fc1b101049694778bff7559e1d05250d2e7072 drm-intel-nightly: 2016y-02m-22d-17h-30m-27s UTC integration manifest
4a978a3497935cab1e4e462300c2955bfd8eeba3 drm/i915: Change WARN_ON(!wm_changed) to I915_STATE_WARN_ON()

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 5+ messages in thread

* ✗ Fi.CI.BAT: failure for drm/i915: Change WARN_ON(!wm_changed) to I915_STATE_WARN_ON()
  2016-02-22 19:22 [PATCH] drm/i915: Change WARN_ON(!wm_changed) to I915_STATE_WARN_ON() Lyude
  2016-02-23  9:04 ` ✗ Fi.CI.BAT: failure for " Patchwork
@ 2016-02-23 10:59 ` Patchwork
  2016-02-29 15:47 ` [PATCH] " Daniel Vetter
  2 siblings, 0 replies; 5+ messages in thread
From: Patchwork @ 2016-02-23 10:59 UTC (permalink / raw)
  To: cpaul; +Cc: intel-gfx

== Series Details ==

Series: drm/i915: Change WARN_ON(!wm_changed) to I915_STATE_WARN_ON()
URL   : https://patchwork.freedesktop.org/series/3698/
State : failure

== Summary ==

Series 3698v1 drm/i915: Change WARN_ON(!wm_changed) to I915_STATE_WARN_ON()
http://patchwork.freedesktop.org/api/1.0/series/3698/revisions/1/mbox/

Test drv_getparams_basic:
        Subgroup basic-eu-total:
                pass       -> INCOMPLETE (ilk-hp8440p)
Test drv_module_reload_basic:
                pass       -> INCOMPLETE (ilk-hp8440p)
Test gem_basic:
        Subgroup create-close:
                pass       -> INCOMPLETE (ilk-hp8440p)
Test gem_cs_prefetch:
        Subgroup basic-default:
                incomplete -> PASS       (ilk-hp8440p)
Test gem_cs_tlb:
        Subgroup basic-default:
                pass       -> INCOMPLETE (ilk-hp8440p)
Test gem_ctx_basic:
                skip       -> INCOMPLETE (ilk-hp8440p)
Test gem_ctx_exec:
        Subgroup basic:
                skip       -> INCOMPLETE (ilk-hp8440p)
Test gem_ctx_param_basic:
        Subgroup basic:
                skip       -> INCOMPLETE (ilk-hp8440p)
        Subgroup invalid-param-set:
                skip       -> INCOMPLETE (ilk-hp8440p)
        Subgroup non-root-set-no-zeromap:
                skip       -> INCOMPLETE (ilk-hp8440p)
Test gem_exec_basic:
        Subgroup basic-blt:
                skip       -> INCOMPLETE (ilk-hp8440p)
Test gem_flink_basic:
        Subgroup bad-open:
                pass       -> INCOMPLETE (ilk-hp8440p)
        Subgroup flink-lifetime:
                pass       -> INCOMPLETE (ilk-hp8440p)
Test gem_mmap:
        Subgroup basic:
                pass       -> INCOMPLETE (ilk-hp8440p)
        Subgroup basic-small-bo:
                pass       -> INCOMPLETE (ilk-hp8440p)
Test gem_mmap_gtt:
        Subgroup basic-copy:
                pass       -> INCOMPLETE (ilk-hp8440p)
        Subgroup basic-read:
                pass       -> INCOMPLETE (ilk-hp8440p)
        Subgroup basic-read-write:
                pass       -> INCOMPLETE (ilk-hp8440p)
        Subgroup basic-read-write-distinct:
                pass       -> INCOMPLETE (ilk-hp8440p)
        Subgroup basic-short:
                pass       -> INCOMPLETE (ilk-hp8440p)
        Subgroup basic-small-bo-tiledy:
                pass       -> INCOMPLETE (ilk-hp8440p)
        Subgroup basic-small-copy:
                pass       -> INCOMPLETE (ilk-hp8440p)
        Subgroup basic-small-copy-xy:
                pass       -> INCOMPLETE (ilk-hp8440p)
        Subgroup basic-write:
                pass       -> INCOMPLETE (ilk-hp8440p)
        Subgroup basic-write-cpu-read-gtt:
                skip       -> INCOMPLETE (ilk-hp8440p)
        Subgroup basic-write-gtt-no-prefault:
                pass       -> INCOMPLETE (ilk-hp8440p)
Test gem_pread:
        Subgroup basic:
                pass       -> INCOMPLETE (ilk-hp8440p)
Test gem_pwrite:
        Subgroup basic:
                pass       -> INCOMPLETE (ilk-hp8440p)
Test gem_ringfill:
        Subgroup basic-default-bomb:
                pass       -> INCOMPLETE (ilk-hp8440p)
        Subgroup basic-default-child:
                pass       -> INCOMPLETE (ilk-hp8440p)
Test gem_storedw_loop:
        Subgroup basic-blt:
                skip       -> INCOMPLETE (ilk-hp8440p)
        Subgroup basic-bsd:
                skip       -> INCOMPLETE (ilk-hp8440p)
        Subgroup basic-bsd2:
                skip       -> INCOMPLETE (ilk-hp8440p)
        Subgroup basic-vebox:
                skip       -> INCOMPLETE (ilk-hp8440p)
Test gem_sync:
        Subgroup basic-blt:
                skip       -> INCOMPLETE (ilk-hp8440p)
        Subgroup basic-bsd:
                pass       -> INCOMPLETE (ilk-hp8440p)
        Subgroup basic-bsd1:
                skip       -> INCOMPLETE (ilk-hp8440p)
        Subgroup basic-default:
                pass       -> INCOMPLETE (ilk-hp8440p)
        Subgroup basic-render:
                pass       -> INCOMPLETE (ilk-hp8440p)
        Subgroup basic-vebox:
                skip       -> INCOMPLETE (ilk-hp8440p)
Test gem_tiled_pread_basic:
                pass       -> INCOMPLETE (ilk-hp8440p)
Test kms_addfb_basic:
        Subgroup addfb25-bad-modifier:
                pass       -> INCOMPLETE (ilk-hp8440p)
        Subgroup addfb25-modifier-no-flag:
                pass       -> INCOMPLETE (ilk-hp8440p)
        Subgroup addfb25-x-tiled:
                pass       -> INCOMPLETE (ilk-hp8440p)
        Subgroup addfb25-y-tiled:
                pass       -> INCOMPLETE (ilk-hp8440p)
        Subgroup bad-pitch-0:
                pass       -> INCOMPLETE (ilk-hp8440p)
        Subgroup bad-pitch-1024:
                pass       -> INCOMPLETE (ilk-hp8440p)
        Subgroup bad-pitch-128:
                pass       -> INCOMPLETE (ilk-hp8440p)
        Subgroup bad-pitch-65536:
                pass       -> INCOMPLETE (ilk-hp8440p)
        Subgroup basic:
                pass       -> INCOMPLETE (ilk-hp8440p)
        Subgroup bo-too-small:
                pass       -> INCOMPLETE (ilk-hp8440p)
        Subgroup bo-too-small-due-to-tiling:
                pass       -> INCOMPLETE (ilk-hp8440p)
        Subgroup clobberred-modifier:
                pass       -> INCOMPLETE (ilk-hp8440p)
        Subgroup framebuffer-vs-set-tiling:
                pass       -> INCOMPLETE (ilk-hp8440p)
        Subgroup no-handle:
                pass       -> INCOMPLETE (ilk-hp8440p)
        Subgroup size-max:
                pass       -> INCOMPLETE (ilk-hp8440p)
        Subgroup small-bo:
                pass       -> INCOMPLETE (ilk-hp8440p)
        Subgroup tile-pitch-mismatch:
                pass       -> INCOMPLETE (ilk-hp8440p)
        Subgroup too-high:
                pass       -> INCOMPLETE (ilk-hp8440p)
        Subgroup unused-offsets:
                pass       -> INCOMPLETE (ilk-hp8440p)
        Subgroup unused-pitches:
                pass       -> INCOMPLETE (ilk-hp8440p)
Test kms_flip:
        Subgroup basic-flip-vs-dpms:
                pass       -> INCOMPLETE (ilk-hp8440p) UNSTABLE
        Subgroup basic-flip-vs-wf_vblank:
                pass       -> INCOMPLETE (ilk-hp8440p) UNSTABLE
        Subgroup basic-plain-flip:
                pass       -> INCOMPLETE (ilk-hp8440p)
Test kms_force_connector_basic:
        Subgroup force-connector-state:
                pass       -> INCOMPLETE (ilk-hp8440p)
        Subgroup force-edid:
                skip       -> PASS       (snb-x220t)
        Subgroup force-load-detect:
                dmesg-fail -> FAIL       (hsw-gt2)
                fail       -> INCOMPLETE (ilk-hp8440p)
                fail       -> SKIP       (ivb-t430s)
Test kms_pipe_crc_basic:
        Subgroup bad-nb-words-1:
                pass       -> INCOMPLETE (ilk-hp8440p)
        Subgroup bad-nb-words-3:
                pass       -> INCOMPLETE (ilk-hp8440p)
        Subgroup bad-pipe:
                pass       -> INCOMPLETE (ilk-hp8440p)
        Subgroup hang-read-crc-pipe-c:
                skip       -> INCOMPLETE (ilk-hp8440p)
        Subgroup nonblocking-crc-pipe-a:
                pass       -> INCOMPLETE (ilk-hp8440p)
        Subgroup nonblocking-crc-pipe-a-frame-sequence:
                pass       -> INCOMPLETE (ilk-hp8440p)
        Subgroup nonblocking-crc-pipe-b:
                pass       -> INCOMPLETE (ilk-hp8440p)
        Subgroup nonblocking-crc-pipe-b-frame-sequence:
                pass       -> INCOMPLETE (ilk-hp8440p)
        Subgroup nonblocking-crc-pipe-c:
                skip       -> INCOMPLETE (ilk-hp8440p)
        Subgroup nonblocking-crc-pipe-c-frame-sequence:
                skip       -> INCOMPLETE (ilk-hp8440p)
        Subgroup read-crc-pipe-a:
                pass       -> INCOMPLETE (ilk-hp8440p)
        Subgroup read-crc-pipe-c:
                pass       -> DMESG-WARN (hsw-gt2)
                skip       -> INCOMPLETE (ilk-hp8440p)
        Subgroup read-crc-pipe-c-frame-sequence:
                skip       -> INCOMPLETE (ilk-hp8440p)
        Subgroup suspend-read-crc-pipe-a:
                pass       -> INCOMPLETE (snb-dellxps)
        Subgroup suspend-read-crc-pipe-b:
                dmesg-warn -> PASS       (skl-i5k-2) UNSTABLE
                pass       -> INCOMPLETE (ilk-hp8440p)
        Subgroup suspend-read-crc-pipe-c:
                pass       -> DMESG-WARN (skl-i5k-2) UNSTABLE
Test kms_psr_sink_crc:
        Subgroup psr_basic:
                skip       -> INCOMPLETE (ilk-hp8440p)
Test kms_sink_crc_basic:
                skip       -> INCOMPLETE (ilk-hp8440p)
Test pm_backlight:
        Subgroup basic-brightness:
                pass       -> INCOMPLETE (ilk-hp8440p)
Test pm_rpm:
        Subgroup basic-pci-d3-state:
                pass       -> DMESG-WARN (byt-nuc)
        Subgroup basic-rte:
                pass       -> DMESG-WARN (bsw-nuc-2)
                dmesg-warn -> PASS       (byt-nuc) UNSTABLE
Test prime_self_import:
        Subgroup basic-llseek-size:
                pass       -> INCOMPLETE (ilk-hp8440p)
        Subgroup basic-with_fd_dup:
                pass       -> INCOMPLETE (ilk-hp8440p)

bdw-nuci7        total:165  pass:154  dwarn:0   dfail:0   fail:0   skip:11 
bsw-nuc-2        total:168  pass:136  dwarn:1   dfail:0   fail:1   skip:30 
byt-nuc          total:168  pass:142  dwarn:1   dfail:0   fail:0   skip:25 
hsw-gt2          total:168  pass:156  dwarn:1   dfail:0   fail:1   skip:10 
ilk-hp8440p      total:168  pass:45   dwarn:0   dfail:0   fail:0   skip:22 
ivb-t430s        total:168  pass:153  dwarn:0   dfail:0   fail:0   skip:15 
skl-i5k-2        total:168  pass:151  dwarn:1   dfail:0   fail:0   skip:16 
snb-dellxps      total:48   pass:41   dwarn:0   dfail:0   fail:0   skip:6  
snb-x220t        total:168  pass:145  dwarn:0   dfail:1   fail:1   skip:21 

Results at /archive/results/CI_IGT_test/Patchwork_1458/

08fc1b101049694778bff7559e1d05250d2e7072 drm-intel-nightly: 2016y-02m-22d-17h-30m-27s UTC integration manifest
4a978a3497935cab1e4e462300c2955bfd8eeba3 drm/i915: Change WARN_ON(!wm_changed) to I915_STATE_WARN_ON()

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] drm/i915: Change WARN_ON(!wm_changed) to I915_STATE_WARN_ON()
  2016-02-22 19:22 [PATCH] drm/i915: Change WARN_ON(!wm_changed) to I915_STATE_WARN_ON() Lyude
  2016-02-23  9:04 ` ✗ Fi.CI.BAT: failure for " Patchwork
  2016-02-23 10:59 ` Patchwork
@ 2016-02-29 15:47 ` Daniel Vetter
  2016-02-29 16:19   ` Rob Clark
  2 siblings, 1 reply; 5+ messages in thread
From: Daniel Vetter @ 2016-02-29 15:47 UTC (permalink / raw)
  To: Lyude
  Cc: Daniel Vetter, intel-gfx, Rob Clark,
	open list:INTEL DRM DRIVERS excluding Poulsbo, Moorestow..., linux-kernel@vger.kernel.org open list

On Mon, Feb 22, 2016 at 02:22:49PM -0500, Lyude wrote:
> These warnings still seem to be present with DP MST configurations. They
> don't actually indicate any impending doom, so we may as well use
> I915_STATE_WARN_ON() here to help quiet things down a little bit for
> distro kernel users.
> 
> Signed-off-by: Lyude <cpaul@redhat.com>

I thought we've fixed up all offenders in drm-intel-nightly? Can you pls
confirm this is the case - this isn't something we should shrug off ...

Also, I kinda wonder whether we should try another attempt at enabling
this, in 4.6/fc rawhide perhaps, and see what happens? We /should/ be a
lot better with all this fail now.

I guess if this is all fixed in upstream/4.6 already then we could apply
this to 4.5 and stable kernels. But I don't really want this in upstream,
if it can be avoided.

Thanks, Daniel

> ---
>  drivers/gpu/drm/i915/intel_pm.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
> index a234687..1870185 100644
> --- a/drivers/gpu/drm/i915/intel_pm.c
> +++ b/drivers/gpu/drm/i915/intel_pm.c
> @@ -3545,7 +3545,7 @@ static void skl_update_other_pipe_wm(struct drm_device *dev,
>  		 * because it was really needed, so we expect the WM values to
>  		 * be different.
>  		 */
> -		WARN_ON(!wm_changed);
> +		I915_STATE_WARN_ON(!wm_changed);
>  
>  		skl_compute_wm_results(dev, &pipe_wm, r, intel_crtc);
>  		r->dirty[intel_crtc->pipe] = true;
> -- 
> 2.5.0
> 
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] drm/i915: Change WARN_ON(!wm_changed) to I915_STATE_WARN_ON()
  2016-02-29 15:47 ` [PATCH] " Daniel Vetter
@ 2016-02-29 16:19   ` Rob Clark
  0 siblings, 0 replies; 5+ messages in thread
From: Rob Clark @ 2016-02-29 16:19 UTC (permalink / raw)
  To: Daniel Vetter
  Cc: Daniel Vetter, intel-gfx,
	open list:INTEL DRM DRIVERS excluding Poulsbo, Moorestow..., linux-kernel@vger.kernel.org open list

On Feb 29 2016 or thereabouts, Daniel Vetter wrote:
> On Mon, Feb 22, 2016 at 02:22:49PM -0500, Lyude wrote:
> > These warnings still seem to be present with DP MST configurations. They
> > don't actually indicate any impending doom, so we may as well use
> > I915_STATE_WARN_ON() here to help quiet things down a little bit for
> > distro kernel users.
> > 
> > Signed-off-by: Lyude <cpaul@redhat.com>
> 
> I thought we've fixed up all offenders in drm-intel-nightly? Can you pls
> confirm this is the case - this isn't something we should shrug off ...
 
I was still seeing this w/ nightly as of perhaps ~mid last week..

Note that upstream default is still to have verbose state warn's so this
would still be the splat that you want to see ;-)

BR,
-R

> Also, I kinda wonder whether we should try another attempt at enabling
> this, in 4.6/fc rawhide perhaps, and see what happens? We /should/ be a
> lot better with all this fail now.
> 
> I guess if this is all fixed in upstream/4.6 already then we could apply
> this to 4.5 and stable kernels. But I don't really want this in upstream,
> if it can be avoided.
> 
> Thanks, Daniel
> 
> > ---
> >  drivers/gpu/drm/i915/intel_pm.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
> > index a234687..1870185 100644
> > --- a/drivers/gpu/drm/i915/intel_pm.c
> > +++ b/drivers/gpu/drm/i915/intel_pm.c
> > @@ -3545,7 +3545,7 @@ static void skl_update_other_pipe_wm(struct drm_device *dev,
> >  		 * because it was really needed, so we expect the WM values to
> >  		 * be different.
> >  		 */
> > -		WARN_ON(!wm_changed);
> > +		I915_STATE_WARN_ON(!wm_changed);
> >  
> >  		skl_compute_wm_results(dev, &pipe_wm, r, intel_crtc);
> >  		r->dirty[intel_crtc->pipe] = true;
> > -- 
> > 2.5.0
> > 
> > _______________________________________________
> > dri-devel mailing list
> > dri-devel@lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/dri-devel
> 
> -- 
> Daniel Vetter
> Software Engineer, Intel Corporation
> http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2016-02-29 16:19 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-02-22 19:22 [PATCH] drm/i915: Change WARN_ON(!wm_changed) to I915_STATE_WARN_ON() Lyude
2016-02-23  9:04 ` ✗ Fi.CI.BAT: failure for " Patchwork
2016-02-23 10:59 ` Patchwork
2016-02-29 15:47 ` [PATCH] " Daniel Vetter
2016-02-29 16:19   ` Rob Clark

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).