From: Daniel Stone <daniels@collabora.com>
To: Chris Wilson <chris@chris-wilson.co.uk>,
Tomeu Vizoso <tomeu.vizoso@collabora.com>
Cc: Micah Fedke <micah.fedke@collabora.com>,
Intel GFX discussion <intel-gfx@lists.freedesktop.org>,
Gustavo Padovan <gustavo.padovan@collabora.co.uk>,
Emil Velikov <emil.velikov@collabora.com>
Subject: Re: [i-g-t PATCH v1 07/14] lib: Map dumb buffers
Date: Wed, 02 Mar 2016 14:22:58 +0000 [thread overview]
Message-ID: <1456928578.5573.0.camel@collabora.com> (raw)
In-Reply-To: <20160302142154.GE30782@nuc-i3427.alporthouse.com>
On Wed, 2016-03-02 at 14:21 +0000, Chris Wilson wrote:
> On Wed, Mar 02, 2016 at 03:00:14PM +0100, Tomeu Vizoso wrote:
> > @@ -1006,8 +1019,9 @@ static cairo_surface_t *get_cairo_surface(int
> > fd, struct igt_fb *fb)
> > create_cairo_surface__gtt(fd, fb);
> > }
> >
> > - gem_set_domain(fd, fb->gem_handle,
> > - I915_GEM_DOMAIN_CPU, I915_GEM_DOMAIN_CPU);
> > + if (!fb->is_dumb)
> > + gem_set_domain(fd, fb->gem_handle,
> > I915_GEM_DOMAIN_CPU,
> > + I915_GEM_DOMAIN_CPU);
> At the risk of opening a can-of-worms, what is the synchronisation
> protocol for dumb buffers? Even CPU access to a dumb needs set-domain
> on
> Intel.
Then Intel is broken, because the literal entire point of dumb buffers
is that you do not require driver-specific calls to operate them.
Map, populate, unmap, display.
Cheers,
Daniel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2016-03-02 14:23 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-02 14:00 [i-g-t PATCH v1 00/14] Get a few more tests to run on !i915 Tomeu Vizoso
2016-03-02 14:00 ` [i-g-t PATCH v1 01/14] lib: add igt_require_intel Tomeu Vizoso
2016-03-02 14:18 ` Chris Wilson
2016-03-02 14:00 ` [i-g-t PATCH v1 02/14] lib: Have gem_set_tiling require intel Tomeu Vizoso
2016-03-02 14:00 ` [i-g-t PATCH v1 03/14] lib: Expose is_i915_device Tomeu Vizoso
2016-03-02 14:00 ` [i-g-t PATCH v1 04/14] lib: Have intel_get_drm_devid call igt_require_intel Tomeu Vizoso
2016-03-02 14:00 ` [i-g-t PATCH v1 05/14] lib: Call intel_get_drm_devid only from intel code Tomeu Vizoso
2016-03-02 14:00 ` [i-g-t PATCH v1 06/14] lib: Add wrapper for DRM_IOCTL_MODE_CREATE_DUMB Tomeu Vizoso
2016-03-05 12:21 ` Daniel Vetter
2016-03-02 14:00 ` [i-g-t PATCH v1 07/14] lib: Map dumb buffers Tomeu Vizoso
2016-03-02 14:21 ` Chris Wilson
2016-03-02 14:22 ` Daniel Stone [this message]
2016-03-02 14:39 ` Chris Wilson
2016-03-02 14:40 ` Daniel Stone
2016-03-02 14:54 ` Chris Wilson
2016-03-02 15:41 ` Daniel Stone
2016-03-05 12:24 ` Daniel Vetter
2016-03-05 12:27 ` Daniel Vetter
2016-03-02 14:00 ` [i-g-t PATCH v1 08/14] lib: Add igt_create_bo_with_dimensions Tomeu Vizoso
2016-03-05 12:30 ` Daniel Vetter
2016-03-07 16:19 ` Tomeu Vizoso
2016-03-07 16:25 ` Ville Syrjälä
2016-03-08 11:45 ` Daniel Stone
2016-11-01 15:44 ` Tvrtko Ursulin
2016-11-10 13:17 ` Tomeu Vizoso
2016-11-10 16:23 ` Tvrtko Ursulin
2016-11-11 11:23 ` Tomeu Vizoso
2016-11-11 11:33 ` Tvrtko Ursulin
2016-11-11 13:14 ` Tomeu Vizoso
2016-03-02 14:00 ` [i-g-t PATCH v1 09/14] tests: Open any driver Tomeu Vizoso
2016-03-02 14:00 ` [i-g-t PATCH v1 10/14] kms_addfb_basic: call igt_create_bo_with_dimensions Tomeu Vizoso
2016-03-02 14:00 ` [i-g-t PATCH v1 11/14] kms_addfb_basic: move tiling functionality into each subtest Tomeu Vizoso
2016-03-02 14:00 ` [i-g-t PATCH v1 12/14] kms_addfb_basic: Split tiling_tests off Tomeu Vizoso
2016-03-05 12:33 ` Daniel Vetter
2016-03-07 16:08 ` Tomeu Vizoso
2016-03-02 14:00 ` [i-g-t PATCH v1 13/14] kms_addfb_basic: Move calls to gem_set_tiling to the subtests Tomeu Vizoso
2016-03-02 14:00 ` [i-g-t PATCH v1 14/14] kms_addfb_basic: Get intel gen from within subtest Tomeu Vizoso
2016-03-05 12:34 ` [i-g-t PATCH v1 00/14] Get a few more tests to run on !i915 Daniel Vetter
2016-04-14 12:56 ` Daniel Stone
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1456928578.5573.0.camel@collabora.com \
--to=daniels@collabora.com \
--cc=chris@chris-wilson.co.uk \
--cc=emil.velikov@collabora.com \
--cc=gustavo.padovan@collabora.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
--cc=micah.fedke@collabora.com \
--cc=tomeu.vizoso@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).