public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
From: "Vivi, Rodrigo" <rodrigo.vivi@intel.com>
To: "ville.syrjala@linux.intel.com" <ville.syrjala@linux.intel.com>,
	"intel-gfx@lists.freedesktop.org"
	<intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH 1/5] Revert "drm/i915: Enable PSR by default on Valleyview and Cherryview."
Date: Wed, 9 Mar 2016 17:14:05 +0000	[thread overview]
Message-ID: <1457543698.7658.29.camel@intel.com> (raw)
In-Reply-To: <1457543247-13987-2-git-send-email-ville.syrjala@linux.intel.com>

Acked-by: Rodrigo Vivi <rodrigo.vivi@intel.com>

I confirm this is hitting BAT hard on CHV.

I'm working here to handle this PSR exit on VBlanks on CHV already, but
the vblanks spinlocks are giving me headaches... 

So better to revert.

thanks for the finding, ideas and this revert...

On Wed, 2016-03-09 at 19:07 +0200, ville.syrjala@linux.intel.com wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> 
> This reverts commit a38c274faad0ec6aba692e294ec751d04dbba803.
> 
> PSR causes all sorts of vblank wait timeouts and whanot on CHV.
> Disable
> it again.
> 
> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> Fixes: a38c274faad0 ("drm/i915: Enable PSR by default on Valleyview
> and Cherryview.")
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> ---
>  drivers/gpu/drm/i915/intel_psr.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/intel_psr.c
> b/drivers/gpu/drm/i915/intel_psr.c
> index b1413beb00d1..38e95185d9c6 100644
> --- a/drivers/gpu/drm/i915/intel_psr.c
> +++ b/drivers/gpu/drm/i915/intel_psr.c
> @@ -781,8 +781,7 @@ void intel_psr_init(struct drm_device *dev)
>  
>  	/* Per platform default */
>  	if (i915.enable_psr == -1) {
> -		if (IS_HASWELL(dev) || IS_BROADWELL(dev) ||
> -		    IS_VALLEYVIEW(dev) || IS_CHERRYVIEW(dev))
> +		if (IS_HASWELL(dev) || IS_BROADWELL(dev))
>  			i915.enable_psr = 1;
>  		else
>  			i915.enable_psr = 0;
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2016-03-09 17:14 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-09 17:07 [PATCH 0/5] drm/i915: CHV regressions fixes ville.syrjala
2016-03-09 17:07 ` [PATCH 1/5] Revert "drm/i915: Enable PSR by default on Valleyview and Cherryview." ville.syrjala
2016-03-09 17:14   ` Vivi, Rodrigo [this message]
2016-03-10  9:41   ` Maarten Lankhorst
2016-03-09 17:07 ` [PATCH 2/5] drm/i915: Pass the correct crtc state to .update_plane() ville.syrjala
2016-03-10  9:41   ` Maarten Lankhorst
2016-03-09 17:07 ` [PATCH 3/5] drm/i915: Fix watermarks for VLV/CHV ville.syrjala
2016-03-10  9:09   ` Maarten Lankhorst
2016-03-10 10:33     ` Ville Syrjälä
2016-03-10 11:53       ` Maarten Lankhorst
2016-03-10 12:03         ` Ville Syrjälä
2016-03-09 17:07 ` [PATCH 4/5] drm/i915: Wait for vblank after cxsr disable in pre_plane_update ville.syrjala
2016-03-09 17:07 ` [PATCH 5/5] drm/i915: s/crtc_state/old_crtc_state/ in intel_atomic_commit() ville.syrjala
2016-03-09 17:31 ` ✗ Fi.CI.BAT: failure for drm/i915: CHV regressions fixes Patchwork
2016-03-09 18:03   ` Ville Syrjälä

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1457543698.7658.29.camel@intel.com \
    --to=rodrigo.vivi@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=ville.syrjala@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox