From: "Vivi, Rodrigo" <rodrigo.vivi@intel.com>
To: "intel-gfx@lists.freedesktop.org"
<intel-gfx@lists.freedesktop.org>,
"Feceoru, Gabriel" <gabriel.feceoru@intel.com>
Cc: "Yates, Alexandra" <alexandra.yates@intel.com>,
"baker.dylan.c@gmail.com" <baker.dylan.c@gmail.com>
Subject: Re: [PATCH i-g-t] scripts/run-test.sh: Piglit overwrite option.
Date: Tue, 22 Mar 2016 02:05:19 +0000 [thread overview]
Message-ID: <1458612317.27320.29.camel@intel.com> (raw)
In-Reply-To: <56EFDABB.40605@intel.com>
ops, I have missed that. I'm really sorry Gabriel for duplicating that
effort.
After we figure out what to do with different piglit versions we can
take yours...
Sorry,
Rodrigo.
On Mon, 2016-03-21 at 13:27 +0200, Gabriel Feceoru wrote:
>
> On 18.03.2016 16:02, Rodrigo Vivi wrote:
> > The following piglit commit adds one option to overwrite files:
> >
> > commit ec317ece07afdf9c8a26de04bdec8a94e5d7b2db
> > Author: Dylan Baker <baker.dylan.c@gmail.com>
> > Date: Mon Feb 1 15:08:23 2016 -0800
> >
> > framework/programs/run.py: Add option for overwriting files
> >
> > So our run-script.sh test that creates the directory before
> > executing
> > the tests were failing with:
> >
> > "Fatal Error: Cannot overwrite existing folder w/o the -o /-
> > -overwrite option being sent"
> >
> > I believe it took a while to notice that because many of us never
> > upgrade the piglit. But also the risk with this patch is to have an
> > environment
> > with the old piglit so the result will be:
> > piglit: error: unrecognized arguments: --overwrite
> >
> > So, let's start the discussion and also provide the patch that
> > allows
> > some people with new version to get it running.
> >
> > Cc: Dylan Baker <baker.dylan.c@gmail.com>
> > Cc: Alexandra Yates <alexandra.yates@intel.com>
> > Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
> > ---
> > scripts/run-tests.sh | 3 +--
> > 1 file changed, 1 insertion(+), 2 deletions(-)
> >
> > diff --git a/scripts/run-tests.sh b/scripts/run-tests.sh
> > index 99e6124..b1abeab 100755
> > --- a/scripts/run-tests.sh
> > +++ b/scripts/run-tests.sh
> > @@ -124,8 +124,7 @@ fi
> > if [ "x$RESUME" != "x" ]; then
> > sudo IGT_TEST_ROOT="$IGT_TEST_ROOT" "$PIGLIT" resume
> > "$RESULTS" $NORETRY
> > else
> > - mkdir -p "$RESULTS"
> > - sudo IGT_TEST_ROOT="$IGT_TEST_ROOT" "$PIGLIT" run igt
> > "$RESULTS" -s $VERBOSE $EXCLUDE $FILTER
> > + sudo IGT_TEST_ROOT="$IGT_TEST_ROOT" "$PIGLIT" run -
> > -overwrite igt "$RESULTS" -s $VERBOSE $EXCLUDE $FILTER
> > fi
> >
> > if [ "$SUMMARY" == "html" ]; then
> >
>
> I've sent something similar some time ago:
>
> https://patchwork.freedesktop.org/patch/76050/
>
> Gabriel.
>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
prev parent reply other threads:[~2016-03-22 2:05 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-18 14:02 [PATCH i-g-t] scripts/run-test.sh: Piglit overwrite option Rodrigo Vivi
2016-03-21 10:53 ` Marius Vlad
2016-03-22 2:00 ` Vivi, Rodrigo
2016-03-22 16:34 ` Dylan Baker
2016-03-24 1:52 ` Vivi, Rodrigo
2016-03-24 15:17 ` Dylan Baker
2016-03-21 11:27 ` Gabriel Feceoru
2016-03-22 2:05 ` Vivi, Rodrigo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1458612317.27320.29.camel@intel.com \
--to=rodrigo.vivi@intel.com \
--cc=alexandra.yates@intel.com \
--cc=baker.dylan.c@gmail.com \
--cc=gabriel.feceoru@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).