public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
* [PATCH] drm/i915/bxt: Reversed polarity of PORT_PLL_REF_SEL bit
@ 2016-03-15 23:37 Dongwon Kim
  2016-03-16  9:01 ` Imre Deak
                   ` (3 more replies)
  0 siblings, 4 replies; 11+ messages in thread
From: Dongwon Kim @ 2016-03-15 23:37 UTC (permalink / raw)
  To: intel-gfx; +Cc: Dongwon Kim

For BXT, Polarity of PORT_PLL_REF_SEL is reversed in
its description in Bspec. This bit should be set for
"Non-SSC".

Signed-off-by: Dongwon Kim <dongwon.kim@intel.com>
---
 drivers/gpu/drm/i915/intel_dpll_mgr.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/intel_dpll_mgr.c b/drivers/gpu/drm/i915/intel_dpll_mgr.c
index 4b636c4..d55b308 100644
--- a/drivers/gpu/drm/i915/intel_dpll_mgr.c
+++ b/drivers/gpu/drm/i915/intel_dpll_mgr.c
@@ -1285,7 +1285,7 @@ static void bxt_ddi_pll_enable(struct drm_i915_private *dev_priv,
 	enum port port = (enum port)pll->id;	/* 1:1 port->PLL mapping */
 
 	temp = I915_READ(BXT_PORT_PLL_ENABLE(port));
-	temp &= ~PORT_PLL_REF_SEL;
+	temp |= PORT_PLL_REF_SEL;
 	/* Non-SSC reference */
 	I915_WRITE(BXT_PORT_PLL_ENABLE(port), temp);
 
-- 
1.9.1

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply related	[flat|nested] 11+ messages in thread

end of thread, other threads:[~2016-04-11 10:10 UTC | newest]

Thread overview: 11+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-03-15 23:37 [PATCH] drm/i915/bxt: Reversed polarity of PORT_PLL_REF_SEL bit Dongwon Kim
2016-03-16  9:01 ` Imre Deak
2016-03-16 11:58 ` ✗ Fi.CI.BAT: failure for " Patchwork
2016-03-16 16:58   ` dw kim
2016-03-17  1:06 ` [PATCH] " Dongwon Kim
2016-03-22  9:10   ` Imre Deak
2016-03-22 17:33     ` dw kim
2016-04-11 10:00   ` Imre Deak
2016-03-17 13:03 ` ✗ Fi.CI.BAT: failure for drm/i915/bxt: Reversed polarity of PORT_PLL_REF_SEL bit (rev2) Patchwork
2016-03-17 18:05   ` dw kim
2016-04-11 10:10     ` Imre Deak

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox