From: Lyude <cpaul@redhat.com>
To: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org
Cc: arthur.j.runyan@intel.com,
"Ville Syrjälä" <ville.syrjala@linux.intel.com>,
"Jani Nikula" <jani.nikula@linux.intel.com>,
Lyude <cpaul@redhat.com>, "David Airlie" <airlied@linux.ie>,
"open list" <linux-kernel@vger.kernel.org>,
"Daniel Vetter" <daniel.vetter@intel.com>
Subject: [PATCH v4 0/5] Move workarounds from intel_dp_dpcd_read_wake() into drm's DP helpers
Date: Thu, 24 Mar 2016 14:27:05 -0400 [thread overview]
Message-ID: <1458844031-2032-1-git-send-email-cpaul@redhat.com> (raw)
In-Reply-To: <1458761417-12165-1-git-send-email-cpaul@redhat.com>
This series of patches takes all of the workarounds we used in
intel_dp_dpcd_read_wake() for working around misbehaving sinks into drm's DP
aux transaction helpers, so that they can be applied to all aux transactions
across each driver. While this patch series was intended to fix issues with the
ThinkPad T560 not bringing displays connected to it's dock back up properly
after suspend, this should fix a lot of other various DP issues by ensuring
that we retry transactions appropriately in every possible failure scenario.
Changes since v3
- Split the patch that moves the logic out of intel_dp_dpcd_read_wake() into
multiple patches for each workaround that we apply, so that bisecting this
change isn't difficult in the event that this breaks something
- Made sure that drm_dp_dpcd_read() only returns the error it encountered during
the first attempted aux transaction, since the error that following retries
encounter might be different from the original
Changes since v2
- Reworked the patch again to incorporate all of the behavior of
intel_dp_dpcd_read_wake() into drm_dp_dpcd_read() and drm_dp_dpcd_access()
Changes since v1
- Patch has been reworked to take the retry logic out of intel_dp_mst_resume()
and into drm_dp_dpcd_access(), based off a suggestion from Daniel Vetter
- Commit message is much longer and gives a better description of the
issue this was originally intended to workaround.
Lyude (5):
drm/dp_helper: Increase retry interval to 1000us
drm/dp_helper: Always wait before retrying native aux transactions
drm/dp_helper: Retry aux transactions on all errors
drm/dp_helper: Perform throw-away read before actual read in
drm_dp_dpcd_read()
drm/i915: Get rid of intel_dp_dpcd_read_wake()
drivers/gpu/drm/drm_dp_helper.c | 55 ++++++++++++++++------------
drivers/gpu/drm/i915/intel_dp.c | 79 ++++++++++++-----------------------------
2 files changed, 54 insertions(+), 80 deletions(-)
--
2.5.5
next prev parent reply other threads:[~2016-03-24 18:27 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-17 15:40 [PATCH 1/2] drm/dp_helper: retry on -ETIMEDOUT in drm_dp_dpcd_access() Lyude
2016-03-17 15:40 ` [PATCH 2/2] drm/i915: Get rid of intel_dp_dpcd_read_wake() Lyude
2016-03-17 17:56 ` Jani Nikula
2016-03-18 15:57 ` [Intel-gfx] " Daniel Vetter
2016-03-18 14:13 ` Ville Syrjälä
2016-03-18 16:12 ` [Intel-gfx] " Ville Syrjälä
2016-03-18 16:41 ` Ville Syrjälä
2016-03-18 18:00 ` Daniel Vetter
2016-03-18 18:05 ` [Intel-gfx] " Ville Syrjälä
2016-03-21 16:37 ` Lyude Paul
2016-03-21 10:30 ` Jani Nikula
2016-03-21 13:38 ` Ville Syrjälä
2016-03-18 8:13 ` ✗ Fi.CI.BAT: failure for series starting with [1/2] drm/dp_helper: retry on -ETIMEDOUT in drm_dp_dpcd_access() Patchwork
2016-03-23 19:30 ` [PATCH v3 1/2] drm/dp_helper: add workarounds from intel_dp_dpcd_read_wake() Lyude
2016-03-23 19:33 ` [PATCH v3 1/2 RESEND] " Lyude
2016-03-24 9:37 ` Jani Nikula
2016-03-24 18:27 ` Lyude [this message]
2016-03-24 18:27 ` [PATCH v4 1/5] drm/dp_helper: Increase retry interval to 1000us Lyude
2016-03-24 18:27 ` [PATCH v4 2/5] drm/dp_helper: Always wait before retrying native aux transactions Lyude
2016-03-24 18:27 ` [PATCH v4 3/5] drm/dp_helper: Retry aux transactions on all errors Lyude
2016-03-24 18:27 ` [PATCH v4 4/5] drm/dp_helper: Perform throw-away read before actual read in drm_dp_dpcd_read() Lyude
2016-03-24 18:27 ` [PATCH v4 5/5] drm/i915: Get rid of intel_dp_dpcd_read_wake() Lyude
2016-03-25 7:44 ` ✗ Fi.CI.BAT: failure for series starting with [v3,1/2,RESEND] drm/dp_helper: add workarounds from intel_dp_dpcd_read_wake() Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1458844031-2032-1-git-send-email-cpaul@redhat.com \
--to=cpaul@redhat.com \
--cc=airlied@linux.ie \
--cc=arthur.j.runyan@intel.com \
--cc=daniel.vetter@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).