From mboxrd@z Thu Jan  1 00:00:00 1970
From: Lyude Paul <cpaul@redhat.com>
Subject: Re: [PATCH v4 RESEND 1/5] drm/dp_helper: Increase retry interval to
 1000us
Date: Tue, 29 Mar 2016 10:05:40 -0400
Message-ID: <1459260340.15060.0.camel@redhat.com>
References: <1459175606-13875-1-git-send-email-cpaul@redhat.com>
	 <1459175606-13875-2-git-send-email-cpaul@redhat.com>
	 <20160329082732.GL2510@phenom.ffwll.local>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: QUOTED-PRINTABLE
Return-path: <linux-kernel-owner@vger.kernel.org>
In-Reply-To: <20160329082732.GL2510@phenom.ffwll.local>
Sender: linux-kernel-owner@vger.kernel.org
To: Daniel Vetter <daniel@ffwll.ch>
Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, arthur.j.runyan@intel.com, open list <linux-kernel@vger.kernel.org>
List-Id: intel-gfx@lists.freedesktop.org

Yep, the rest of the patchset works fine without this patch

On Tue, 2016-03-29 at 10:27 +0200, Daniel Vetter wrote:
> On Mon, Mar 28, 2016 at 10:33:22AM -0400, Lyude wrote:
> >=20
> > This is part of a patch series to migrate all of the workarounds fo=
r
> > commonly seen behavior from bad sinks in intel_dp_dpcd_read_wake() =
to
> > drm's DP helper.
> >=20
> > Signed-off-by: Lyude <cpaul@redhat.com>
> > ---
> > =C2=A0drivers/gpu/drm/drm_dp_helper.c | 2 +-
> > =C2=A01 file changed, 1 insertion(+), 1 deletion(-)
> >=20
> > diff --git a/drivers/gpu/drm/drm_dp_helper.c
> > b/drivers/gpu/drm/drm_dp_helper.c
> > index 7d58f59..d1128fb 100644
> > --- a/drivers/gpu/drm/drm_dp_helper.c
> > +++ b/drivers/gpu/drm/drm_dp_helper.c
> > @@ -160,7 +160,7 @@ int drm_dp_bw_code_to_link_rate(u8 link_bw)
> > =C2=A0}
> > =C2=A0EXPORT_SYMBOL(drm_dp_bw_code_to_link_rate);
> > =C2=A0
> > -#define AUX_RETRY_INTERVAL 500 /* us */
> > +#define AUX_RETRY_INTERVAL 1000 /* us */
> Was this to adapt to the msleep(1) in the i915 function? If so it's k=
inda
> wrong anyway, since an msleep(1) actually sleeps 1 jiffy, and on most
> systems that's a lot more than 1 ms. If it all still works, I'd just =
drop
> this patch here. I suspect that the magic is all in the more aggressi=
ve
> retrying and the throwaway read, not in how long we actually wait.
>=20
> On patches 2-5: Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
>=20
> >=20
> > =C2=A0
> > =C2=A0/**
> > =C2=A0 * DOC: dp helpers
> > --=C2=A0
> > 2.5.5
> >=20
> > _______________________________________________
> > dri-devel mailing list
> > dri-devel@lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/dri-devel
--=20
Cheers,
	Lyude