From: Deepak M <m.deepak@intel.com>
To: intel-gfx@lists.freedesktop.org
Cc: Deepak M <m.deepak@intel.com>,
Jani Nikula <jani.nikula@intel.com>,
Yetunde Adebisi <yetundex.adebisi@intel.com>,
Daniel Vetter <daniel.vetter@intel.com>
Subject: [PATCH 2/5] drm/i915: Parsing the PWM cntrl and CABC ON/OFF fields in VBT
Date: Tue, 29 Mar 2016 20:13:18 +0530 [thread overview]
Message-ID: <1459262601-20132-2-git-send-email-m.deepak@intel.com> (raw)
In-Reply-To: <1459262601-20132-1-git-send-email-m.deepak@intel.com>
For dual link panel scenarios there are new fields added in the
VBT which indicate on which port the PWM cntrl and CABC ON/OFF
commands needs to be sent.
v2: Moving the comment to intel_dsi.h(Jani)
v3: Renaming the field names (Jani)
Cc: Jani Nikula <jani.nikula@intel.com>
Cc: Daniel Vetter <daniel.vetter@intel.com>
Cc: Yetunde Adebisi <yetundex.adebisi@intel.com>
Signed-off-by: Deepak M <m.deepak@intel.com>
---
drivers/gpu/drm/i915/intel_bios.c | 10 ++++++++++
drivers/gpu/drm/i915/intel_bios.h | 5 ++++-
drivers/gpu/drm/i915/intel_dsi.h | 9 +++++++++
3 files changed, 23 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/intel_bios.c b/drivers/gpu/drm/i915/intel_bios.c
index 083003b..1af7074 100644
--- a/drivers/gpu/drm/i915/intel_bios.c
+++ b/drivers/gpu/drm/i915/intel_bios.c
@@ -749,6 +749,16 @@ parse_mipi_config(struct drm_i915_private *dev_priv,
return;
}
+ /*
+ * These fileds are introduced from the VBT version 197 onwards,
+ * so making sure that these bits are set zero in the pervious
+ * versions.
+ */
+ if (dev_priv->vbt.dsi.config->dual_link && bdb->version < 197) {
+ dev_priv->vbt.dsi.config->dl_cabc_ports = 0;
+ dev_priv->vbt.dsi.config->dl_panel_pwm_ports = 0;
+ }
+
/* We have mandatory mipi config blocks. Initialize as generic panel */
dev_priv->vbt.dsi.panel_id = MIPI_DSI_GENERIC_PANEL_ID;
}
diff --git a/drivers/gpu/drm/i915/intel_bios.h b/drivers/gpu/drm/i915/intel_bios.h
index ab0ea31..fdfb634 100644
--- a/drivers/gpu/drm/i915/intel_bios.h
+++ b/drivers/gpu/drm/i915/intel_bios.h
@@ -113,7 +113,10 @@ struct mipi_config {
u16 dual_link:2;
u16 lane_cnt:2;
u16 pixel_overlap:3;
- u16 rsvd3:9;
+ u16 rgb_flip:1;
+ u16 dl_cabc_ports:2;
+ u16 dl_panel_pwm_ports:2;
+ u16 rsvd3:4;
u16 rsvd4;
diff --git a/drivers/gpu/drm/i915/intel_dsi.h b/drivers/gpu/drm/i915/intel_dsi.h
index e582ef8..f54748d 100644
--- a/drivers/gpu/drm/i915/intel_dsi.h
+++ b/drivers/gpu/drm/i915/intel_dsi.h
@@ -78,6 +78,15 @@ struct intel_dsi {
u8 escape_clk_div;
u8 dual_link;
+
+ /*
+ * Below field will inform us on which port the panel blk_cntrl
+ * and CABC ON/OFF commands needs to be sent in case of dual link
+ * panels
+ */
+ u8 cabc_dcs_ports;
+ u8 panel_pwm_dcs_ports;
+
u8 pixel_overlap;
u32 port_bits;
u32 bw_timer;
--
1.9.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2016-03-29 14:43 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-29 14:43 [PATCH 1/5] drm: Add new DCS commands in the enum list Deepak M
2016-03-29 14:43 ` Deepak M [this message]
2016-03-29 14:43 ` [PATCH 3/5] drm/i915: Parse LFP brightness control field in VBT Deepak M
2016-03-29 14:43 ` [PATCH 4/5] drm/i915: Add DCS control for Panel PWM Deepak M
2016-03-29 14:43 ` [PATCH 5/5] drm/i915: CABC support for Panel PWM backlight control Deepak M
2016-03-29 15:33 ` ✗ Fi.CI.BAT: failure for series starting with [1/5] drm: Add new DCS commands in the enum list Patchwork
-- strict thread matches above, loose matches on Subject: below --
2016-03-30 14:03 [PATCH 1/5] " Jani Nikula
2016-03-30 14:03 ` [PATCH 2/5] drm/i915: Parsing the PWM cntrl and CABC ON/OFF fields in VBT Jani Nikula
2016-04-26 12:52 ` Jani Nikula
2016-03-29 15:01 [PATCH 0/5] drm/i915: dsi dcs & cabc backlight control Jani Nikula
2016-03-29 15:01 ` [PATCH 2/5] drm/i915: Parsing the PWM cntrl and CABC ON/OFF fields in VBT Jani Nikula
2016-03-28 9:35 Deepak M
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1459262601-20132-2-git-send-email-m.deepak@intel.com \
--to=m.deepak@intel.com \
--cc=daniel.vetter@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
--cc=yetundex.adebisi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).